support target specific optimized-compiler-builtins
#135326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Signed-off-by: onur-ozkan <work@onurozkan.dev>
rustbot
added
S-waiting-on-review
|
This PR modifies If appropriate, please update This PR modifies If appropriate, please update |
Signed-off-by: onur-ozkan <work@onurozkan.dev>
|
|
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 11, 2025
Rollup of 6 pull requests Successful merges: - rust-lang#134074 (bootstrap: `std::io::ErrorKind::CrossesDevices` is finally stable) - rust-lang#135236 (Update a bunch of library types for MCP807) - rust-lang#135301 (re-add a warning for old master branch, but with much simpler logic) - rust-lang#135324 (Initial fs module for uefi) - rust-lang#135326 (support target specific `optimized-compiler-builtins`) - rust-lang#135347 (Use `NonNull::without_provenance` within the standard library) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 11, 2025
Rollup merge of rust-lang#135326 - onur-ozkan:target-specific-compiler-builtins, r=jieyouxu support target specific `optimized-compiler-builtins` Makes it possible to control `optimized-compiler-builtins` for per target. This was raised in the [zulip discussion](https://rust-lang.zulipchat.com/#narrow/channel/326414-t-infra.2Fbootstrap/topic/Building.20and.20packaging.20Rust.20with.20x86_64-unknown-uefi.20support/near/492765883) yesterday.
algitbot
pushed a commit
to alpinelinux/aports
that referenced
this pull request
Apr 27, 2025
Enable support for compiling for UEFI targets. This includes compiling binaries such as bootloaders, stubs for EFI bundles and similar utilities. Specifically, I used this functionality to finish work a minimal EFI stub, candyboot: https://git.sr.ht/~whynothugo/candyboot The UEFI target is only supported by LLVM. GCC cannot produce native EFI binaries. When compiling for a UEFI target, GCC produces ELF binaries and uses GNU-EFI as a stub loader to run them inside EFI environments. This approach does not work when compiling Rust. The profiler_builtins crate fails to build for the UEFI target; it is a C component which requires a UEFI specific sysroot to compile. During coordination with upstream, it came up these compiler built-ins could not be disabled on a per-target basis. This is now implemented upstream, and available in Rust stable since 1.86.0. See: rust-lang/rust#135326
bell-sw
pushed a commit
to bell-sw/alpaquita-aports
that referenced
this pull request
Apr 30, 2025
[ commit 4756039a3acf53cce7f9ad22921a66a59bf19e45 ] Enable support for compiling for UEFI targets. This includes compiling binaries such as bootloaders, stubs for EFI bundles and similar utilities. Specifically, I used this functionality to finish work a minimal EFI stub, candyboot: https://git.sr.ht/~whynothugo/candyboot The UEFI target is only supported by LLVM. GCC cannot produce native EFI binaries. When compiling for a UEFI target, GCC produces ELF binaries and uses GNU-EFI as a stub loader to run them inside EFI environments. This approach does not work when compiling Rust. The profiler_builtins crate fails to build for the UEFI target; it is a C component which requires a UEFI specific sysroot to compile. During coordination with upstream, it came up these compiler built-ins could not be disabled on a per-target basis. This is now implemented upstream, and available in Rust stable since 1.86.0. See: rust-lang/rust#135326
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it possible to control
optimized-compiler-builtinsfor per target.This was raised in the zulip discussion yesterday.