Run clippy for rustc_codegen_gcc on CI #135478
Conversation
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
|
r? antoyo (for the set of Clippy lints) Then I'll probably |
|
Failed to set assignee to
|
|
CC @antoyo |
|
It seems like it might not be checking for default clippy rules, if I look at the old logs. For instance, I had this clippy warning about nested Is there any reason why it didn't show if the old logs? |
|
Right now, we allow everything, and deny only correctness issues. I guess that I could try to change that to just |
Yes, I would appreciate the same behavior as the CI of cg_gcc, please. |
|
Well, the Clippy version might be slightly different, but hopefully otherwise it should match now. I'm a bit worried that if we use just |
|
r? infra |
rustbot
added
the
T-infra
|
r? @onur-ozkan |
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#133700 (const-eval: detect more pointers as definitely not-null) - rust-lang#135290 (Encode constraints that hold at all points as logical edges in location-sensitive polonius) - rust-lang#135478 (Run clippy for rustc_codegen_gcc on CI) - rust-lang#135583 (Move `std::pipe::*` into `std::io`) - rust-lang#135612 (Include x scripts in tarballs) - rust-lang#135624 (ci: mirror buildkit image to ghcr) - rust-lang#135661 (Stabilize `float_next_up_down`) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#135478 - Kobzol:gcc-clippy, r=onur-ozkan Run clippy for rustc_codegen_gcc on CI Requested on [Zulip](https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/Run.20clippy.20for.20rustc_codegen_gcc.20in.20the.20Rust.20CI). Opening as a draft, since it's not clear which rules should be applied to it. r? `@ghost`
Requested on Zulip.
Opening as a draft, since it's not clear which rules should be applied to it.
r? @ghost