Skip to content

Add license-metadata.json to rustc-src tarball. #135588

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

jonathanpallant
Copy link
Contributor

Adds a license-metadata.json to the source tarball.

This file was reported as missing as a comment on #133461, and it prevents you building the compiler from the source tarball (unless you re-generate it yourself, which is non-obvious and requires reuse to be installed).

r? Kobzol

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jan 16, 2025
@Kobzol
Copy link
Contributor

Kobzol commented Jan 16, 2025

Makes sense, thanks!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jan 16, 2025

📌 Commit 1fcbb4d has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 16, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 16, 2025
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#134754 (Implement `use` associated items of traits)
 - rust-lang#135481 (coverage: Completely overhaul counter assignment, using node-flow graphs)
 - rust-lang#135504 (Allow coercing safe-to-call target_feature functions to safe fn pointers)
 - rust-lang#135561 (Update docs for `-Clink-dead-code` to discourage its use)
 - rust-lang#135574 (ci: mirror ubuntu:22.04 to ghcr.io)
 - rust-lang#135585 (resolve symlinks of LLVM tool binaries before copying them)
 - rust-lang#135588 (Add license-metadata.json to rustc-src tarball.)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f4bbe30 into rust-lang:master Jan 17, 2025
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 17, 2025
Rollup merge of rust-lang#135588 - ferrocene:add-license-json-to-source-tarball, r=Kobzol

Add license-metadata.json to rustc-src tarball.

Adds a license-metadata.json to the source tarball.

This file was reported as missing as a comment on rust-lang#133461, and it prevents you building the compiler from the source tarball (unless you re-generate it yourself, which is non-obvious and requires `reuse` to be installed).

r? Kobzol
@rustbot rustbot added this to the 1.86.0 milestone Jan 17, 2025
@tshepang tshepang deleted the add-license-json-to-source-tarball branch January 17, 2025 04:04
bors-ferrocene bot added a commit to ferrocene/ferrocene that referenced this pull request Mar 25, 2025
1375: add complete copyright/licensing info to source tarball r=pietroalbini a=tshepang

Upstream recently added an automated way of generating copyright files (rust-lang/rust#135588), so we also need to do similar, because we have a different way of generating release tarballs.

Co-authored-by: Tshepang Mbambo <tshepang.mbambo@ferrous-systems.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants