Rollup of 9 pull requests #135921

matthiaskrgr · 2025-01-23T08:49:38Z

Successful merges:

Don't ICE in coerce when autoderef fails to structurally normalize non-WF type in new solver #134746 (Don't ICE in coerce when autoderef fails to structurally normalize non-WF type in new solver)
[AIX] Lint on structs that have a different alignment in AIX's C ABI #135552 ([AIX] Lint on structs that have a different alignment in AIX's C ABI)
CI: free disk on linux arm runner #135779 (CI: free disk on linux arm runner)
Update windows-gnu targets to set DebuginfoKind::DWARF #135790 (Update windows-gnu targets to set DebuginfoKind::DWARF)
fix outdated file path ref in llvm #135879 (fix outdated file path ref in llvm)
Remove erroneous unsafe in BTreeSet::upper_bound_mut #135883 (Remove erroneous unsafe in BTreeSet::upper_bound_mut)
remove implied end of slice #135884 (remove implied end of slice)
improvements on build_steps::test implementation #135887 (improvements on build_steps::test implementation)
rustdoc-json-types: Finalize dyn compatibility renaming #135898 (rustdoc-json-types: Finalize dyn compatibility renaming)

r? @ghost
@rustbot modify labels: rollup

These targets have always generated DWARF debuginfo and not CodeView/PDB debuginfo like the MSVC Windows targets. Correct their target definitions to reflect this. The newly added tests for the various combinations of `*-windows-gnu*` targets and `-Csplit-debuginfo` show that this does not change any stable behavior.

This was added years ago and is outdated today. Signed-off-by: onur-ozkan <work@onurozkan.dev>

Signed-off-by: onur-ozkan <work@onurozkan.dev>

…n-WF type in new solver

…-wf-coerce-ice, r=lcnr Don't ICE in coerce when autoderef fails to structurally normalize non-WF type in new solver r? lcnr

…gnostic-power-alignment, r=workingjubilee [AIX] Lint on structs that have a different alignment in AIX's C ABI This PR adds a linting diagnostic on AIX for repr(C) structs that are required to follow the power alignment rule. A repr(C) struct needs to follow the power alignment rule if the struct: - Has a floating-point data type (greater than 4-bytes) as its first member, or - The first member of the struct is an aggregate, whose recursively first member is a floating-point data type (greater than 4-bytes). The power alignment rule for eligible structs is currently unimplemented, so a linting diagnostic is produced when such a struct is encountered.

…Kobzol CI: free disk on linux arm runner try-job: aarch64-gnu

…uginfokind, r=lqd Update windows-gnu targets to set `DebuginfoKind::DWARF` These targets have always used DWARF debuginfo and not CodeView/PDB debuginfo like the MSVC Windows targets. However, their target definitions claim to use `DebuginfoKind::PDB` probably to ensure that we do not try to allow the use of split-DWARF debuginfo. This does not appear to be necessary since the targets set their supported split debug info to `Off`. I've looked at all of the uses of these properties and this patch does not appear to cause any functional changes in compiler behavior. I also added UI tests to attempt to validate there is no change in the behavior of these options on stable compilers. cc ````@mati865```` since you mentioned this in rust-lang#135739 cc ````@davidtwco```` for split-dwarf

…eyouxu fix outdated file path ref in llvm This was added years ago and is outdated today.

…_mut, r=tgross35 Remove erroneous `unsafe` in `BTreeSet::upper_bound_mut` rust-lang#128309 (comment) Tracking issue: rust-lang#107540

remove implied end of slice

…=jieyouxu improvements on `build_steps::test` implementation Reviewing commits one-by-one should make it easier to understand.

rustdoc-json-types: Finalize dyn compatibility renaming Followup to rust-lang#131595. Part of rust-lang#130852. Inspired by rust-lang#135858 (does the same thing but for the rustdoc-types docs). r? ````@fmease````

rustbot · 2025-01-23T08:49:42Z

Could not assign reviewer from: ghost.
User(s) ghost are either the PR author, already assigned, or on vacation. Please use r? to specify someone else to assign.

rustbot · 2025-01-23T08:49:49Z

r? @chenyukang

rustbot has assigned @chenyukang.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

matthiaskrgr · 2025-01-23T09:31:15Z

@bors r+ rollup=never p=9

bors · 2025-01-23T09:31:18Z

📌 Commit 4b3d7ef has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2025-01-23T12:39:04Z

⌛ Testing commit 4b3d7ef with merge 99768c8...

bors · 2025-01-23T17:37:25Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 99768c8 to master...

rust-timer · 2025-01-24T03:16:22Z

Finished benchmarking commit (99768c8): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.3%	[0.3%, 0.3%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary 1.6%, secondary 1.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.6%	[0.9%, 2.3%]	2
Regressions ❌ (secondary)	2.2%	[1.1%, 4.9%]	5
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.6%	[-3.6%, -3.6%]	1
All ❌✅ (primary)	1.6%	[0.9%, 2.3%]	2

Cycles

Results (primary 1.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.0%	[1.0%, 1.0%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.0%	[1.0%, 1.0%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 778.767s -> 776.719s (-0.26%)
Artifact size: 325.93 MiB -> 325.95 MiB (0.01%)

marcoieni and others added 21 commits January 20, 2025 17:38

CI: free disk on linux arm runner

a175e8d

Add tests for windows-gnu split-debuginfo options

fdb636e

fix outdated file path ref in llvm

f0dfda1

This was added years ago and is outdated today. Signed-off-by: onur-ozkan <work@onurozkan.dev>

Remove erroneous unsafe in BTreeSet::upper_bound_mut

bae2a2f

remove implied end of slice

53578bd

make bootstrap self test to use bootstrap cargo

c568da9

Signed-off-by: onur-ozkan <work@onurozkan.dev>

resolve clippy FIXME

17b2ede

Signed-off-by: onur-ozkan <work@onurozkan.dev>

reduce number of prepare_cargo_test args

e3a5314

Signed-off-by: onur-ozkan <work@onurozkan.dev>

[AIX] Lint on structs that have a different alignment in AIX's C ABI

cd2ecc4

Don't ICE in coerce when autoderef fails to structurally normalize no…

72fa874

…n-WF type in new solver

rustdoc-json-types: Finalize dyn compatibility renaming

0149c0f

Rollup merge of rust-lang#134746 - compiler-errors:autoderef-norm-non…

73dc08d

…-wf-coerce-ice, r=lcnr Don't ICE in coerce when autoderef fails to structurally normalize non-WF type in new solver r? lcnr

Rollup merge of rust-lang#135779 - marcoieni:free-disk-arm-runner, r=…

a6157d3

…Kobzol CI: free disk on linux arm runner try-job: aarch64-gnu

Rollup merge of rust-lang#135879 - onur-ozkan:invalid-file-path, r=ji…

e1ee038

…eyouxu fix outdated file path ref in llvm This was added years ago and is outdated today.

Rollup merge of rust-lang#135883 - GrigorenkoPV:btree_set_upper_bound…

d1cfd39

…_mut, r=tgross35 Remove erroneous `unsafe` in `BTreeSet::upper_bound_mut` rust-lang#128309 (comment) Tracking issue: rust-lang#107540

Rollup merge of rust-lang#135884 - hkBst:patch-13, r=compiler-errors

447824d

remove implied end of slice

Rollup merge of rust-lang#135887 - onur-ozkan:testing-improvements, r…

76e68cc

…=jieyouxu improvements on `build_steps::test` implementation Reviewing commits one-by-one should make it easier to understand.

Rollup merge of rust-lang#135898 - aDotInTheVoid:dyndoc, r=fmease

4b3d7ef

rustdoc-json-types: Finalize dyn compatibility renaming Followup to rust-lang#131595. Part of rust-lang#130852. Inspired by rust-lang#135858 (does the same thing but for the rustdoc-types docs). r? ````@fmease````

rustbot assigned chenyukang Jan 23, 2025

rustbot added T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Jan 23, 2025

matthiaskrgr unassigned chenyukang Jan 23, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 23, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 23, 2025

bors merged commit 99768c8 into rust-lang:master Jan 23, 2025
7 checks passed

rustbot added this to the 1.86.0 milestone Jan 23, 2025

bors mentioned this pull request Jan 23, 2025

lint ImproperCTypes: overhaul (take 2 of "better handling of indirections") #134697

Open

matthiaskrgr deleted the rollup-5mzn76m branch January 25, 2025 09:13

jieyouxu added the rollup A PR which is a rollup label Mar 11, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 9 pull requests #135921

Rollup of 9 pull requests #135921

Uh oh!

matthiaskrgr commented Jan 23, 2025

Uh oh!

rustbot commented Jan 23, 2025

Uh oh!

rustbot commented Jan 23, 2025

Uh oh!

matthiaskrgr commented Jan 23, 2025

Uh oh!

bors commented Jan 23, 2025

Uh oh!

bors commented Jan 23, 2025

Uh oh!

bors commented Jan 23, 2025

Uh oh!

Uh oh!

rust-timer commented Jan 24, 2025

Uh oh!

Uh oh!

Rollup of 9 pull requests #135921

Rollup of 9 pull requests #135921

Uh oh!

Conversation

matthiaskrgr commented Jan 23, 2025

Uh oh!

rustbot commented Jan 23, 2025

Uh oh!

rustbot commented Jan 23, 2025

Uh oh!

matthiaskrgr commented Jan 23, 2025

Uh oh!

bors commented Jan 23, 2025

Uh oh!

bors commented Jan 23, 2025

Uh oh!

bors commented Jan 23, 2025

Uh oh!

Uh oh!

rust-timer commented Jan 24, 2025

Overall result: ❌ regressions - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Uh oh!