ci: Remove the power to skip tests from opt-dist #135960
Open
+3
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
workingjubilee
force-pushed
the
remove-opt-dists-test-skipping-code
branch
from
7f6bb7d to
14e50f4
Compare
|
@bors try |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 24, 2025
…-skipping-code, r=<try> ci: Remove the power to skip tests from opt-dist This will probably take a bit of testing against the dist pipelines to make it pass. r? `@ghost` try-job: dist-aarch64-linux try-job: dist-x86_64-msvc
|
☀️ Try build successful - checks-actions |
|
??? huh??? |
|
uh, cc @mrkajetanp |
|
Could not assign reviewer from: |
|
Some changes occurred in src/tools/opt-dist cc @Kobzol |
|
r? infra |
rustbot
added
the
T-infra
Hm I don't think the try builds run the test suite? I think they just build and there's a separate bors thing for running tests which happens on rollups. Regardless I think this is a good idea tbh, if a test really needs to be skipped on a platform it might as well be skipped in the test file directly. That'll avoid the discrepancy between normal tests and opt-dist tests. |
|
There’s an env var in jobs.yml rust/src/ci/github-actions/jobs.yml Line 88 in 1c9837d |
|
Yes, you need to comment out that env var in order for opt-dist tests to run |
|
Oh cool. |
rustbot
added
the
A-testsuite
|
@bors try |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 24, 2025
…-skipping-code, r=<try> ci: Remove the power to skip tests from opt-dist This will probably take a bit of testing against the dist pipelines to make it pass. r? `@ghost` try-job: dist-aarch64-linux try-job: dist-x86_64-msvc
|
Are you trying to fix all the failing tests on dist runners? :D Note that opt-dist doesn't run the full test suite, e.g. it skips all run-make tests. |
No, just the specific ones skipped by opt-dist because they're failing |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-author
|
The job Click to see the possible cause of the failure (guessed by this bot) |
mrkajetanp
added a commit
to mrkajetanp/rust
that referenced
this pull request
Jan 24, 2025
Skip const OOM tests on AArch64 Linux through explicit annotations instead of inside opt-dist. Intended to avoid confusion in cases like rust-lang#135952. Prerequisite for rust-lang#135960.
|
mrkajetanp
added a commit
to mrkajetanp/rust
that referenced
this pull request
Jan 24, 2025
Skip const OOM tests on AArch64 Linux through explicit annotations instead of inside opt-dist. Intended to avoid confusion in cases like rust-lang#135952. Prerequisite for rust-lang#135960.
@mrkajetanp I think the Docker doesn't include, er, basic libraries? |
It's pretty much the same Docker file as dist-x86_64-linux, only adapted for aarch64. |
mrkajetanp
added a commit
to mrkajetanp/rust
that referenced
this pull request
Jan 24, 2025
Skip const OOM tests on AArch64 Linux through explicit annotations instead of inside opt-dist. Intended to avoid confusion in cases like rust-lang#135952. Prerequisite for rust-lang#135960.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 24, 2025
…alloc-tests, r=<try> tests: Skip const OOM tests on aarch64-unknown-linux-gnu Skip const OOM tests on AArch64 Linux through explicit annotations instead of inside opt-dist. Intended to avoid confusion in cases like rust-lang#135952. Prerequisite for rust-lang#135960. r? `@Kobzol` cc `@workingjubilee` try-job: dist-aarch64-linux
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 28, 2025
…t-alloc-tests, r=Kobzol tests: Skip const OOM tests on aarch64-unknown-linux-gnu Skip const OOM tests on AArch64 Linux through explicit annotations instead of inside opt-dist. Intended to avoid confusion in cases like rust-lang#135952. Prerequisite for rust-lang#135960. r? `@Kobzol` cc `@workingjubilee` try-job: dist-aarch64-linux
|
☔ The latest upstream changes (presumably #136185) made this pull request unmergeable. Please resolve the merge conflicts. |
mrkajetanp
added a commit
to mrkajetanp/rust
that referenced
this pull request
Jan 29, 2025
Skip const OOM tests on AArch64 Linux through explicit annotations instead of inside opt-dist. Intended to avoid confusion in cases like rust-lang#135952. Prerequisite for rust-lang#135960.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 30, 2025
…t-alloc-tests, r=Kobzol tests: Skip const OOM tests on aarch64-unknown-linux-gnu Skip const OOM tests on AArch64 Linux through explicit annotations instead of inside opt-dist. Intended to avoid confusion in cases like rust-lang#135952. Prerequisite for rust-lang#135960. r? `@Kobzol` cc `@workingjubilee` try-job: dist-aarch64-linux
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 31, 2025
Rollup merge of rust-lang#136004 - mrkajetanp:aarch64-skip-large-const-alloc-tests, r=Kobzol tests: Skip const OOM tests on aarch64-unknown-linux-gnu Skip const OOM tests on AArch64 Linux through explicit annotations instead of inside opt-dist. Intended to avoid confusion in cases like rust-lang#135952. Prerequisite for rust-lang#135960. r? `@Kobzol` cc `@workingjubilee` try-job: dist-aarch64-linux
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Jan 31, 2025
…ests, r=Kobzol tests: Skip const OOM tests on aarch64-unknown-linux-gnu Skip const OOM tests on AArch64 Linux through explicit annotations instead of inside opt-dist. Intended to avoid confusion in cases like #135952. Prerequisite for rust-lang/rust#135960. r? `@Kobzol` cc `@workingjubilee` try-job: dist-aarch64-linux
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will probably take a bit of testing against the dist pipelines to make it pass.
r? @ghost
try-job: dist-aarch64-linux
try-job: dist-x86_64-linux
try-job: dist-x86_64-msvc