Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Doc difference between extend and extend_from_slice #135983

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

hkBst
Copy link
Member

@hkBst hkBst commented Jan 24, 2025

fixes #97119

@rustbot
Copy link
Collaborator

rustbot commented Jan 24, 2025

r? @jhpratt

rustbot has assigned @jhpratt.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 24, 2025
@jhpratt
Copy link
Member

jhpratt commented Jan 24, 2025

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 24, 2025

📌 Commit 3c3961b has been approved by jhpratt

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 24, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 24, 2025
Doc difference between extend and extend_from_slice

fixes rust-lang#97119
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 24, 2025
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#135295 (Check empty SIMD vector in inline asm)
 - rust-lang#135873 (coverage: Prepare for upcoming changes to counter creation)
 - rust-lang#135926 (Implement `needs-subprocess` directive, and cleanup a bunch of tests to use `needs-{subprocess,threads}`)
 - rust-lang#135950 (Tidy Python improvements)
 - rust-lang#135956 (Make `Vec::pop_if` a bit more presentable)
 - rust-lang#135966 ([AIX] Allow different sized load and store in `tests/assembly/powerpc64-struct-abi.rs`)
 - rust-lang#135983 (Doc difference between extend and extend_from_slice)

r? `@ghost`
`@rustbot` modify labels: rollup
joboet added a commit to joboet/rust that referenced this pull request Jan 24, 2025
Doc difference between extend and extend_from_slice

fixes rust-lang#97119
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 24, 2025
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#135873 (coverage: Prepare for upcoming changes to counter creation)
 - rust-lang#135926 (Implement `needs-subprocess` directive, and cleanup a bunch of tests to use `needs-{subprocess,threads}`)
 - rust-lang#135950 (Tidy Python improvements)
 - rust-lang#135956 (Make `Vec::pop_if` a bit more presentable)
 - rust-lang#135966 ([AIX] Allow different sized load and store in `tests/assembly/powerpc64-struct-abi.rs`)
 - rust-lang#135983 (Doc difference between extend and extend_from_slice)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ed77bf7 into rust-lang:master Jan 24, 2025
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 24, 2025
Rollup merge of rust-lang#135983 - hkBst:patch-13, r=jhpratt

Doc difference between extend and extend_from_slice

fixes rust-lang#97119
@rustbot rustbot added this to the 1.86.0 milestone Jan 24, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 24, 2025
Rollup of 6 pull requests

Successful merges:

 - rust-lang#135728 (document order of items in iterator from drain)
 - rust-lang#135829 (Rustc dev guide subtree update)
 - rust-lang#135886 (Document purpose of closure in from_fn.rs more clearly)
 - rust-lang#135977 (Fix `FormattingOptions` instantiation with `Default`)
 - rust-lang#135983 (Doc difference between extend and extend_from_slice)
 - rust-lang#135985 (Rename test to `unresolvable-upvar-issue-87987.rs` and add some notes)

r? `@ghost`
`@rustbot` modify labels: rollup
@hkBst hkBst deleted the patch-13 branch February 2, 2025 12:56
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vec::extend_from_slice’s documentation forgot about the difference of T: Clone vs. T: Copy bounds.
4 participants