Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Miri subtree update #136110

Merged
merged 23 commits into from
Jan 27, 2025
Merged

Miri subtree update #136110

merged 23 commits into from
Jan 27, 2025

Conversation

RalfJung
Copy link
Member

r? @ghost

The Miri Cronjob Bot and others added 23 commits January 23, 2025 04:55
many-seeds: do not use more than 8 threads
This avoids a good deal of work, since each module child can now just be
compared via u32 comparison, rather than fetching the raw &str
(requiring locking and indexing into the interner) and then comparing
the two strings (also relatively expensive).
…lookups

Pre-intern name when searching module children
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 26, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jan 26, 2025

The Miri subtree was changed

cc @rust-lang/miri

@RalfJung
Copy link
Member Author

@bors r+ p=1

@bors
Copy link
Contributor

bors commented Jan 26, 2025

📌 Commit 05a2dcd has been approved by RalfJung

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 26, 2025
Zalathar added a commit to Zalathar/rust that referenced this pull request Jan 27, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 27, 2025
Rollup of 6 pull requests

Successful merges:

 - rust-lang#135876 (fix doc for std::sync::mpmc)
 - rust-lang#135961 (Fix 2/4 tests skipped by opt-dist)
 - rust-lang#136037 (Mark all NuttX targets as tier 3 target and support the standard library)
 - rust-lang#136098 (Downgrade `linker-warnings` to allow-by-default)
 - rust-lang#136110 (Miri subtree update)
 - rust-lang#136117 (Subtree update of `rust-analyzer`)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 27, 2025
Rollup of 6 pull requests

Successful merges:

 - rust-lang#135876 (fix doc for std::sync::mpmc)
 - rust-lang#135961 (Fix 2/4 tests skipped by opt-dist)
 - rust-lang#136037 (Mark all NuttX targets as tier 3 target and support the standard library)
 - rust-lang#136098 (Downgrade `linker-warnings` to allow-by-default)
 - rust-lang#136110 (Miri subtree update)
 - rust-lang#136117 (Subtree update of `rust-analyzer`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors
Copy link
Contributor

bors commented Jan 27, 2025

⌛ Testing commit 05a2dcd with merge 2f348cb...

@bors
Copy link
Contributor

bors commented Jan 27, 2025

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing 2f348cb to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 27, 2025
@bors bors merged commit 2f348cb into rust-lang:master Jan 27, 2025
7 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Jan 27, 2025
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (2f348cb): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 0.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.8% [0.8%, 0.8%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.8% [0.8%, 0.8%] 1

Cycles

Results (secondary 1.6%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
3.3% [3.3%, 3.3%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-1.6% [-1.6%, -1.6%] 1
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 774.391s -> 772.501s (-0.24%)
Artifact size: 328.16 MiB -> 328.24 MiB (0.03%)

@RalfJung RalfJung deleted the miri-sync branch January 29, 2025 10:13
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants