Skip to content

ci: use windows 2025 for i686-mingw #136150

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2025
Merged

ci: use windows 2025 for i686-mingw #136150

merged 1 commit into from
Jan 31, 2025

Conversation

marcoieni
Copy link
Member

Lately, the flakiness of the job i686-mingw increased.
In #135632 windows 2025 helped decrease the flakiness so we want to try to do the same here.

try-job: i686-mingw

@rustbot
Copy link
Collaborator

rustbot commented Jan 27, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@marcoieni
Copy link
Member Author

@bors try

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jan 27, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 27, 2025
@bors
Auto merge of rust-lang#136150 - marcoieni:windows-25-i686-mingw, r=<…
c181a94 
…try>

ci: use windows 2025 for i686-mingw

try-job: i686-mingw
@bors
Copy link
Collaborator

bors commented Jan 27, 2025

⌛ Trying commit 6394069 with merge c181a94...

@bors
Copy link
Collaborator

bors commented Jan 28, 2025

💥 Test timed out

@marcoieni
Copy link
Member Author

@bors try

@bors
Copy link
Collaborator

bors commented Jan 28, 2025

⌛ Trying commit 6394069 with merge 151b82c...

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 28, 2025
@bors
Auto merge of rust-lang#136150 - marcoieni:windows-25-i686-mingw, r=<…
151b82c 
…try>

ci: use windows 2025 for i686-mingw

try-job: i686-mingw
@bors
Copy link
Collaborator

bors commented Jan 28, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 28, 2025
@marcoieni
Copy link
Member Author

I only created the windows large runner on the rust-lang org. I will now create it for rust-lang-ci org as well

@marcoieni
Copy link
Member Author

@bors try

@bors
Copy link
Collaborator

bors commented Jan 28, 2025

⌛ Trying commit 6394069 with merge 4e4a567...

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 28, 2025
@bors
Auto merge of rust-lang#136150 - marcoieni:windows-25-i686-mingw, r=<…
4e4a567 
…try>

ci: use windows 2025 for i686-mingw

try-job: i686-mingw
@bors
Copy link
Collaborator

bors commented Jan 28, 2025

☀️ Try build successful - checks-actions
Build commit: 4e4a567 (4e4a567b10bf243a5c59bb2bdb048e99c904b0c6)

@marcoieni
Copy link
Member Author

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 28, 2025
@bors
Auto merge of rust-lang#136150 - marcoieni:windows-25-i686-mingw, r=<…
5444a47 
…try>

ci: use windows 2025 for i686-mingw

try-job: i686-mingw
@bors
Copy link
Collaborator

bors commented Jan 28, 2025

⌛ Trying commit 6394069 with merge 5444a47...

@bors
Copy link
Collaborator

bors commented Jan 28, 2025

☀️ Try build successful - checks-actions
Build commit: 5444a47 (5444a472b526ffb01791d1954df34763a47307a0)

@marcoieni
Copy link
Member Author

@bors try

@bors
Copy link
Collaborator

bors commented Jan 28, 2025

⌛ Trying commit 6394069 with merge 3ec2aba...

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 28, 2025
@bors
Auto merge of rust-lang#136150 - marcoieni:windows-25-i686-mingw, r=<…
3ec2aba 
…try>

ci: use windows 2025 for i686-mingw

try-job: i686-mingw
@bors
Copy link
Collaborator

bors commented Jan 28, 2025

☀️ Try build successful - checks-actions
Build commit: 3ec2aba (3ec2aba21880917a6b0707126637be0b9eba6a98)

@marcoieni
Copy link
Member Author

@bors try

@bors
Copy link
Collaborator

bors commented Jan 28, 2025

⌛ Trying commit 6394069 with merge c0c74c9...

@bors
Copy link
Collaborator

bors commented Jan 29, 2025

☀️ Try build successful - checks-actions
Build commit: 53b9f18 (53b9f1881cee95cc24f99f8081b627652d2ecedd)

@marcoieni marcoieni marked this pull request as ready for review January 29, 2025 10:13
@Kobzol
Copy link
Contributor

Kobzol commented Jan 29, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jan 29, 2025

📌 Commit 6394069 has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 29, 2025
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jan 29, 2025
@GuillaumeGomez
Rollup merge of rust-lang#136150 - marcoieni:windows-25-i686-mingw, r…
7565e5e 
…=Kobzol

ci: use windows 2025 for i686-mingw

try-job: i686-mingw
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jan 29, 2025
Closed
@bors
Copy link
Collaborator

bors commented Jan 29, 2025

☔ The latest upstream changes (presumably #136248) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 29, 2025
@rustbot rustbot added the has-merge-commits PR has merge commits, merge with caution. label Jan 29, 2025
@rustbot

This comment has been minimized.

# to view
@marcoieni marcoieni force-pushed the windows-25-i686-mingw branch from 0756de1 to aeabd4b Compare January 29, 2025 20:27
@rustbot rustbot removed the has-merge-commits PR has merge commits, merge with caution. label Jan 29, 2025
@marcoieni
Copy link
Member Author

I solved the merge conflicts, probably this needs to be approved again

@Kobzol
Copy link
Contributor

Kobzol commented Jan 29, 2025

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 29, 2025

📌 Commit aeabd4b has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 29, 2025
@jhpratt jhpratt mentioned this pull request Jan 31, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 31, 2025
@bors
Auto merge of rust-lang#136331 - jhpratt:rollup-curo1f4, r=jhpratt
25a1657 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#135414 (Stabilize `const_black_box`)
 - rust-lang#136150 (ci: use windows 2025 for i686-mingw)
 - rust-lang#136258 (rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 11))
 - rust-lang#136270 (Remove `NamedVarMap`.)
 - rust-lang#136278 (add constraint graph to polonius MIR dump)
 - rust-lang#136287 (LLVM changed the nocapture attribute to captures(none))
 - rust-lang#136291 (some test suite cleanups)
 - rust-lang#136296 (float::min/max: mention the non-determinism around signed 0)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 7f05c7e into rust-lang:master Jan 31, 2025
6 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Jan 31, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 31, 2025
@rust-timer
Unrolled build for rust-lang#136150
f3a3d6f 
Rollup merge of rust-lang#136150 - marcoieni:windows-25-i686-mingw, r=Kobzol

ci: use windows 2025 for i686-mingw

try-job: i686-mingw
@marcoieni marcoieni mentioned this pull request Jan 31, 2025
Merged
7 tasks
@workingjubilee workingjubilee added O-windows-gnu Toolchain: GNU, Operating system: Windows O-x86_32 Target: x86 processors, 32 bit (like i686-*) (IA-32) labels Feb 10, 2025
GuillaumeGomez pushed a commit to GuillaumeGomez/rust that referenced this pull request Apr 18, 2025
@bors
Auto merge of rust-lang#136331 - jhpratt:rollup-curo1f4, r=jhpratt
afe0843 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#135414 (Stabilize `const_black_box`)
 - rust-lang#136150 (ci: use windows 2025 for i686-mingw)
 - rust-lang#136258 (rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 11))
 - rust-lang#136270 (Remove `NamedVarMap`.)
 - rust-lang#136278 (add constraint graph to polonius MIR dump)
 - rust-lang#136287 (LLVM changed the nocapture attribute to captures(none))
 - rust-lang#136291 (some test suite cleanups)
 - rust-lang#136296 (float::min/max: mention the non-determinism around signed 0)

r? `@ghost`
`@rustbot` modify labels: rollup
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc O-windows-gnu Toolchain: GNU, Operating system: Windows O-x86_32 Target: x86 processors, 32 bit (like i686-*) (IA-32) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.86.0
Development

Successfully merging this pull request may close these issues.
6 participants
@marcoieni @rustbot @bors @Kobzol @Mark-Simulacrum @workingjubilee