clippy: resolve projections during internal mutability analysis #136369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rustbot has assigned @Mark-Simulacrum. Use |
rustbot
added
the
S-waiting-on-review
|
Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
|
We'd love for Clippy-exclusive PRs to be open directly on the repo. Could you open this PR there instesd? |
Sure thing. Closing in favor of rust-lang/rust-clippy#14125 |
github-merge-queue bot
pushed a commit
to rust-lang/rust-clippy
that referenced
this pull request
Feb 11, 2025
…solve `<T as Trait>::AssocT` projections (#14125) changelog: [`declare_interior_mutable_const`, `borrow_interior_mutable_const`]: resolve `<T as Trait>::AssocT` projections --- This came up during rust-lang/rust#130543 where we have `<T as AtomicPrimitive>::Assoc = AtomicT` instead of just `AtomicT` and clippy failed to resolve that properly. This really needs a review, because - I don't know if `try_normalize_erasing_regions` is the right thing to call here. - I'm not sure if I peel off the correct amount of `ValTree::Branch` layers (I think I do). Also, shouldn't this lint's infrastructure rely on `Freeze` trait (rust-lang/rust#121675) instead of hardcoding a list of known-to-be-interior-mutable types? --- Previously filed this in the main rust repo (rust-lang/rust#136369), was asked to do it here instead (rust-lang/rust#136369 (comment)).
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came up during #130543 where we have
<T as AtomicPrimitive>::Assoc = AtomicTinstead of justAtomicTand clippy failed to resolve that properly.This really needs a review, because
try_normalize_erasing_regionsis the right thing to call here.ValTree::Branchlayers (I think I do).Also,
Freezetrait (Tracking Issue for theFreezetrait #121675) instead of hardcoding a list of known-to-be-interior-mutable types?