Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Document minimum supported host tooling on macOS #136558

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

madsmtm
Copy link
Contributor

@madsmtm madsmtm commented Feb 4, 2025

In particular we support macOS 10.12 (same as for binaries produced by rustc) and Xcode 9.2 (the highest Xcode version that runs on macOS 10.12.6). I have this installed on a MacBook Pro from 2013 that sits below my desk, and am occasionally testing it.

I am documenting this now because it was unclear in #136523.

(I'm not inherently against bumping these one day, but that's a separate discussion, let's at least document what we support right now).

@rustbot label O-macos

@rustbot
Copy link
Collaborator

rustbot commented Feb 4, 2025

r? @ehuss

rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 4, 2025
@rustbot
Copy link
Collaborator

rustbot commented Feb 4, 2025

Some changes occurred in src/doc/rustc/src/platform-support

cc @Noratrieb

@workingjubilee
Copy link
Member

workingjubilee commented Feb 4, 2025

and Xcode 9.2 (the highest Xcode version that runs on macOS 10.12.6)

The highest or lowest?

@madsmtm
Copy link
Contributor Author

madsmtm commented Feb 4, 2025

and Xcode 9.2 (the highest Xcode version that runs on macOS 10.12.6)

The highest or lowest?

Highest; Xcode 8.3 works on macOS 10.12 too - We could also choose to support that one, if you'd rather have that?

@workingjubilee
Copy link
Member

nah, just doublechecking.

Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is at least documenting the status quo, which is already a significant improvement in itself.

@jieyouxu
Copy link
Member

jieyouxu commented Feb 5, 2025

r? jieyouxu @bors r+ rollup

@bors
Copy link
Contributor

bors commented Feb 5, 2025

📌 Commit 6bfa057 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 5, 2025
@jieyouxu jieyouxu added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 5, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 6, 2025
…kingjubilee

Rollup of 13 pull requests

Successful merges:

 - rust-lang#133932 (Avoid using make_direct_deprecated() in extern "ptx-kernel")
 - rust-lang#136269 (Pass spans around new solver)
 - rust-lang#136550 (Fix `rustc_hidden_type_of_opaques` for RPITITs with no default body)
 - rust-lang#136558 (Document minimum supported host tooling on macOS)
 - rust-lang#136563 (Clean up `Trivial*Impls` macros)
 - rust-lang#136566 (Fix link in from_fn.rs)
 - rust-lang#136573 (Document why some "type mismatches" exist)
 - rust-lang#136583 (Only highlight unmatchable parameters at the definition site)
 - rust-lang#136587 (Update browser-ui-test version to `0.20.2`)
 - rust-lang#136590 (Implement RustcInternal for RawPtrKind)
 - rust-lang#136591 (Add `rustc_hir_pretty::expr_to_string` function)
 - rust-lang#136595 (Fix `unreachable_pub` lint for hermit target)
 - rust-lang#136611 (cg_llvm: Remove the `mod llvm_` hack, which should no longer be necessary)

Failed merges:

 - rust-lang#136565 (compiler: Clean up weird `rustc_abi` reexports)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 45398fc into rust-lang:master Feb 6, 2025
6 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Feb 6, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 6, 2025
Rollup merge of rust-lang#136558 - madsmtm:apple-host-tooling, r=jieyouxu

Document minimum supported host tooling on macOS

In particular we support macOS 10.12 (same as for binaries produced by `rustc`) and Xcode 9.2 (the highest Xcode version that runs on macOS 10.12.6). I have this installed on a MacBook Pro from 2013 that sits below my desk, and am occasionally testing it.

I am documenting this now because it was unclear in rust-lang#136523.

(I'm not inherently against bumping these one day, but that's a separate discussion, let's at least document what we support right now).

`@rustbot` label O-macos
@madsmtm madsmtm deleted the apple-host-tooling branch February 6, 2025 10:17
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
O-macos Operating system: macOS S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants