-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Revert "CI: build FreeBSD artifacts on FreeBSD 13.4" #136582
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit cf34545. That commit led to a regression of rust-lang#132185 . So my analysis that the problem lay in FreeBSD 13.2's specific LLVM version was clearly wrong. Revert that commit until we can figure out the real root cause. Fixes rust-lang#132185
This comment was marked as off-topic.
This comment was marked as off-topic.
r? @tgross35 |
@bors try |
Fyi @rust-lang/infra |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 5, 2025
Revert "CI: build FreeBSD artifacts on FreeBSD 13.4" This reverts commit cf34545. That commit led to a regression of rust-lang#132185 . So my analysis that the problem lay in FreeBSD 13.2's specific LLVM version was clearly wrong. Revert that commit until we can figure out the real root cause. Fixes rust-lang#132185 try-job: dist-x86_64-freebsd try-job: dist-various-2
This comment has been minimized.
This comment has been minimized.
💔 Test failed - checks-actions |
|
@bors try |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 5, 2025
Revert "CI: build FreeBSD artifacts on FreeBSD 13.4" This reverts commit cf34545. That commit led to a regression of rust-lang#132185 . So my analysis that the problem lay in FreeBSD 13.2's specific LLVM version was clearly wrong. Revert that commit until we can figure out the real root cause. Fixes rust-lang#132185 try-job: dist-x86_64-freebsd try-job: dist-various-2
☀️ Try build successful - checks-actions |
tgross35
approved these changes
Feb 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm but infra should probably take a look
r? infra
Jakub took a look via Zulip r? tgross35 |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 6, 2025
Revert "CI: build FreeBSD artifacts on FreeBSD 13.4" This reverts commit cf34545. That commit led to a regression of rust-lang#132185 . So my analysis that the problem lay in FreeBSD 13.2's specific LLVM version was clearly wrong. Revert that commit until we can figure out the real root cause. Fixes rust-lang#132185 try-job: dist-x86_64-freebsd try-job: dist-various-2
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 7, 2025
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#135973 (fix tail call checks wrt `#[track_caller]`) - rust-lang#136191 (compiler: replace few consts arrays with statics to remove const dupes) - rust-lang#136565 (compiler: Clean up weird `rustc_abi` reexports) - rust-lang#136582 (Revert "CI: build FreeBSD artifacts on FreeBSD 13.4") - rust-lang#136592 (Make sure we don't overrun the stack in canonicalizer) - rust-lang#136627 (MIR validation: add comment explaining the limitations of CfgChecker) - rust-lang#136634 (Stabilise `Cursor::{get_mut, set_position}` in `const` scenarios.) - rust-lang#136643 (ping me for attribute-related changes) - rust-lang#136644 (Add `rustc_hir_pretty::item_to_string` function) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 7, 2025
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#135973 (fix tail call checks wrt `#[track_caller]`) - rust-lang#136191 (compiler: replace few consts arrays with statics to remove const dupes) - rust-lang#136565 (compiler: Clean up weird `rustc_abi` reexports) - rust-lang#136582 (Revert "CI: build FreeBSD artifacts on FreeBSD 13.4") - rust-lang#136627 (MIR validation: add comment explaining the limitations of CfgChecker) - rust-lang#136634 (Stabilise `Cursor::{get_mut, set_position}` in `const` scenarios.) - rust-lang#136643 (ping me for attribute-related changes) - rust-lang#136644 (Add `rustc_hir_pretty::item_to_string` function) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 7, 2025
Rollup merge of rust-lang#136582 - asomers:revert-132232, r=tgross35 Revert "CI: build FreeBSD artifacts on FreeBSD 13.4" This reverts commit cf34545. That commit led to a regression of rust-lang#132185 . So my analysis that the problem lay in FreeBSD 13.2's specific LLVM version was clearly wrong. Revert that commit until we can figure out the real root cause. Fixes rust-lang#132185 try-job: dist-x86_64-freebsd try-job: dist-various-2
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
A-testsuite
Area: The testsuite used to check the correctness of rustc
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-infra
Relevant to the infrastructure team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit cf34545.
That commit led to a regression of
#132185 . So my analysis that the problem lay in FreeBSD 13.2's specific LLVM version was clearly wrong. Revert that commit until we can figure out the real root cause.
Fixes #132185
try-job: dist-x86_64-freebsd
try-job: dist-various-2