Provide optional `Read`/`Write` methods for stdio #136769

thaliaarchi · 2025-02-09T10:44:13Z

Override more of the default methods for io::Read and io::Write for stdio types, when efficient to do so, and deduplicate unsupported types.

Tracked in #136756.

try-job: x86_64-msvc-1

rustbot · 2025-02-09T10:44:22Z

r? @Noratrieb

rustbot has assigned @Noratrieb.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

library/std/src/io/stdio.rs

thaliaarchi · 2025-02-11T01:21:48Z

@joboet Looks like you wrote #136780 to have minimum conflicts to this. Thanks for that. I don't mind rebasing onto that, if yours is merged first.

Noratrieb · 2025-02-12T18:59:17Z

r? joboet

library/std/src/sys/pal/uefi/fs.rs

thaliaarchi · 2025-02-16T22:07:31Z

I dropped a few commits from this PR:

5da7fbe (Fix unsafe_op_in_unsafe_fn for TEEOS), because Apply unsafe_op_in_unsafe_fn to the standard library #136986 is in the merge queue
1a08321 (Deduplicate unsupported fs.rs for UEFI) per Nora's note
1b05019 (Remove unused methods on Hermit FileDesc), because that would be a better fit for a file-focused PR.

thaliaarchi · 2025-02-19T04:38:30Z

Since this touches a lot of targets, I'm going to split this into multiple PRs for more target-focused review, once #136780 goes through the merge queue.

joboet · 2025-02-19T12:06:36Z

Since this touches a lot of targets, I'm going to split this into multiple PRs for more target-focused review, once #136780 goes through the merge queue.

That'd be great, thank you! Especially the SGX stuff would be much simpler to review as a dedicated PR.

tgross35 · 2025-03-22T20:51:57Z

Actually, the other PRs in that rollup all merged. This wouldn't make it into a rollup for a few hours, so might as well use that time to try again on top of everything else in case it interacted with another PR somehow.

@bors r-
@bors try

bors · 2025-03-22T20:53:43Z

⌛ Trying commit f6e90d8 with merge 533535a...

…o, r=<try> Provide optional `Read`/`Write` methods for stdio Override more of the default methods for `io::Read` and `io::Write` for stdio types, when efficient to do so, and deduplicate unsupported types. Tracked in rust-lang#136756. try-job: x86_64-msvc-1

bors · 2025-03-22T23:22:54Z

☀️ Try build successful - checks-actions
Build commit: 533535a (533535adca65287b0e54b123821057231cd51bc8)

thaliaarchi · 2025-03-22T23:24:07Z

Probably just a spurious failure then?

tgross35 · 2025-03-23T01:35:14Z

I guess so, that’s just a weirdly specific failure to be spurious.

@bors r=joboet

bors · 2025-03-23T01:35:16Z

📌 Commit f6e90d8 has been approved by joboet

It is now in the queue for this repository.

bors · 2025-03-23T06:23:55Z

⌛ Testing commit f6e90d8 with merge 60a3084...

bors · 2025-03-23T09:28:10Z

☀️ Test successful - checks-actions
Approved by: joboet
Pushing 60a3084 to master...

github-actions · 2025-03-23T09:29:47Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing f08d5c0 (parent) -> 60a3084 (this PR)

Test differences

Show 60 test diffs

Additionally, 60 doctest diffs were found. These are ignored, as they are noisy.

Job group index

rust-timer · 2025-03-23T10:45:50Z

Finished benchmarking commit (60a3084): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -3.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-3.1%	[-3.1%, -3.1%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-3.1%	[-3.1%, -3.1%]	1

Cycles

Results (secondary 3.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.7%	[3.7%, 3.7%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 774.928s -> 774.048s (-0.11%)
Artifact size: 365.54 MiB -> 365.55 MiB (0.00%)

Currently, `write` for stdout and stderr is implemented with the semantics of `write_all`. Instead, implement `write_all` and call the underlying syscall only once in `write`. Also, implement `write_vectored` by adding support for `IoSlice`. Refactor stdin to reuse the unsupported type like rust-lang#136769.

Currently, `write` for stdout and stderr on Trusty is implemented with the semantics of `write_all`. Instead, implement `write_all` and call the underlying syscall only once in `write`. Also, implement `write_vectored` by adding support for `IoSlice`. Refactor stdin to reuse the unsupported type like rust-lang#136769.

Currently, `write` for stdout and stderr on Trusty is implemented with the semantics of `write_all`. Instead, call the underlying syscall only once in `write` and use the default implementation of `write_all` like other platforms. Also, implement `write_vectored` by adding support for `IoSlice`. Refactor stdin to reuse the unsupported type like rust-lang#136769.

…o, r=joboet Provide optional `Read`/`Write` methods for stdio Override more of the default methods for `io::Read` and `io::Write` for stdio types, when efficient to do so, and deduplicate unsupported types. Tracked in rust-lang#136756. try-job: x86_64-msvc-1

Trusty: Implement `write_vectored` for stdio Currently, `write` for stdout and stderr on Trusty is implemented with the semantics of `write_all`. Instead, call the underlying syscall only once in `write` and use the default implementation of `write_all` like other platforms. Also, implement `write_vectored` by adding support for `IoSlice`. Refactor stdin to reuse the unsupported type like rust-lang#136769. It requires rust-lang#138875 to fix the build for Trusty, though they do not conflict and can merge in either order. cc `@randomPoison`

Rollup merge of rust-lang#138876 - thaliaarchi:trusty-stdio, r=Noratrieb Trusty: Implement `write_vectored` for stdio Currently, `write` for stdout and stderr on Trusty is implemented with the semantics of `write_all`. Instead, call the underlying syscall only once in `write` and use the default implementation of `write_all` like other platforms. Also, implement `write_vectored` by adding support for `IoSlice`. Refactor stdin to reuse the unsupported type like rust-lang#136769. It requires rust-lang#138875 to fix the build for Trusty, though they do not conflict and can merge in either order. cc `@randomPoison`

Currently, `write` for stdout and stderr on Trusty is implemented with the semantics of `write_all`. Instead, call the underlying syscall only once in `write` and use the default implementation of `write_all` like other platforms. Also, implement `write_vectored` by adding support for `IoSlice`. Refactor stdin to reuse the unsupported type like rust-lang#136769.

Trusty: Implement `write_vectored` for stdio Currently, `write` for stdout and stderr on Trusty is implemented with the semantics of `write_all`. Instead, call the underlying syscall only once in `write` and use the default implementation of `write_all` like other platforms. Also, implement `write_vectored` by adding support for `IoSlice`. Refactor stdin to reuse the unsupported type like rust-lang#136769. It requires rust-lang#138875 to fix the build for Trusty, though they do not conflict and can merge in either order. cc `@randomPoison`

Trusty: Implement `write_vectored` for stdio Currently, `write` for stdout and stderr on Trusty is implemented with the semantics of `write_all`. Instead, call the underlying syscall only once in `write` and use the default implementation of `write_all` like other platforms. Also, implement `write_vectored` by adding support for `IoSlice`. Refactor stdin to reuse the unsupported type like rust-lang/rust#136769. It requires #138875 to fix the build for Trusty, though they do not conflict and can merge in either order. cc `@randomPoison`

rustbot assigned Noratrieb Feb 9, 2025

thaliaarchi mentioned this pull request Feb 9, 2025

Tracking issue for optional io::Read/io::Write methods #136756

Open

This comment has been minimized.

# to view

joboet requested changes Feb 9, 2025

View reviewed changes

library/std/src/io/stdio.rs Outdated Show resolved Hide resolved

library/std/src/io/stdio.rs Outdated Show resolved Hide resolved

library/std/src/io/stdio.rs Outdated Show resolved Hide resolved

library/std/src/io/stdio.rs Outdated Show resolved Hide resolved

thaliaarchi force-pushed the io-optional-methods/stdio branch from 6d101c2 to 3deb1ce Compare February 9, 2025 23:43

thaliaarchi mentioned this pull request Feb 11, 2025

Use const_error! when possible #136844

Merged

thaliaarchi requested a review from joboet February 11, 2025 01:12

rustbot assigned joboet and unassigned Noratrieb Feb 12, 2025

thaliaarchi changed the title ~~Provide optional Read/Write method for stdio~~ Provide optional Read/Write methods for stdio Feb 13, 2025

Noratrieb reviewed Feb 16, 2025

View reviewed changes

library/std/src/sys/pal/uefi/fs.rs Outdated Show resolved Hide resolved

thaliaarchi force-pushed the io-optional-methods/stdio branch 2 times, most recently from f51bb4e to 118bb74 Compare February 16, 2025 21:59

thaliaarchi marked this pull request as draft February 19, 2025 04:37

thaliaarchi force-pushed the io-optional-methods/stdio branch from 118bb74 to ade071b Compare February 21, 2025 05:27

rustbot added O-unix Operating system: Unix-like O-wasm Target: WASM (WebAssembly), http://webassembly.org/ O-windows Operating system: Windows labels Feb 21, 2025

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 22, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 23, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 23, 2025

bors merged commit 60a3084 into rust-lang:master Mar 23, 2025
7 checks passed

rustbot added this to the 1.87.0 milestone Mar 23, 2025

thaliaarchi deleted the io-optional-methods/stdio branch March 23, 2025 19:51

thaliaarchi mentioned this pull request Mar 24, 2025

Trusty: Implement write_vectored for stdio #138876

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Provide optional `Read`/`Write` methods for stdio #136769

Provide optional `Read`/`Write` methods for stdio #136769

thaliaarchi commented Feb 9, 2025 •

edited by tgross35

Loading

rustbot commented Feb 9, 2025

This comment has been minimized.

thaliaarchi commented Feb 11, 2025

Noratrieb commented Feb 12, 2025

thaliaarchi commented Feb 16, 2025

thaliaarchi commented Feb 19, 2025

joboet commented Feb 19, 2025

tgross35 commented Mar 22, 2025

bors commented Mar 22, 2025

bors commented Mar 22, 2025

thaliaarchi commented Mar 22, 2025

tgross35 commented Mar 23, 2025

bors commented Mar 23, 2025

bors commented Mar 23, 2025

bors commented Mar 23, 2025

github-actions bot commented Mar 23, 2025

rust-timer commented Mar 23, 2025

Provide optional Read/Write methods for stdio #136769

Provide optional Read/Write methods for stdio #136769

Conversation

thaliaarchi commented Feb 9, 2025 • edited by tgross35 Loading

rustbot commented Feb 9, 2025

This comment has been minimized.

thaliaarchi commented Feb 11, 2025

Noratrieb commented Feb 12, 2025

thaliaarchi commented Feb 16, 2025

thaliaarchi commented Feb 19, 2025

joboet commented Feb 19, 2025

tgross35 commented Mar 22, 2025

bors commented Mar 22, 2025

bors commented Mar 22, 2025

thaliaarchi commented Mar 22, 2025

tgross35 commented Mar 23, 2025

bors commented Mar 23, 2025

bors commented Mar 23, 2025

bors commented Mar 23, 2025

github-actions bot commented Mar 23, 2025

Test differences

rust-timer commented Mar 23, 2025

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Provide optional `Read`/`Write` methods for stdio #136769

Provide optional `Read`/`Write` methods for stdio #136769

thaliaarchi commented Feb 9, 2025 •

edited by tgross35

Loading