Rollup of 5 pull requests

[Urgau]

Successful merges:

• Add cygwin target. #134999 (Add cygwin target.)
• Stabilize vec_pop_if #135488 (Stabilize vec_pop_if)
• crashes: more tests #136068 (crashes: more tests)
• Update minifier version to 0.3.4 #136694 (Update minifier version to 0.3.4)
• Fix unwrap error in overflowing int literal #136760 (Fix unwrap error in overflowing int literal)

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

[Urgau]

@bors r+ p=5 rollup=never

[bors]

📌 Commit 2d5a1bd has been approved by Urgau

It is now in the queue for this repository.

[bors]

⌛ Testing commit 2d5a1bd with merge ea6fdd2...

[rust-log-analyzer]

The job aarch64-gnu failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

##[endgroup]
[TIMING] core::build_steps::tool::ToolBuild { compiler: Compiler { stage: 0, host: aarch64-unknown-linux-gnu }, target: aarch64-unknown-linux-gnu, tool: "tidy", path: "src/tools/tidy", mode: ToolBootstrap, source_type: InTree, extra_features: [], allow_features: "", cargo_args: [] } -- 30.325
[TIMING] core::build_steps::tool::Tidy { compiler: Compiler { stage: 0, host: aarch64-unknown-linux-gnu }, target: aarch64-unknown-linux-gnu } -- 0.000
fmt check
Diff in /checkout/compiler/rustc_target/src/spec/base/cygwin.rs:3:
 use crate::spec::{Cc, DebuginfoKind, LinkerFlavor, Lld, SplitDebuginfo, TargetOptions, cvs};
 pub(crate) fn opts() -> TargetOptions {
 pub(crate) fn opts() -> TargetOptions {
-    let mut pre_link_args = TargetOptions::link_args(LinkerFlavor::Gnu(Cc::No, Lld::No), &[
-        "--disable-dynamicbase",
-        "--enable-auto-image-base",
-    ]);
-    crate::spec::add_link_args(&mut pre_link_args, LinkerFlavor::Gnu(Cc::Yes, Lld::No), &[
-        "-Wl,--disable-dynamicbase",
-        "-Wl,--enable-auto-image-base",
+    let mut pre_link_args = TargetOptions::link_args(
+    let mut pre_link_args = TargetOptions::link_args(
+        LinkerFlavor::Gnu(Cc::No, Lld::No),
+        &["--disable-dynamicbase", "--enable-auto-image-base"],
+    crate::spec::add_link_args(
+        &mut pre_link_args,
+        &mut pre_link_args,
+        LinkerFlavor::Gnu(Cc::Yes, Lld::No),
+        &["-Wl,--disable-dynamicbase", "-Wl,--enable-auto-image-base"],
+    );
     let cygwin_libs = &["-lcygwin", "-lgcc", "-lcygwin", "-luser32", "-lkernel32", "-lgcc_s"];
     let mut late_link_args =
         TargetOptions::link_args(LinkerFlavor::Gnu(Cc::No, Lld::No), cygwin_libs);
Build completed unsuccessfully in 0:00:48
  local time: Sun Feb  9 18:39:43 UTC 2025
  network time: Sun, 09 Feb 2025 18:39:43 GMT
##[error]Process completed with exit code 1.

[bors]

💔 Test failed - checks-actions