Subtree update of `rust-analyzer` #136803

lnicola · 2025-02-10T06:24:53Z

Split manual.adoc into markdown files, one for each chapter. For the parts of the manual that are generated from source code doc comments, update the comments to use markdown syntax and update the code generators to write to `generated.md` files. For the weekly release, stop copying the .adoc files to the `rust-analyzer/rust-analyzer.github.io` at release time. Instead, we'll sync the manual hourly from this repository. See rust-analyzer/rust-analyzer.github.io#226 for the sync. This PR should be merged first, and that PR needs to be merged before the next weekly release. This change is based on rust-lang#15795, but rebased and updated. I've also manually checked each page for markdown syntax issues and fixed any I encountered. Co-authored-by: Lukas Wirth <lukastw97@gmail.com> Co-authored-by: Josh Rotenberg <joshrotenberg@gmail.com>

… not inside a macro call anymore) *after* the recursive call instead of before it This is because our detection is imperfect, and miss some cases such as an impersonating `test` macro, so we hope we'll expand successfully in this case.

AKA. target_feature 1.1, or non unsafe target_feature.

feat: Support RFC 2396

fix: In completion's expand, consider recursion stop condition (when we're not inside a macro call anymore) *after* the recursive call instead of before it

Split out `ExpressionStore` from `Body`

…lues feat: Implement `default-field-values`

It should be considered by the edition of the caller, not the callee. Technically we still don't do it correctly - we need the span of the method name (if it comes from a macro), but we don't keep it and this is good enough for now.

That was used as a fallback, causing a panic when the fallback was chosen. I also made sure this won't happen again by guaranteeing in the macro generating the tokens that they all exist.

fix: Fix a missing standard token in semantic highlighting

fix: Fix #[rustc_deprecated_safe_2024]

fix: Fix syntactic highlighting for renames

I added it by mistake in rust-lang#18927. I chose to keep the method as not static, because it's more comfortable, and keep the name `add_reference()` and not `reference()`, because it is clearer and better matches `strip_reference[s]()`.

Update README.md links for mdbook manual

Organise chapters in mdbook sidebar

Update PRIVACY.md

doc: error url

minor: Sync from downstream

rustbot · 2025-02-10T06:24:58Z

rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead.

cc @rust-lang/rust-analyzer

lnicola · 2025-02-10T06:25:03Z

@bors r+ p=1 subtree sync

bors · 2025-02-10T06:25:06Z

📌 Commit 8fd713b has been approved by lnicola

It is now in the queue for this repository.

Subtree update of `rust-analyzer` r? `@ghost`

Rollup of 6 pull requests Successful merges: - rust-lang#134626 (Add Four Codegen Tests) - rust-lang#136053 (coverage: Defer part of counter-creation until codegen) - rust-lang#136228 (Simplify Rc::as_ptr docs + typo fix) - rust-lang#136487 (ci: stop mysql before removing it) - rust-lang#136790 (Git blame ignore recent formatting commit) - rust-lang#136803 (Subtree update of `rust-analyzer`) r? `@ghost` `@rustbot` modify labels: rollup

Subtree update of `rust-analyzer` r? `@ghost`

bors · 2025-02-10T08:29:37Z

⌛ Testing commit 8fd713b with merge 162021c...

workingjubilee · 2025-02-10T08:44:21Z

yielding once to retry the rollup of this, to see if its failure was spurious
@bors retry

Rollup of 6 pull requests Successful merges: - rust-lang#134626 (Add Four Codegen Tests) - rust-lang#136053 (coverage: Defer part of counter-creation until codegen) - rust-lang#136228 (Simplify Rc::as_ptr docs + typo fix) - rust-lang#136487 (ci: stop mysql before removing it) - rust-lang#136790 (Git blame ignore recent formatting commit) - rust-lang#136803 (Subtree update of `rust-analyzer`) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2025-02-10T08:46:40Z

⌛ Testing commit 8fd713b with merge 80c0919...

bors · 2025-02-10T11:37:37Z

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing 80c0919 to master...

rust-timer · 2025-02-10T13:07:24Z

Finished benchmarking commit (80c0919): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.3%	[-0.3%, -0.3%]	2
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary -2.3%, secondary -3.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	4.9%	[4.9%, 4.9%]	1
Regressions ❌ (secondary)	1.8%	[1.8%, 1.8%]	1
Improvements ✅ (primary)	-2.5%	[-5.2%, -1.1%]	40
Improvements ✅ (secondary)	-3.2%	[-7.0%, -0.8%]	51
All ❌✅ (primary)	-2.3%	[-5.2%, 4.9%]	41

Cycles

Results (secondary -2.6%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.6%	[-2.6%, -2.6%]	1
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 781.62s -> 782.79s (0.15%)
Artifact size: 348.30 MiB -> 348.27 MiB (-0.01%)

vishruth-thimmaiah and others added 30 commits January 20, 2025 19:46

fix: upmap ranges in convert_tuple_struct_to_named_struct assist

a8f5471

fixes rust-lang#18766

Combine pat_hyigene and expr_hygiene

b46775a

BodyCollector

8e7a338

Cleanup body ast ptr defs

d9c58c8

Split out ExpressionStore from Body

c679d56

Add GenericDefId::StaticId

bdebd86

Support RFC 2396

5de2cd4

AKA. target_feature 1.1, or non unsafe target_feature.

Merge pull request rust-lang#19038 from ChayimFriedman2/unused-unsafe

9051647

feat: Support RFC 2396

Merge pull request rust-lang#19037 from ChayimFriedman2/fix-other-test

6db1411

fix: In completion's expand, consider recursion stop condition (when we're not inside a macro call anymore) *after* the recursive call instead of before it

Merge pull request rust-lang#19036 from Veykril/push-nprltlwvryxw

1711a19

Split out `ExpressionStore` from `Body`

feat: Implement default-field-values

d18afd3

Handle missing fields diagnostics

5ca9f52

Merge record lit's ellipsis into pre-existing spread's variant

2622160

Compute diagnostics of a field body iff it has one

faeaf4a

Implement HasResolver and HasModule for FieldId

c7463fe

Add a test for field default value body as defining usage of TAIT

ec89b7d

Fix a mistake in condition

e4e7c95

Remove has_default from FieldId

c093db0

Merge pull request rust-lang#19001 from ShoyuVanilla/default-field-va…

ad0aea4

…lues feat: Implement `default-field-values`

Fix #[rustc_deprecated_safe_2024]

9a0504b

It should be considered by the edition of the caller, not the callee. Technically we still don't do it correctly - we need the span of the method name (if it comes from a macro), but we don't keep it and this is good enough for now.

Fix a missing standard token in semantic highlighting

86d5e29

That was used as a fallback, causing a panic when the fallback was chosen. I also made sure this won't happen again by guaranteeing in the macro generating the tokens that they all exist.

Merge pull request rust-lang#19045 from ChayimFriedman2/missing-token

238d7bd

fix: Fix a missing standard token in semantic highlighting

Merge pull request rust-lang#19044 from ChayimFriedman2/deprecated-safe

0fe9d77

fix: Fix #[rustc_deprecated_safe_2024]

Fix syntactic highlighting for renames

5f2072c

Merge pull request rust-lang#19047 from lnicola/rename-highlight

d60afec

fix: Fix syntactic highlighting for renames

Remove duplicate method from hir::Type

78feee8

I added it by mistake in rust-lang#18927. I chose to keep the method as not static, because it's more comfortable, and keep the name `add_reference()` and not `reference()`, because it is clearer and better matches `strip_reference[s]()`.

Don't suggest into_iter().method() on iterators

b4508dc

Report calling unsafe fn pointer as unsafe

1ba8943

Wilfred and others added 10 commits February 7, 2025 12:25

Organise chapters in mdbook sidebar

b6fd709

Merge pull request rust-lang#19114 from Wilfred/update_readme_for_mdbook

236000b

Update README.md links for mdbook manual

Merge pull request rust-lang#19115 from Wilfred/sidebar_structure

cac45e1

Organise chapters in mdbook sidebar

Merge pull request rust-lang#19113 from BenjaminBrienen/patch-1

4ac07f2

Update PRIVACY.md

doc: error url

82162a7

Merge pull request rust-lang#19120 from ahaoboy/patch-1

d4f7c76

doc: error url

Preparing for merge from rust-lang/rust

879dc38

Merge from rust-lang/rust

15cd1f0

Bump rustc crates

24d7a14

Merge pull request rust-lang#19126 from lnicola/sync-from-rust

8fd713b

minor: Sync from downstream

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 10, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 10, 2025

Zalathar mentioned this pull request Feb 10, 2025

Rollup of 6 pull requests #136804

Closed

Zalathar added a commit to Zalathar/rust that referenced this pull request Feb 10, 2025

Rollup merge of rust-lang#136803 - lnicola:sync-from-ra, r=lnicola

1417031

Subtree update of `rust-analyzer` r? `@ghost`

bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 10, 2025

Auto merge of rust-lang#136803 - lnicola:sync-from-ra, r=lnicola

162021c

Subtree update of `rust-analyzer` r? `@ghost`

bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 10, 2025

bors merged commit 80c0919 into rust-lang:master Feb 10, 2025
7 checks passed

rustbot added this to the 1.86.0 milestone Feb 10, 2025

lnicola deleted the sync-from-ra branch February 11, 2025 10:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Subtree update of `rust-analyzer` #136803

Subtree update of `rust-analyzer` #136803

lnicola commented Feb 10, 2025

rustbot commented Feb 10, 2025

lnicola commented Feb 10, 2025

bors commented Feb 10, 2025

bors commented Feb 10, 2025

workingjubilee commented Feb 10, 2025

bors commented Feb 10, 2025

bors commented Feb 10, 2025

rust-timer commented Feb 10, 2025

Subtree update of rust-analyzer #136803

Subtree update of rust-analyzer #136803

Conversation

lnicola commented Feb 10, 2025

rustbot commented Feb 10, 2025

lnicola commented Feb 10, 2025

bors commented Feb 10, 2025

bors commented Feb 10, 2025

workingjubilee commented Feb 10, 2025

bors commented Feb 10, 2025

bors commented Feb 10, 2025

rust-timer commented Feb 10, 2025

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Subtree update of `rust-analyzer` #136803

Subtree update of `rust-analyzer` #136803