Skip to content

Upload Datadog metrics with citool #136977

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 5, 2025
Merged

Upload Datadog metrics with citool #136977

merged 4 commits into from
Mar 5, 2025

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Feb 13, 2025 •
edited
Loading

This removes one Python script and also the installation of the datadog-ci JavaScript package, along with the corresponding package and lock file.

r? @ghost

@rustbot rustbot added A-rustc-dev-guide Area: rustc-dev-guide A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Feb 13, 2025
@Kobzol
Copy link
Contributor Author

Kobzol commented Feb 13, 2025

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 13, 2025
@bors
Auto merge of rust-lang#136977 - Kobzol:citool-datadog, r=<try>
db475f1 
[WIP] Upload Datadog metrics with citool

Opening as a draft for testing.

r? `@ghost`
@bors
Copy link
Collaborator

bors commented Feb 13, 2025

⌛ Trying commit 091e615 with merge db475f1...

@rust-log-analyzer

This comment has been minimized.

# to view
@bors
Copy link
Collaborator

bors commented Feb 13, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 13, 2025
@Kobzol
Copy link
Contributor Author

Kobzol commented Feb 13, 2025

@bors try

@bors
Copy link
Collaborator

bors commented Feb 13, 2025

⌛ Trying commit 9043ce8 with merge aa8f739...

bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 13, 2025
@bors
Auto merge of rust-lang#136977 - Kobzol:citool-datadog, r=<try>
aa8f739 
[WIP] Upload Datadog metrics with citool

Opening as a draft for testing.

r? `@ghost`
@rust-log-analyzer

This comment has been minimized.

# to view
@bors
Copy link
Collaborator

bors commented Feb 13, 2025

💔 Test failed - checks-actions

@rust-log-analyzer

This comment has been minimized.

# to view
@Kobzol
Copy link
Contributor Author

Kobzol commented Feb 14, 2025

@bors try

@bors
Copy link
Collaborator

bors commented Feb 14, 2025

⌛ Trying commit 38ad38d with merge a4e8dc6...

bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 14, 2025
@bors
Auto merge of rust-lang#136977 - Kobzol:citool-datadog, r=<try>
a4e8dc6 
[WIP] Upload Datadog metrics with citool

Opening as a draft for testing.

r? `@ghost`
@rust-log-analyzer

This comment has been minimized.

# to view
@bors
Copy link
Collaborator

bors commented Feb 14, 2025

💔 Test failed - checks-actions

@Kobzol
Copy link
Contributor Author

Kobzol commented Feb 14, 2025

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 14, 2025
@bors
Auto merge of rust-lang#136977 - Kobzol:citool-datadog, r=<try>
1f76e3d 
[WIP] Upload Datadog metrics with citool

Opening as a draft for testing.

r? `@ghost`
@bors
Copy link
Collaborator

bors commented Feb 14, 2025

⌛ Trying commit 29795fd with merge 1f76e3d...

@bors
Copy link
Collaborator

bors commented Feb 14, 2025

☀️ Try build successful - checks-actions
Build commit: 1f76e3d (1f76e3d2dd689d518956789a032680cf0200d277)

@Kobzol Kobzol changed the title [WIP] Upload Datadog metrics with citool Upload Datadog metrics with citool Feb 14, 2025
@Kobzol
Copy link
Contributor Author

Kobzol commented Feb 14, 2025

r? @marcoieni

@rust-log-analyzer

This comment has been minimized.

# to view
@bors
Copy link
Collaborator

bors commented Feb 16, 2025

☔ The latest upstream changes (presumably #136914) made this pull request unmergeable. Please resolve the merge conflicts.

@Kobzol Kobzol marked this pull request as draft February 17, 2025 11:31
@Kobzol Kobzol marked this pull request as ready for review March 5, 2025 08:03
@Kobzol
Copy link
Contributor Author

Kobzol commented Mar 5, 2025

@rustbot ready

@rust-log-analyzer

This comment has been minimized.

# to view
marcoieni
marcoieni reviewed Mar 5, 2025
View reviewed changes
Copy link
Member

@marcoieni marcoieni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good overall. Just some minor comments and questions.

src/ci/citool/src/utils.rs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this utils concept a lot. One thing we could do is disallow the methods we extract, so that we remember to use the utils ones. Not in this PR necessarily.

@Kobzol
Copy link
Contributor Author

Kobzol commented Mar 5, 2025

@bors try

To check that the metrics are still being uploaded to DataDog.

bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 5, 2025
@bors
Auto merge of rust-lang#136977 - Kobzol:citool-datadog, r=<try>
895a039 
Upload Datadog metrics with citool

This removes one Python script and also the installation of the `datadog-ci` JavaScript package, along with the corresponding package and lock file.

r? `@ghost`
@bors
Copy link
Collaborator

bors commented Mar 5, 2025

⌛ Trying commit 6c2c5dc with merge 895a039...

marcoieni
marcoieni approved these changes Mar 5, 2025
View reviewed changes
Copy link
Member

@marcoieni marcoieni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feel free to r=me

@bors
Copy link
Collaborator

bors commented Mar 5, 2025

☀️ Try build successful - checks-actions
Build commit: 895a039 (895a039b4571ece88fdfe9bdc81d7f46afa498f2)

@Kobzol
Copy link
Contributor Author

Kobzol commented Mar 5, 2025

The metrics are in Datadog, good (the x64 dist runner has <50% CPU utilization, I should take a look at that, sigh).

@bors r=marcoieni

@bors
Copy link
Collaborator

bors commented Mar 5, 2025

📌 Commit 6c2c5dc has been approved by marcoieni

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 5, 2025
@jieyouxu jieyouxu mentioned this pull request Mar 5, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 5, 2025
@bors
Auto merge of rust-lang#138058 - jieyouxu:rollup-skdt0oz, r=jieyouxu
07b5eee 
Rollup of 20 pull requests

Successful merges:

 - rust-lang#134063 (dec2flt: Clean up float parsing modules)
 - rust-lang#136581 (Retire the legacy `Makefile`-based `run-make` test infra)
 - rust-lang#136662 (Count char width at most once in `Formatter::pad`)
 - rust-lang#136764 (Make `ptr_cast_add_auto_to_object` lint into hard error)
 - rust-lang#136798 (Added documentation for flushing per rust-lang#74348)
 - rust-lang#136865 (Perform deeper compiletest path normalization for `$TEST_BUILD_DIR` to account for compare-mode/debugger cases, and normalize long type file filename hashes)
 - rust-lang#136975 (Look for `python3` first on MacOS, not `py`)
 - rust-lang#136977 (Upload Datadog metrics with citool)
 - rust-lang#137240 (Slightly reformat `std::fs::remove_dir_all` error docs)
 - rust-lang#137298 (Check signature WF when lowering MIR body)
 - rust-lang#137463 ([illumos] attempt to use posix_spawn to spawn processes)
 - rust-lang#137477 (uefi: Add Service Binding Protocol abstraction)
 - rust-lang#137569 (Stabilize `string_extend_from_within`)
 - rust-lang#137633 (Only use implied bounds hack if bevy, and use deeply normalize in implied bounds hack)
 - rust-lang#137679 (Various coretests improvements)
 - rust-lang#137723 (Make `rust.description` more general-purpose and pass `CFG_VER_DESCRIPTION`)
 - rust-lang#137728 (Remove unsizing coercions for tuples)
 - rust-lang#137731 (Resume one waiter at once in deadlock handler)
 - rust-lang#137875 (mir_build: Integrate "simplification" steps into match-pair-tree creation)
 - rust-lang#138028 (compiler: add `ExternAbi::is_rustic_abi`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ab29c70 into rust-lang:master Mar 5, 2025
7 checks passed
@rustbot rustbot added this to the 1.87.0 milestone Mar 5, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 5, 2025
@rust-timer
Unrolled build for rust-lang#136977
1060361 
Rollup merge of rust-lang#136977 - Kobzol:citool-datadog, r=marcoieni

Upload Datadog metrics with citool

This removes one Python script and also the installation of the `datadog-ci` JavaScript package, along with the corresponding package and lock file.

r? `@ghost`
@Kobzol Kobzol deleted the citool-datadog branch March 5, 2025 19:01
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@klensy klensy klensy left review comments

@jieyouxu jieyouxu jieyouxu left review comments

@marcoieni marcoieni marcoieni approved these changes

Assignees

@marcoieni marcoieni

Labels
A-rustc-dev-guide Area: rustc-dev-guide A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.87.0
Development

Successfully merging this pull request may close these issues.
7 participants
@Kobzol @bors @rust-log-analyzer @rustbot @klensy @marcoieni @jieyouxu