Rollup of 10 pull requests #137046

workingjubilee · 2025-02-14T22:05:29Z

Successful merges:

triagebot: automatically add more rustdoc related labels #133312 (triagebot: automatically add more rustdoc related labels)
Stabilize const_is_char_boundary and const_str_split_at. #134016 (Stabilize const_is_char_boundary and const_str_split_at.)
Add a new check-pass UI test for returning impl Fn(T) -> impl Trait #136971 (Add a new check-pass UI test for returning impl Fn(T) -> impl Trait)
Prepare standard library for Rust 2024 migration #136983 (Prepare standard library for Rust 2024 migration)
Fix early lint check desc in query #137002 (Fix early lint check desc in query)
borrowck diagnostics cleanup: remove an unused and a barely-used field #137006 (borrowck diagnostics cleanup: remove an unused and a barely-used field)
Decode metadata buffer in one go #137032 (Decode metadata buffer in one go)
Normalize closure instance before eagerly monomorphizing it #137035 (Normalize closure instance before eagerly monomorphizing it)
add x86-sse2 (32bit) ABI that requires SSE2 target feature #137037 (add x86-sse2 (32bit) ABI that requires SSE2 target feature)
llvm: Tolerate captures in tests #137038 (llvm: Tolerate captures in tests)

r? @ghost
@rustbot modify labels: rollup

…cked)`.

A small workaround for rust-lang#136899, rustdoc's invalid_rust_codeblocks was not handling this well in 2024. This may be needed when migrating to 2024 when building with stage0.

This generates a warning of irrefutable patterns. I decided to slightly tweak the example so the closure returns unit, since the intent wasn't to show the weird behavior of returning `!`.

…straintInfo` `fr_is_local` was fully unused, and `outlived_fr_is_local` was used once

Change description from compiletest to regression test Co-authored-by: 许杰友 Jieyou Xu (Joe) <39484203+jieyouxu@users.noreply.github.com> Improve test name, location, and description Update tests/ui/impl-trait/impl-fn-rpit-opaque-107883.rs Co-authored-by: waffle <waffle.lapkin@gmail.com>

llvm/llvm-project@7e3735d introduces `captures` annotations. Adjust regexes to be tolerant of these.

…els, r=GuillaumeGomez triagebot: automatically add more rustdoc related labels [inspired by zulip discussion](https://rust-lang.zulipchat.com/#narrow/channel/242269-t-release.2Ftriage/topic/auto-adding.20team.20labels.20based.20on.20certain.20other.20labels)

… r=Amanieu Stabilize `const_is_char_boundary` and `const_str_split_at`. Tracking issues: rust-lang#131516, rust-lang#131518 Stabilized const API: ```rs // in `core` impl str { // const_is_char_boundary feature const fn is_char_boundary(&self, index: usize) -> bool; // const_str_split_at feature, depends on const_is_char_boundary const fn split_at(&self, mid: usize) -> (&str, &str); const fn split_at_mut(&mut self, mid: usize) -> (&mut str, &mut str); const fn split_at_checked(&self, mid: usize) -> Option<(&str, &str)>; const fn split_at_mut_checked(&mut self, mid: usize) -> Option<(&mut str, &mut str)>; } ``` This will allow safely splitting string slices during const-eval. Closes rust-lang#131516, Closes rust-lang#131518 This will need FCP. r? libs-api IIUC these do not use any new const language features (i.e. they are implementable manually on stable 1.83.0 using `unsafe`: [playground link](https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=3679632cd1041084796241b7ac8edfbd)). Cc ``@rust-lang/wg-const-eval`` (I don't know if I have the permissions for this ping; if not, someone else please ping wg-const-eval if it is necessary)

Add a new check-pass UI test for returning `impl Fn(T) -> impl Trait` This PR closes rust-lang#107883 by adding a ui test.

Prepare standard library for Rust 2024 migration This includes a variety of commits preparing the standard library for migration to Rust 2024. The actual migration is blocked on a few things, so I wanted to get this out of the way in a relatively digestable PR.

…sc, r=compiler-errors Fix early lint check desc in query When I debugging this issue: rust-lang#136906 (comment) I found early lint checking is performed after [macro expansion](https://github.com/chenyukang/rust/blob/37520e6d89eeea96b966ab281a7adf1775f7e207/compiler/rustc_interface/src/passes.rs#L267), but [prior to AST lowering](https://github.com/chenyukang/rust/blob/37520e6d89eeea96b966ab281a7adf1775f7e207/compiler/rustc_ast_lowering/src/lib.rs#L427). r? ``@cjgillot``

…iler-errors borrowck diagnostics cleanup: remove an unused and a barely-used field This removes the fields `fr_is_local` and `outlived_fr_is_local` from the struct `ErrorConstraintInfo`. `fr_is_local` was fully unused, but wasn't caught by dead-code analysis. For symmetry, and since `outlived_fr_is_local` was used only once and is easy to recompute, I've removed it too. That makes its one use a bit longer, but constructing/destructuring an `ErrorConsraintInfo` now fits on one line.

Decode metadata buffer in one go Not sure if this is perf relevant at all, but it was a bit odd before r? ``@the8472``

workingjubilee · 2025-02-14T22:05:47Z

waiting on the tree opening, but
@bors r+ rollup=never p=5

bors · 2025-02-14T22:05:51Z

📌 Commit 9d659fc has been approved by workingjubilee

It is now in the queue for this repository.

bors · 2025-02-14T22:05:51Z

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

ChrisDenton · 2025-02-15T00:29:41Z

@bors treeclosed-

bors · 2025-02-15T00:30:54Z

⌛ Testing commit 9d659fc with merge 54a0f38...

bors · 2025-02-15T03:32:44Z

☀️ Test successful - checks-actions
Approved by: workingjubilee
Pushing 54a0f38 to master...

rust-timer · 2025-02-15T03:35:34Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#133312	triagebot: automatically add more rustdoc related labels	`b8aeae26be4e59a9162cc750b36464df4c6e3dd1` (link)
#134016	Stabilize `const_is_char_boundary` and `const_str_split_at`.	`04eafc4139a115583576bc2744a47869c7acba33` (link)
#136971	Add a new check-pass UI test for returning `impl Fn(T) -> i…	`8c864be80ff75ca1684beabb4495bf0ab5f745d4` (link)
#136983	Prepare standard library for Rust 2024 migration	`dac107442aa51ae37b01649128d812d6fad62f28` (link)
#137002	Fix early lint check desc in query	`627ff469245b8fa05d0519add051e950e37d95fa` (link)
#137006	borrowck diagnostics cleanup: remove an unused and a barely…	`4e63e7ec501fb805870ada1aeb6e4f9b5f6233be` (link)
#137032	Decode metadata buffer in one go	`fa91148003023e266cf325d04aada799dbabe942` (link)
#137035	Normalize closure instance before eagerly monomorphizing it	`2b286f900a4472570afa1a23d01770a1acd83f3c` (link)
#137037	add x86-sse2 (32bit) ABI that requires SSE2 target feature	`7ef4f54733aa2e55d0d7ccec5b3a3185f841ce58` (link)
#137038	llvm: Tolerate captures in tests	`efc0fe0bbb65c1ad9f1977260221c53ae6a52155` (link)

previous master: fc147b4a81

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2025-02-15T04:49:49Z

Finished benchmarking commit (54a0f38): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -7.3%, secondary 3.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.1%	[3.1%, 3.1%]	1
Improvements ✅ (primary)	-7.3%	[-7.3%, -7.3%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-7.3%	[-7.3%, -7.3%]	1

Cycles

Results (primary -2.3%, secondary -3.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.3%	[-2.3%, -2.3%]	1
Improvements ✅ (secondary)	-3.1%	[-3.1%, -3.1%]	1
All ❌✅ (primary)	-2.3%	[-2.3%, -2.3%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 791.712s -> 790.529s (-0.15%)
Artifact size: 347.74 MiB -> 347.33 MiB (-0.12%)

zachs18 and others added 30 commits December 7, 2024 17:36

Const-stabilize str::is_char_boundary and `str::split_at(_mut)(_che…

1383272

…cked)`.

core: Apply unsafe_attr_outside_unsafe

ef34064

triagebot: automatically add more rustdoc related labels

cc74ed0

library: Update rand to 0.9.0

b7c975b

Migrate coretests to Rust 2024

0aa634e

alloc: Workaround hidden doctest line

890530e

A small workaround for rust-lang#136899, rustdoc's invalid_rust_codeblocks was not handling this well in 2024. This may be needed when migrating to 2024 when building with stage0.

alloc: Apply unsafe_attr_outside_unsafe

55ef73c

alloc: Apply missing_unsafe_on_extern

07ebbdd

std: Apply unsafe_attr_outside_unsafe

9e60b0e

std: Apply missing_unsafe_on_extern

c1791a1

std: Apply dependency_on_unit_never_type_fallback

7dc9e05

This generates a warning of irrefutable patterns. I decided to slightly tweak the example so the closure returns unit, since the intent wasn't to show the weird behavior of returning `!`.

std: Apply rust_2024_incompatible_pat

1ba59f8

std: Apply fixes for tail drop expressions

1b3940f

test: Apply deprecated_safe_2024

36733f3

std: Apply deprecated_safe_2024

ef20a1b

Fix early lint check desc in query

37520e6

remove fr_is_local and outlived_fr_is_local fields from `ErrorCon…

3f9cca3

…straintInfo` `fr_is_local` was fully unused, and `outlived_fr_is_local` was used once

further simplify a match

2ea9e1d

Decode metadata buffer in one go

be2cd95

add x86-sse2 (32bit) ABI that requires SSE2 target feature

2eff215

llvm: Tolerate captures in tests

db4c09c

llvm/llvm-project@7e3735d introduces `captures` annotations. Adjust regexes to be tolerant of these.

Normalize closure instance before eagerly monomorphizing it

2ada9cc

Rollup merge of rust-lang#136971 - HypheX:patch1, r=WaffleLapkin

2ec48fb

Add a new check-pass UI test for returning `impl Fn(T) -> impl Trait` This PR closes rust-lang#107883 by adding a ui test.

Rollup merge of rust-lang#137032 - oli-obk:push-ptvssqnomkpo, r=the8472

69dbedd

Decode metadata buffer in one go Not sure if this is perf relevant at all, but it was a bit odd before r? ``@the8472``

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 14, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 15, 2025

bors merged commit 54a0f38 into rust-lang:master Feb 15, 2025
7 checks passed

rustbot added this to the 1.86.0 milestone Feb 15, 2025

workingjubilee deleted the rollup-u56aw1m branch June 3, 2025 01:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 10 pull requests #137046

Rollup of 10 pull requests #137046

Uh oh!

workingjubilee commented Feb 14, 2025

Uh oh!

workingjubilee commented Feb 14, 2025

Uh oh!

bors commented Feb 14, 2025

Uh oh!

bors commented Feb 14, 2025

Uh oh!

ChrisDenton commented Feb 15, 2025

Uh oh!

bors commented Feb 15, 2025

Uh oh!

bors commented Feb 15, 2025

Uh oh!

Uh oh!

rust-timer commented Feb 15, 2025

Uh oh!

rust-timer commented Feb 15, 2025

Uh oh!

Uh oh!

Rollup of 10 pull requests #137046

Rollup of 10 pull requests #137046

Uh oh!

Conversation

workingjubilee commented Feb 14, 2025

Uh oh!

workingjubilee commented Feb 14, 2025

Uh oh!

bors commented Feb 14, 2025

Uh oh!

bors commented Feb 14, 2025

Uh oh!

ChrisDenton commented Feb 15, 2025

Uh oh!

bors commented Feb 15, 2025

Uh oh!

bors commented Feb 15, 2025

Uh oh!

Uh oh!

rust-timer commented Feb 15, 2025

Uh oh!

rust-timer commented Feb 15, 2025

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Uh oh!