{json|html}docck: catch and error on deprecated syntax #137103

yotamofek · 2025-02-15T22:50:25Z

rustbot · 2025-02-15T22:50:34Z

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

yotamofek · 2025-02-15T22:51:29Z

I think r? @fmease should make more sense? and maybe @aDotInTheVoid as the rustdoc json person

yotamofek · 2025-02-15T22:52:20Z

(this will cause tests to fail on CI until #137099 is merged)

aDotInTheVoid · 2025-02-16T16:17:52Z

I like the idea of erroring on this, but haven’t reviewed the impl yet.

CC @jieyouxu, as this does part of #125813, and can be removed if compiletest itself does this.

jieyouxu · 2025-02-16T16:21:02Z

Yeah, I wouldn't be too worried about the duplicate effort, because the compiletest one won't be any time soon. So getting this check for htmldocck in would still be beneficial.

aDotInTheVoid · 2025-02-16T19:18:55Z

r? @aDotInTheVoid

r=me after #137099 is merged

@bors rollup=always

@bors delegate

…directives, r=notriddle Fix (more) test directives that were accidentally ignored Continuation of rust-lang#137099 , caught by rust-lang#137103 (and needed to unblock that one). These test directives were accidentally using the old (`// `@`)` syntax

…directives, r=notriddle Fix (more) test directives that were accidentally ignored Continuation of rust-lang#137099 , caught by rust-lang#137103 (and needed to unblock that one). These test directives were accidentally using the old (`// ``@`)`` syntax

…directives, r=notriddle Fix (more) test directives that were accidentally ignored Continuation of rust-lang#137099 , caught by rust-lang#137103 (and needed to unblock that one). These test directives were accidentally using the old (`// ```@`)``` syntax

Rollup merge of rust-lang#137540 - yotamofek:pr/more-deprecated-test-directives, r=notriddle Fix (more) test directives that were accidentally ignored Continuation of rust-lang#137099 , caught by rust-lang#137103 (and needed to unblock that one). These test directives were accidentally using the old (`// ```@`)``` syntax

- replace `OnceLock` with `LazyLock` - use `let..else` where applicable

yotamofek · 2025-03-01T11:49:12Z

@aDotInTheVoid I think the bors incantation was wrong, it should be "delegate+" or "delegate=yotamofek" (according to the docs..)

Anyways, CI is green now, so care to approve? Thanks! 😊

aDotInTheVoid · 2025-03-01T12:09:42Z

@bors r+

bors · 2025-03-01T12:09:45Z

📌 Commit 797ef64 has been approved by aDotInTheVoid

It is now in the queue for this repository.

…ted-syntax, r=aDotInTheVoid {json|html}docck: catch and error on deprecated syntax rust-lang#137099 (review)

…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#136865 (Perform deeper compiletest path normalization for `$TEST_BUILD_DIR` to account for compare-mode/debugger cases, and normalize long type file filename hashes) - rust-lang#136922 (Pattern types: Avoid having to handle an Option for range ends in the type system or the HIR) - rust-lang#137081 (change config.toml to bootstrap.toml) - rust-lang#137103 ({json|html}docck: catch and error on deprecated syntax) - rust-lang#137632 (rustdoc: when merging target features, keep the highest stability) - rust-lang#137684 (Add rustdoc support for `--emit=dep-info[=path]`) - rust-lang#137794 (make qnx pass a test) - rust-lang#137801 (tests: Unignore target modifier tests on all platforms) - rust-lang#137826 (test(codegen): add looping_over_ne_bytes test for rust-lang#133528) Failed merges: - rust-lang#137147 (Add exclude to config.toml) r? `@ghost` `@rustbot` modify labels: rollup

…ted-syntax, r=aDotInTheVoid {json|html}docck: catch and error on deprecated syntax rust-lang#137099 (review)

…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#136865 (Perform deeper compiletest path normalization for `$TEST_BUILD_DIR` to account for compare-mode/debugger cases, and normalize long type file filename hashes) - rust-lang#137081 (change config.toml to bootstrap.toml) - rust-lang#137103 ({json|html}docck: catch and error on deprecated syntax) - rust-lang#137632 (rustdoc: when merging target features, keep the highest stability) - rust-lang#137684 (Add rustdoc support for `--emit=dep-info[=path]`) - rust-lang#137794 (make qnx pass a test) - rust-lang#137801 (tests: Unignore target modifier tests on all platforms) - rust-lang#137826 (test(codegen): add looping_over_ne_bytes test for rust-lang#133528) r? `@ghost` `@rustbot` modify labels: rollup

…ted-syntax, r=aDotInTheVoid {json|html}docck: catch and error on deprecated syntax rust-lang#137099 (review)

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#136865 (Perform deeper compiletest path normalization for `$TEST_BUILD_DIR` to account for compare-mode/debugger cases, and normalize long type file filename hashes) - rust-lang#137103 ({json|html}docck: catch and error on deprecated syntax) - rust-lang#137632 (rustdoc: when merging target features, keep the highest stability) - rust-lang#137684 (Add rustdoc support for `--emit=dep-info[=path]`) - rust-lang#137794 (make qnx pass a test) - rust-lang#137801 (tests: Unignore target modifier tests on all platforms) - rust-lang#137826 (test(codegen): add looping_over_ne_bytes test for rust-lang#133528) r? `@ghost` `@rustbot` modify labels: rollup

…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#137103 ({json|html}docck: catch and error on deprecated syntax) - rust-lang#137632 (rustdoc: when merging target features, keep the highest stability) - rust-lang#137684 (Add rustdoc support for `--emit=dep-info[=path]`) - rust-lang#137794 (make qnx pass a test) - rust-lang#137801 (tests: Unignore target modifier tests on all platforms) - rust-lang#137826 (test(codegen): add looping_over_ne_bytes test for rust-lang#133528) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#137103 - yotamofek:pr/jsonhtmldocck-deprecated-syntax, r=aDotInTheVoid {json|html}docck: catch and error on deprecated syntax rust-lang#137099 (review)

aDotInTheVoid · 2025-03-16T20:45:53Z

This just caught an error I made. Thanks <3

--- stderr -------------------------------
Invalid command: Deprecated command syntax, replace `// @` with `//@ ` on line 1
Invalid command: Deprecated command syntax, replace `// @` with `//@ ` on line 2
Jsondocck failed for /home/gh-aDotInTheVoid/rust2/tests/rustdoc-json/attrs/deprecated.rs
----------------------

yotamofek · 2025-03-16T21:08:38Z

Yay 🥰

…aumeGomez jsondocck: Require command is at start of line In one place we use `///`@`` instead of `//`@`.` The test-runner allowed it, but it probably shouldn't. Ran into by `@lolbinarycat` in rust-lang#132748 (comment): ``` error: unknown disambiguator `?(` ##[error] --> /checkout/tests/rustdoc-json/fns/return_type_alias.rs:3:25 | 3 | ///@ set foo = "$.index[?(`@.name=='Foo')].id"` | ^^ | ``` Maybe it's also worth erroring on this like we added in rust-lang#137103 r? `@GuillaumeGomez`

…aumeGomez jsondocck: Require command is at start of line In one place we use `///``@``` instead of `//``@`.`` The test-runner allowed it, but it probably shouldn't. Ran into by ``@lolbinarycat`` in rust-lang#132748 (comment): ``` error: unknown disambiguator `?(` ##[error] --> /checkout/tests/rustdoc-json/fns/return_type_alias.rs:3:25 | 3 | ///@ set foo = "$.index[?(``@.name=='Foo')].id"`` | ^^ | ``` Maybe it's also worth erroring on this like we added in rust-lang#137103 r? ``@GuillaumeGomez``

Rollup merge of rust-lang#140076 - aDotInTheVoid:jsondocline, r=GuillaumeGomez jsondocck: Require command is at start of line In one place we use `///``@``` instead of `//``@`.`` The test-runner allowed it, but it probably shouldn't. Ran into by ``@lolbinarycat`` in rust-lang#132748 (comment): ``` error: unknown disambiguator `?(` ##[error] --> /checkout/tests/rustdoc-json/fns/return_type_alias.rs:3:25 | 3 | ///@ set foo = "$.index[?(``@.name=='Foo')].id"`` | ^^ | ``` Maybe it's also worth erroring on this like we added in rust-lang#137103 r? ``@GuillaumeGomez``

rustbot assigned Mark-Simulacrum Feb 15, 2025

rustbot added A-rustdoc-json Area: Rustdoc JSON backend S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Feb 15, 2025

rustbot assigned fmease and unassigned Mark-Simulacrum Feb 15, 2025

fmease added the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label Feb 15, 2025

This comment has been minimized.

# to view

rustbot assigned aDotInTheVoid and unassigned fmease Feb 16, 2025

yotamofek mentioned this pull request Feb 16, 2025

Fix rustdoc test directives that were accidentally ignored 🧐 #137099

Merged

yotamofek force-pushed the pr/jsonhtmldocck-deprecated-syntax branch from 3da8fa4 to 48283aa Compare February 24, 2025 09:47

This comment has been minimized.

# to view

yotamofek mentioned this pull request Feb 24, 2025

Fix (more) test directives that were accidentally ignored #137540

Merged

yotamofek added 3 commits March 1, 2025 10:31

jsondocck: minor cleanups

11e7aaf

- replace `OnceLock` with `LazyLock` - use `let..else` where applicable

jsondocck: catch and error on deprecated syntax

94645f6

htmldocck: catch and error on deprecated syntax

797ef64

yotamofek force-pushed the pr/jsonhtmldocck-deprecated-syntax branch from 48283aa to 797ef64 Compare March 1, 2025 10:32

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 1, 2025

Rollup merge of rust-lang#137103 - yotamofek:pr/jsonhtmldocck-depreca…

cdc47e7

…ted-syntax, r=aDotInTheVoid {json|html}docck: catch and error on deprecated syntax rust-lang#137099 (review)

matthiaskrgr mentioned this pull request Mar 1, 2025

Rollup of 9 pull requests #137856

Closed

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 2, 2025

Rollup merge of rust-lang#137103 - yotamofek:pr/jsonhtmldocck-depreca…

de85a27

…ted-syntax, r=aDotInTheVoid {json|html}docck: catch and error on deprecated syntax rust-lang#137099 (review)

matthiaskrgr mentioned this pull request Mar 2, 2025

Rollup of 8 pull requests #137884

Closed

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 2, 2025

Rollup merge of rust-lang#137103 - yotamofek:pr/jsonhtmldocck-depreca…

7b9ce1d

…ted-syntax, r=aDotInTheVoid {json|html}docck: catch and error on deprecated syntax rust-lang#137099 (review)

matthiaskrgr mentioned this pull request Mar 2, 2025

Rollup of 7 pull requests #137903

Closed

matthiaskrgr mentioned this pull request Mar 3, 2025

Rollup of 6 pull requests #137914

Merged

bors merged commit 0447829 into rust-lang:master Mar 3, 2025
6 checks passed

rustbot added this to the 1.87.0 milestone Mar 3, 2025

yotamofek deleted the pr/jsonhtmldocck-deprecated-syntax branch March 5, 2025 06:09

aDotInTheVoid mentioned this pull request Apr 20, 2025

jsondocck: Require command is at start of line #140076

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

{json|html}docck: catch and error on deprecated syntax #137103

{json|html}docck: catch and error on deprecated syntax #137103

Uh oh!

yotamofek commented Feb 15, 2025

Uh oh!

rustbot commented Feb 15, 2025

Uh oh!

yotamofek commented Feb 15, 2025

Uh oh!

yotamofek commented Feb 15, 2025

Uh oh!

This comment has been minimized.

aDotInTheVoid commented Feb 16, 2025

Uh oh!

jieyouxu commented Feb 16, 2025

Uh oh!

aDotInTheVoid commented Feb 16, 2025

Uh oh!

This comment has been minimized.

yotamofek commented Mar 1, 2025

Uh oh!

aDotInTheVoid commented Mar 1, 2025

Uh oh!

bors commented Mar 1, 2025

Uh oh!

Uh oh!

aDotInTheVoid commented Mar 16, 2025

Uh oh!

yotamofek commented Mar 16, 2025 •

edited

Loading

Uh oh!

Uh oh!

{json|html}docck: catch and error on deprecated syntax #137103

{json|html}docck: catch and error on deprecated syntax #137103

Uh oh!

Conversation

yotamofek commented Feb 15, 2025

Uh oh!

rustbot commented Feb 15, 2025

Uh oh!

yotamofek commented Feb 15, 2025

Uh oh!

yotamofek commented Feb 15, 2025

Uh oh!

This comment has been minimized.

aDotInTheVoid commented Feb 16, 2025

Uh oh!

jieyouxu commented Feb 16, 2025

Uh oh!

aDotInTheVoid commented Feb 16, 2025

Uh oh!

This comment has been minimized.

yotamofek commented Mar 1, 2025

Uh oh!

aDotInTheVoid commented Mar 1, 2025

Uh oh!

bors commented Mar 1, 2025

Uh oh!

Uh oh!

aDotInTheVoid commented Mar 16, 2025

Uh oh!

yotamofek commented Mar 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

yotamofek commented Mar 16, 2025 •

edited

Loading