Skip to content

Stabilize const_vec_string_slice #137319

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 9, 2025
Merged

Stabilize const_vec_string_slice #137319

merged 1 commit into from
Mar 9, 2025

Conversation

Kixunil
Copy link
Contributor

@Kixunil Kixunil commented Feb 20, 2025

This feature was approved for stabilization in
#129041 (comment) so this change stabilizes it.

@rustbot
Copy link
Collaborator

rustbot commented Feb 20, 2025

r? @Noratrieb

rustbot has assigned @Noratrieb.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Feb 20, 2025
@rust-log-analyzer

This comment has been minimized.

# to view
@Kixunil Kixunil force-pushed the stabilize-const-vec-string-slice branch from e55dcd5 to 6c16e0a Compare February 20, 2025 16:30
@rust-log-analyzer

This comment has been minimized.

# to view
@Kixunil
Copy link
Contributor Author

Kixunil commented Feb 20, 2025

Looks like I have to rename the feature. Should I simply rename the mut ones to _mut?

@RalfJung RalfJung mentioned this pull request Feb 20, 2025
Open
3 tasks
@RalfJung
Copy link
Member

RalfJung commented Feb 20, 2025 •
edited
Loading

Ah, the list of functions in the tracking issue was outdated. Always a good idea to check that before starting FCP, as they are quite often outdated... but seems I forgot that here.

Ideally we'll stabilize the entire feature, including the mut methods. But that will require another FCP.

Cc @rust-lang/wg-const-eval

@Kixunil
Copy link
Contributor Author

Kixunil commented Feb 20, 2025

including the mut methods

Isn't &mut in const blanket-forbidden (for now)?

@Kixunil Kixunil force-pushed the stabilize-const-vec-string-slice branch from 6c16e0a to fb749f6 Compare February 20, 2025 17:49
@rust-log-analyzer

This comment has been minimized.

# to view
@RalfJung
Copy link
Member

Isn't &mut in const blanket-forbidden (for now)?

You are at least 3 months outdated. ;)
https://blog.rust-lang.org/2024/11/28/Rust-1.83.0.html

@Amanieu Amanieu added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Feb 25, 2025
@Amanieu
Copy link
Member

Amanieu commented Feb 25, 2025

Starting a new FCP since we missed some methods in the last one.

@rfcbot merge

@rfcbot
Copy link
Collaborator

rfcbot commented Feb 25, 2025 •
edited by dtolnay
Loading

Team member @Amanieu has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Feb 25, 2025
@rfcbot
Copy link
Collaborator

rfcbot commented Feb 25, 2025

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot removed the proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. label Feb 25, 2025
@rfcbot rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. to-announce Announce this issue on triage meeting and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Mar 7, 2025
@rfcbot
Copy link
Collaborator

rfcbot commented Mar 7, 2025

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

@rustbot rustbot mentioned this pull request Mar 7, 2025
Open
@Kixunil Kixunil force-pushed the stabilize-const-vec-string-slice branch from fb749f6 to b66c691 Compare March 8, 2025 07:25
@RalfJung
Copy link
Member

RalfJung commented Mar 8, 2025

tests/ui/consts/issue-94675.rs need to be updated.

@RalfJung
Copy link
Member

RalfJung commented Mar 8, 2025

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 8, 2025
@Kixunil Kixunil force-pushed the stabilize-const-vec-string-slice branch from b66c691 to d62164c Compare March 8, 2025 14:08
@Kixunil
Stabilize const_vec_string_slice
50ea503 
This feature was approved for stabilization in
rust-lang#129041 (comment)
so this change stabilizes it.
@Kixunil Kixunil force-pushed the stabilize-const-vec-string-slice branch from d62164c to 50ea503 Compare March 8, 2025 16:04
@Kixunil
Copy link
Contributor Author

Kixunil commented Mar 8, 2025

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 8, 2025
@dtolnay
Copy link
Member

dtolnay commented Mar 8, 2025

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 8, 2025

📌 Commit 50ea503 has been approved by dtolnay

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 8, 2025
@dtolnay dtolnay assigned dtolnay and unassigned Noratrieb Mar 8, 2025
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Mar 9, 2025
@jieyouxu
Rollup merge of rust-lang#137319 - Kixunil:stabilize-const-vec-string…
897f93f 
…-slice, r=dtolnay

Stabilize `const_vec_string_slice`

This feature was approved for stabilization in
rust-lang#129041 (comment) so this change stabilizes it.
@jieyouxu jieyouxu mentioned this pull request Mar 9, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 9, 2025
@bors
Auto merge of rust-lang#138255 - jieyouxu:rollup-lwjjdxu, r=jieyouxu
5533030 
Rollup of 16 pull requests

Successful merges:

 - rust-lang#122790 (Apply dllimport in ThinLTO)
 - rust-lang#136127 (Allow `*const W<dyn A> -> *const dyn A` ptr cast)
 - rust-lang#136968 (Turn order dependent trait objects future incompat warning into a hard error)
 - rust-lang#137147 (Add exclude to config.toml)
 - rust-lang#137319 (Stabilize `const_vec_string_slice`)
 - rust-lang#137885 (tidy: add triagebot checks)
 - rust-lang#138040 (compiler: Use `size_of` from the prelude instead of imported)
 - rust-lang#138052 (strip `-Wlinker-messages` wrappers from `rust-lld` rmake test)
 - rust-lang#138084 (Use workspace lints for crates in `compiler/`)
 - rust-lang#138158 (Move more layouting logic to `rustc_abi`)
 - rust-lang#138160 (depend more on attr_data_structures and move find_attr! there)
 - rust-lang#138192 (crashes: couple more tests)
 - rust-lang#138216 (bootstrap: Fix stack printing when a step cycle is detected)
 - rust-lang#138232 (Reduce verbosity of GCC build log)
 - rust-lang#138233 (Windows: Don't link std (and run-make) against advapi32, except on win7)
 - rust-lang#138242 (Revert "Don't test new error messages with the stage 0 compiler")

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 9, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 9, 2025
@bors
Auto merge of rust-lang#138267 - matthiaskrgr:rollup-vt76bhs, r=matth…
ed897d5 
…iaskrgr

Rollup of 12 pull requests

Successful merges:

 - rust-lang#136127 (Allow `*const W<dyn A> -> *const dyn A` ptr cast)
 - rust-lang#136968 (Turn order dependent trait objects future incompat warning into a hard error)
 - rust-lang#137319 (Stabilize `const_vec_string_slice`)
 - rust-lang#137885 (tidy: add triagebot checks)
 - rust-lang#138040 (compiler: Use `size_of` from the prelude instead of imported)
 - rust-lang#138084 (Use workspace lints for crates in `compiler/`)
 - rust-lang#138158 (Move more layouting logic to `rustc_abi`)
 - rust-lang#138160 (depend more on attr_data_structures and move find_attr! there)
 - rust-lang#138192 (crashes: couple more tests)
 - rust-lang#138216 (bootstrap: Fix stack printing when a step cycle is detected)
 - rust-lang#138232 (Reduce verbosity of GCC build log)
 - rust-lang#138242 (Revert "Don't test new error messages with the stage 0 compiler")

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit eade7e9 into rust-lang:master Mar 9, 2025
6 checks passed
@rustbot rustbot added this to the 1.87.0 milestone Mar 9, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 9, 2025
@rust-timer
Unrolled build for rust-lang#137319
b3f792f 
Rollup merge of rust-lang#137319 - Kixunil:stabilize-const-vec-string-slice, r=dtolnay

Stabilize `const_vec_string_slice`

This feature was approved for stabilization in
rust-lang#129041 (comment) so this change stabilizes it.
@Kixunil Kixunil deleted the stabilize-const-vec-string-slice branch March 10, 2025 07:22
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Apr 30, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@RalfJung RalfJung RalfJung left review comments

@dtolnay dtolnay dtolnay approved these changes

Assignees

@dtolnay dtolnay

Labels
disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.87.0
Development

Successfully merging this pull request may close these issues.
10 participants
@Kixunil @rustbot @rust-log-analyzer @RalfJung @Amanieu @rfcbot @dtolnay @bors @apiraino @Noratrieb