Set `target_vendor = "openwrt"` on `mips64-openwrt-linux-musl` #137836

madsmtm · 2025-03-01T04:00:25Z

OpenWRT is a Linux distribution for embedded network devices. The target name contains openwrt, so we should set cfg(target_vendor = "openwrt").

This is similar to what other Linux distributions do (the only one in-tree is x86_64-unikraft-linux-musl, but that sets target_vendor = "unikraft").

Motivation: To make correctly parsing target names simpler.

Fixes #131165.

CC target maintainer @Itus-Shield

On mips64-openwrt-linux-musl target.

rustbot · 2025-03-01T04:00:30Z

r? @BoxyUwU

rustbot has assigned @BoxyUwU.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2025-03-01T04:00:32Z

These commits modify compiler targets.
(See the Target Tier Policy.)

jieyouxu

Seems reasonable to me, thanks. r=me if the target maintainer agrees.

jieyouxu · 2025-03-01T10:54:33Z

r? jieyouxu
@bors delegate+ rollup

bors · 2025-03-01T10:54:36Z

✌️ @madsmtm, you can now approve this pull request!

If @jieyouxu told you to "r=me" after making some further change, please make that change, then do @bors r=@jieyouxu

jieyouxu · 2025-03-03T13:52:19Z

I'm going to approve this because I find this more "accurate" than

target_arch="mips64"
target_vendor="unknown"
target_os="linux"
target_env="musl"

where one can't distinguish between this target vs other mips64 linux-musl targets. If the target maintainer disagrees or have a better proposal, a follow-up PR is welcomed and feel free to roll me as the reviewer.

@bors r+ rollup

bors · 2025-03-03T13:52:21Z

📌 Commit c4d6426 has been approved by jieyouxu

It is now in the queue for this repository.

…ieyouxu Set `target_vendor = "openwrt"` on `mips64-openwrt-linux-musl` OpenWRT is a Linux distribution for embedded network devices. The target name contains `openwrt`, so we should set `cfg(target_vendor = "openwrt")`. This is similar to what other Linux distributions do (the only one in-tree is `x86_64-unikraft-linux-musl`, but that sets `target_vendor = "unikraft"`). Motivation: To make correctly [parsing target names](rust-lang/cc-rs#1413) simpler. Fixes rust-lang#131165. CC target maintainer `@Itus-Shield`

Rollup of 13 pull requests Successful merges: - rust-lang#136581 (Retire the legacy `Makefile`-based `run-make` test infra) - rust-lang#136865 (Perform deeper compiletest path normalization for `$TEST_BUILD_DIR` to account for compare-mode/debugger cases, and normalize long type file filename hashes) - rust-lang#137147 (Add exclude to config.toml) - rust-lang#137327 (Undeprecate env::home_dir) - rust-lang#137463 ([illumos] attempt to use posix_spawn to spawn processes) - rust-lang#137477 (uefi: Add Service Binding Protocol abstraction) - rust-lang#137502 (Don't include global asm in `mir_keys`, fix error body synthesis) - rust-lang#137534 ([rustdoc] hide item that is not marked as doc(inline) and whose src is doc(hidden)) - rust-lang#137565 (Try to point of macro expansion from resolver and method errors if it involves macro var) - rust-lang#137643 (Add DWARF test case for non-C-like `repr128` enums) - rust-lang#137722 (`librustdoc`: 2024 edition! 🎊) - rust-lang#137836 (Set `target_vendor = "openwrt"` on `mips64-openwrt-linux-musl`) - rust-lang#137949 (Update MSVC INSTALL.md instructions to recommend VS 2022 + recent Windows 10/11 SDK) Failed merges: - rust-lang#137798 (ci: use ubuntu 24 on arm large runner) r? `@ghost` `@rustbot` modify labels: rollup

…ieyouxu Set `target_vendor = "openwrt"` on `mips64-openwrt-linux-musl` OpenWRT is a Linux distribution for embedded network devices. The target name contains `openwrt`, so we should set `cfg(target_vendor = "openwrt")`. This is similar to what other Linux distributions do (the only one in-tree is `x86_64-unikraft-linux-musl`, but that sets `target_vendor = "unikraft"`). Motivation: To make correctly [parsing target names](rust-lang/cc-rs#1413) simpler. Fixes rust-lang#131165. CC target maintainer ``@Itus-Shield``

Rollup of 6 pull requests Successful merges: - rust-lang#135695 (Support raw-dylib link kind on ELF) - rust-lang#137836 (Set `target_vendor = "openwrt"` on `mips64-openwrt-linux-musl`) - rust-lang#137913 (Allow struct field default values to reference struct's generics) - rust-lang#137949 (Update MSVC INSTALL.md instructions to recommend VS 2022 + recent Windows 10/11 SDK) - rust-lang#137963 (Add ``dyn`` keyword to `E0373` examples) - rust-lang#137975 (Remove unused `PpMode::needs_hir`) r? `@ghost` `@rustbot` modify labels: rollup

jieyouxu · 2025-03-04T15:51:59Z

Actually, there's no need to rush this, let's wait to hear back from target maintainer.
@bors r-

jieyouxu · 2025-03-04T15:52:21Z

cc @Itus-Shield

jieyouxu · 2025-03-09T02:32:52Z

Please ping me (and mark this as unblocked) on or after ~2025-03-17 if we don't hear back from target maintainer by then.
@rustbot blocked (waiting to hear back from target maintainer)

jieyouxu · 2025-03-29T12:14:52Z

This is a long time so I'm going to approve. Thanks!
@bors r+ rollup

bors · 2025-03-29T12:14:55Z

📌 Commit c4d6426 has been approved by jieyouxu

It is now in the queue for this repository.

…ieyouxu Set `target_vendor = "openwrt"` on `mips64-openwrt-linux-musl` OpenWRT is a Linux distribution for embedded network devices. The target name contains `openwrt`, so we should set `cfg(target_vendor = "openwrt")`. This is similar to what other Linux distributions do (the only one in-tree is `x86_64-unikraft-linux-musl`, but that sets `target_vendor = "unikraft"`). Motivation: To make correctly [parsing target names](rust-lang/cc-rs#1413) simpler. Fixes rust-lang#131165. CC target maintainer `@Itus-Shield`

Rollup of 5 pull requests Successful merges: - rust-lang#137836 (Set `target_vendor = "openwrt"` on `mips64-openwrt-linux-musl`) - rust-lang#138206 ([AIX] Ignore linting on repr(C) structs with repr(packed) or repr(align(n))) - rust-lang#139044 (bootstrap: Avoid cloning `change-id` list) - rust-lang#139092 (Move `fd` into `std::sys`) - rust-lang#139111 (Properly document FakeReads) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2025-03-30T08:33:32Z

⌛ Testing commit c4d6426 with merge b9ea82b...

bors · 2025-03-30T11:40:33Z

☀️ Test successful - checks-actions
Approved by: jieyouxu
Pushing b9ea82b to master...

github-actions · 2025-03-30T11:42:16Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 85f518e (parent) -> b9ea82b (this PR)

Test differences

No test diffs found

Job duration changes

dist-x86_64-apple: 7176.4s -> 10673.6s (48.7%)
x86_64-apple-1: 7703.2s -> 8273.3s (7.4%)
dist-various-2: 3111.4s -> 3308.6s (6.3%)
aarch64-apple: 3906.9s -> 4149.6s (6.2%)
dist-x86_64-mingw: 7465.4s -> 7813.9s (4.7%)
dist-powerpc64le-linux: 9578.3s -> 9878.8s (3.1%)
x86_64-gnu-llvm-19-3: 6741.8s -> 6952.8s (3.1%)
aarch64-gnu-debug: 6319.5s -> 6476.7s (2.5%)
x86_64-msvc-ext2: 5762.9s -> 5845.6s (1.4%)
x86_64-gnu-tools: 5947.1s -> 5999.7s (0.9%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-03-30T14:08:28Z

Finished benchmarking commit (b9ea82b): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.3%	[-0.3%, -0.3%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.3%	[-0.3%, -0.3%]	1

Max RSS (memory usage)

Results (primary 2.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.4%	[2.4%, 2.4%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.4%	[2.4%, 2.4%]	1

Cycles

Results (secondary -7.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-7.7%	[-7.7%, -7.7%]	1
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 776.851s -> 778.078s (0.16%)
Artifact size: 365.87 MiB -> 365.93 MiB (0.02%)

Set target_vendor = "openwrt"

c4d6426

On mips64-openwrt-linux-musl target.

rustbot assigned BoxyUwU Mar 1, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 1, 2025

jieyouxu approved these changes Mar 1, 2025

View reviewed changes

rustbot assigned jieyouxu Mar 1, 2025

rustbot unassigned BoxyUwU Mar 1, 2025

jieyouxu added the A-targets Area: Concerning the implications of different compiler targets label Mar 3, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 3, 2025

jhpratt mentioned this pull request Mar 4, 2025

Rollup of 13 pull requests #137985

Closed

tgross35 mentioned this pull request Mar 4, 2025

Rollup of 6 pull requests #137989

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 4, 2025

jieyouxu added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 4, 2025

rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 9, 2025

rustbot added the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label Mar 9, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Mar 29, 2025

jhpratt mentioned this pull request Mar 30, 2025

Rollup of 5 pull requests #139126

Closed

bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 30, 2025

bors merged commit b9ea82b into rust-lang:master Mar 30, 2025
7 checks passed

rustbot added this to the 1.88.0 milestone Mar 30, 2025

bors mentioned this pull request Mar 30, 2025

feat: add succinct-zkvm os and target #138463

Open

madsmtm deleted the openwrt-target-vendor branch March 30, 2025 12:47

madsmtm mentioned this pull request Apr 3, 2025

Remove workaround for mips64-openwrt-linux-musl parsing rust-lang/cc-rs#1449

Merged

Set target_vendor = "openwrt" on mips64-openwrt-linux-musl #137836

Set target_vendor = "openwrt" on mips64-openwrt-linux-musl #137836

Uh oh!

Conversation

madsmtm commented Mar 1, 2025

Uh oh!

rustbot commented Mar 1, 2025

Uh oh!

rustbot commented Mar 1, 2025

Uh oh!

jieyouxu left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jieyouxu commented Mar 1, 2025

Uh oh!

bors commented Mar 1, 2025

Uh oh!

jieyouxu commented Mar 3, 2025

Uh oh!

bors commented Mar 3, 2025

Uh oh!

jieyouxu commented Mar 4, 2025

Uh oh!

jieyouxu commented Mar 4, 2025

Uh oh!

jieyouxu commented Mar 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jieyouxu commented Mar 29, 2025

Uh oh!

bors commented Mar 29, 2025

Uh oh!

bors commented Mar 30, 2025

Uh oh!

bors commented Mar 30, 2025

Uh oh!

Uh oh!

github-actions bot commented Mar 30, 2025

Test differences

Job duration changes

Uh oh!

rust-timer commented Mar 30, 2025

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Uh oh!

Set `target_vendor = "openwrt"` on `mips64-openwrt-linux-musl` #137836

Set `target_vendor = "openwrt"` on `mips64-openwrt-linux-musl` #137836

jieyouxu left a comment •

edited

Loading

jieyouxu commented Mar 9, 2025 •

edited

Loading