Skip to content

update outdated doc with new example #137889

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Mar 28, 2025
Merged

Conversation

mu001999
Copy link
Contributor

@mu001999 mu001999 commented Mar 2, 2025

update the illegal definition example because we can compile struct Ref<'a, T> { x: &'a T } (play)

@rustbot
Copy link
Collaborator

rustbot commented Mar 2, 2025

r? @wesleywiser

rustbot has assigned @wesleywiser.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 2, 2025
@hkBst
Copy link
Member

hkBst commented Mar 2, 2025

@mu001999 just curious, but do you know what changed when to make this well-formed?

@mu001999

This comment was marked as outdated.

@mu001999

This comment was marked as outdated.

@mu001999
Copy link
Contributor Author

mu001999 commented Mar 14, 2025

bisect:
commit[0] 2018-09-11: Auto merge of #53873 - nikomatsakis:nll-universe-subtyping-and-pattern-ascription, r=pnkfelix
commit[1] 2018-09-11: Auto merge of #53913 - petrochenkov:biattr4, r=alexcrichton
commit[2] 2018-09-12: Auto merge of #51159 - pacman82:master, r=oli-obk
commit[3] 2018-09-12: Auto merge of #54146 - kennytm:rollup, r=kennytm
commit[4] 2018-09-12: Auto merge of #53793 - toidiu:ak-stabalize, r=nikomatsakis
commit[5] 2018-09-12: Auto merge of #54152 - michaelwoerister:cgu-name-fix, r=alexcrichton
commit[6] 2018-09-12: Auto merge of #53409 - GuillaumeGomez:associated-const-value, r=QuietMisdreavus

********************************************************************************
Regression in nightly-2018-09-13
********************************************************************************
fetching (via local git) commits from 2f1547c0aa5957b42cc768c00119c6eb7b4262d3 to f2302daef3608c09e2b50193a64611b18ced86f3
opening existing repository at "/home/r0cky/repos/rust"
Found origin remote under name `origin`
refreshing repository at "/home/r0cky/repos/rust"
looking up first commit
looking up second commit
checking that commits are by bors and thus have ci artifacts...
finding bors merge commits
found 7 bors merge commits in the specified range
  commit[0] 2018-09-11: Auto merge of #53873 - nikomatsakis:nll-universe-subtyping-and-pattern-ascription, r=pnkfelix
  commit[1] 2018-09-11: Auto merge of #53913 - petrochenkov:biattr4, r=alexcrichton
  commit[2] 2018-09-12: Auto merge of #51159 - pacman82:master, r=oli-obk
  commit[3] 2018-09-12: Auto merge of #54146 - kennytm:rollup, r=kennytm
  commit[4] 2018-09-12: Auto merge of #53793 - toidiu:ak-stabalize, r=nikomatsakis
  commit[5] 2018-09-12: Auto merge of #54152 - michaelwoerister:cgu-name-fix, r=alexcrichton
  commit[6] 2018-09-12: Auto merge of #53409 - GuillaumeGomez:associated-const-value, r=QuietMisdreavus
ERROR: no CI builds available between 2f1547c0aa5957b42cc768c00119c6eb7b4262d3 and f2302daef3608c09e2b50193a64611b18ced86f3 within last 167 days

@mu001999
Copy link
Contributor Author

what changed when to make this well-formed?

@hkBst it should be #53793

@hkBst
Copy link
Member

hkBst commented Mar 14, 2025

src/test/ui/regions/regions-struct-not-wf.rs seems to contain examples of things that are not well-formed

@hkBst
Copy link
Member

hkBst commented Mar 14, 2025

what changed when to make this well-formed?

@hkBst it should be #53793

Seems that RFC 2093 got stabilized.

@wesleywiser
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Mar 28, 2025

📌 Commit 4508f5f has been approved by wesleywiser

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 28, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 28, 2025
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#137889 (update outdated doc with new example)
 - rust-lang#138104 (Greatly simplify doctest parsing and information extraction)
 - rust-lang#138678 (rustc_resolve: fix instability in lib.rmeta contents)
 - rust-lang#138986 (feat(config): Add ChangeId enum for suppressing warnings)
 - rust-lang#139038 (Update target maintainers for thumb targets to reflect new REWG Arm team name)
 - rust-lang#139045 (bootstrap: update `test_find` test)
 - rust-lang#139047 (Remove ScopeDepth)

Failed merges:

 - rust-lang#139044 (bootstrap: Avoid cloning `change-id` list)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 28, 2025
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#137889 (update outdated doc with new example)
 - rust-lang#138104 (Greatly simplify doctest parsing and information extraction)
 - rust-lang#138678 (rustc_resolve: fix instability in lib.rmeta contents)
 - rust-lang#138986 (feat(config): Add ChangeId enum for suppressing warnings)
 - rust-lang#139038 (Update target maintainers for thumb targets to reflect new REWG Arm team name)
 - rust-lang#139045 (bootstrap: update `test_find` test)
 - rust-lang#139047 (Remove ScopeDepth)

Failed merges:

 - rust-lang#139044 (bootstrap: Avoid cloning `change-id` list)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 9597bf7 into rust-lang:master Mar 28, 2025
6 checks passed
@rustbot rustbot added this to the 1.87.0 milestone Mar 28, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 28, 2025
Rollup merge of rust-lang#137889 - mu001999-contrib:update-doc, r=wesleywiser

update outdated doc with new example

update the illegal definition example because we can compile `struct Ref<'a, T> { x: &'a T }` ([play](https://play.rust-lang.org/?version=stable&mode=debug&edition=2024&gist=2eb2f8800d423c316b545c864623ae16))
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants