Skip to content

Fix an off by 1 error in test-float-parse #137948

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 2 commits into from

Conversation

speedy-lex
Copy link
Contributor

    SUCCESS for generator 'f64 large integer values'. 59508/59508 passed in 1.2150712s
    SUCCESS for generator 'f16 exhaustive'. 65536/65536 passed in 3.148837s
      warning: executed tests != estimated (65536 != 65535) for exhaustive <<<< This is what is fixed
    SUCCESS for generator 'f32 fuzz'. 65535/65535 passed in 1.5524527s
    SUCCESS for generator 'f64 few ones int'. 262144/262144 passed in 1.2051041s

@rustbot
Copy link
Collaborator

rustbot commented Mar 3, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 3, 2025
@jieyouxu
Copy link
Member

jieyouxu commented Mar 3, 2025

r? @tgross35

@rustbot rustbot assigned tgross35 and unassigned Mark-Simulacrum Mar 3, 2025
@tgross35
Copy link
Contributor

tgross35 commented Mar 3, 2025

The title had me worried for a minute, but this is in the total estimation :) thanks!

@birs r+ rollup

@speedy-lex
Copy link
Contributor Author

@tgross35, I'm pretty sure you meant to ping @bors

@tgross35
Copy link
Contributor

tgross35 commented Mar 3, 2025

Whoop, sorry about that birs.

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Mar 3, 2025

📌 Commit 0f52ff8 has been approved by tgross35

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Mar 3, 2025

🌲 The tree is currently closed for pull requests below priority 102. This pull request will be tested once the tree is reopened.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 3, 2025
@tgross35
Copy link
Contributor

tgross35 commented Mar 4, 2025

Oh, there is a conflict because I guess I also fixed this in #137525.

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 4, 2025
@bors
Copy link
Collaborator

bors commented Mar 4, 2025

☔ The latest upstream changes (presumably #137927) made this pull request unmergeable. Please resolve the merge conflicts.

@speedy-lex
Copy link
Contributor Author

@tgross35, I feel like this solution is better as it can't panic. I don't think an estimation should panic.

@tgross35
Copy link
Contributor

tgross35 commented Mar 4, 2025

I think it's actually preferable to panic here - that limit is only hit if attempting to run exhaustive tests on f64 or f128, I'd rather be notified immediately then coming back a few hours later and realizing I started a test that will run for the next 2159123 years :) (I just tried it to get that estimate)

@rustbot
Copy link
Collaborator

rustbot commented Mar 4, 2025

There are merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged.

You can start a rebase with the following commands:

$ # rebase
$ git pull --rebase https://github.com/rust-lang/rust.git master
$ git push --force-with-lease

The following commits are merge commits:

@rustbot rustbot added the has-merge-commits PR has merge commits, merge with caution. label Mar 4, 2025
@speedy-lex speedy-lex closed this Mar 4, 2025
@speedy-lex speedy-lex deleted the test-float-parse-fix branch March 4, 2025 10:58
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants