Skip to content

test: Fix run-make on windows #13795

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Apr 28, 2014
Merged

test: Fix run-make on windows #13795

merged 2 commits into from
Apr 28, 2014

Conversation

klutzy
Copy link
Contributor

@klutzy klutzy commented Apr 27, 2014

Fixes #12303.

Also contains a partial fix for make check failure.

# trailing slash (`c:/path/to/test/`).
# the easist workaround is to remove the slash (`c:/path/to/test`).
# msys2 seems to fix this problem.
path = path[:-1]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that's a little terrifying

@alexcrichton
Copy link
Member

Awesome job!

@klutzy
Copy link
Contributor Author

klutzy commented Apr 28, 2014

rebased; fixed c-link-to-rust-staticlib/no-intermediate-extras and added some comments at dep-info/dep-info-custom.

bors added a commit that referenced this pull request Apr 28, 2014
Fixes #12303.

Also contains a partial fix for `make check` failure.
@bors bors closed this Apr 28, 2014
@bors bors merged commit 405861e into rust-lang:master Apr 28, 2014
arcnmx pushed a commit to arcnmx/rust that referenced this pull request Jan 9, 2023
…n-path-deps, r=jonas-schievink

fix: Use the correct edition when formatting code in path dependencies

Fixes rust-lang/rust-analyzer#13790

Don't go through the Cargo workspace info, since that doesn't contain path dependencies. Instead, query the crate graph via `Analysis::crate_edition`.
flip1995 pushed a commit to flip1995/rust that referenced this pull request Dec 15, 2024
Fix rust-lang#13795

changelog: [`shadow_same`]: detect shadowing as a pattern field
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

run-make tests don't work on windows
3 participants