Skip to content

Elaborate trait assumption in receiver_is_dispatchable #138174

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 12, 2025
Merged

Elaborate trait assumption in receiver_is_dispatchable #138174

merged 1 commit into from
Mar 12, 2025

Conversation

compiler-errors
Copy link
Member

Fixes #138172. See comment on the linked test.

Probably not a fix for the general problem, bc I think this may still be incomplete for other weird where clauses on the receiver. But 🤷, supertraits seems like an obvious one to fix.

@rustbot
Copy link
Collaborator

rustbot commented Mar 7, 2025

r? @cjgillot

rustbot has assigned @cjgillot.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 7, 2025
@compiler-errors
Copy link
Member Author

r? lcnr or reassign

@rustbot rustbot assigned lcnr and unassigned cjgillot Mar 7, 2025
BoxyUwU
BoxyUwU reviewed Mar 8, 2025
View reviewed changes
compiler/rustc_trait_selection/src/traits/dyn_compatibility.rs Outdated
Comment on lines 601 to 604
let caller_bounds = param_env
.caller_bounds()
.iter()
.chain(elaborate(tcx, [unsize_predicate, trait_predicate]));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come we don't call normalize_param_env_or_error on this ParamEnv, I would expect us to currently handle this check wrong when we have where clauses containing normalizable aliases, and after this change also handle supertraits of U: Trait wrong when they contain aliases.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could do that too, maybe i can make an error that requires the param env to be normalized

@BoxyUwU
Copy link
Member

BoxyUwU commented Mar 8, 2025

r? @BoxyUwU

@rustbot rustbot assigned BoxyUwU and unassigned lcnr Mar 8, 2025
@BoxyUwU BoxyUwU added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 8, 2025
@compiler-errors compiler-errors force-pushed the elaborate-unsize-self-pred branch from 29fef56 to c170d0f Compare March 11, 2025 16:33
@compiler-errors
Copy link
Member Author

Normalizing the param-env works, and I added a test that is fixed by doing that too.

compiler-errors
compiler-errors commented Mar 11, 2025
View reviewed changes
tests/ui/associated-types/issue-59324.rs
@@ -15,6 +15,7 @@ pub trait ThriftService<Bug: NotFoo>:
{
fn get_service(
//~^ ERROR the trait bound `Bug: Foo` is not satisfied
//~| ERROR the trait bound `Bug: Foo` is not satisfied
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normalizing the param-env leads to a duplicated error, but 🤷

@BoxyUwU
Copy link
Member

BoxyUwU commented Mar 12, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Mar 12, 2025

📌 Commit c170d0f has been approved by BoxyUwU

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 12, 2025
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Mar 12, 2025
@jieyouxu
Rollup merge of rust-lang#138174 - compiler-errors:elaborate-unsize-s…
1ce7e1f 
…elf-pred, r=BoxyUwU

Elaborate trait assumption in `receiver_is_dispatchable`

Fixes rust-lang#138172. See comment on the linked test.

Probably not a fix for the general problem, bc I think this may still be incomplete for other weird `where` clauses on the receiver. But 🤷, supertraits seems like an obvious one to fix.
@jieyouxu jieyouxu mentioned this pull request Mar 12, 2025
Closed
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Mar 12, 2025
@jieyouxu
Rollup merge of rust-lang#138174 - compiler-errors:elaborate-unsize-s…
d7a1a28 
…elf-pred, r=BoxyUwU

Elaborate trait assumption in `receiver_is_dispatchable`

Fixes rust-lang#138172. See comment on the linked test.

Probably not a fix for the general problem, bc I think this may still be incomplete for other weird `where` clauses on the receiver. But 🤷, supertraits seems like an obvious one to fix.
@jieyouxu jieyouxu mentioned this pull request Mar 12, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 12, 2025
@bors
Auto merge of rust-lang#138383 - jieyouxu:rollup-ntnvzmn, r=jieyouxu
74d92df 
Rollup of 25 pull requests

Successful merges:

 - rust-lang#134076 (Stabilize `std::io::ErrorKind::InvalidFilename`)
 - rust-lang#136842 (Add libstd support for Trusty targets)
 - rust-lang#137314 (change definitely unproductive cycles to error)
 - rust-lang#137504 (Move methods from Map to TyCtxt, part 4.)
 - rust-lang#137621 (Add std support to cygwin target)
 - rust-lang#137701 (Convert `ShardedHashMap` to use `hashbrown::HashTable`)
 - rust-lang#138109 (make precise capturing args in rustdoc Json typed)
 - rust-lang#138161 (Add PeekMut::refresh)
 - rust-lang#138162 (Update the standard library to Rust 2024)
 - rust-lang#138174 (Elaborate trait assumption in `receiver_is_dispatchable`)
 - rust-lang#138175 (Support rmeta inputs for --crate-type=bin --emit=obj)
 - rust-lang#138269 (uefi: fs: Implement FileType, FilePermissions and FileAttr)
 - rust-lang#138313 (Update books)
 - rust-lang#138318 (Rustdoc: remove a bunch of `@ts-expect-error` from main.js)
 - rust-lang#138331 (Use `RUSTC_LINT_FLAGS` more)
 - rust-lang#138333 (Rebuild llvm spuriously less frequently)
 - rust-lang#138343 (Enable `f16` tests for `powf`)
 - rust-lang#138345 (Some autodiff cleanups)
 - rust-lang#138346 (naked functions: on windows emit `.endef` without the symbol name)
 - rust-lang#138347 (Reduce `kw::Empty` usage, part 2)
 - rust-lang#138360 (Fix false-positive in `expr_or_init` and in the `invalid_from_utf8` lint)
 - rust-lang#138371 (Update compiletest's `has_asm_support` to match rustc)
 - rust-lang#138372 (Refactor `pick2_mut` & `pick3_mut` to use `get_disjoint_mut`)
 - rust-lang#138376 (Item-related cleanups)
 - rust-lang#138377 (Remove unnecessary lifetime from `PatInfo`.)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 12, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 12, 2025
@bors
Auto merge of rust-lang#138388 - matthiaskrgr:rollup-kbax8sz, r=matth…
3f155ac 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#138161 (Add PeekMut::refresh)
 - rust-lang#138174 (Elaborate trait assumption in `receiver_is_dispatchable`)
 - rust-lang#138313 (Update books)
 - rust-lang#138347 (Reduce `kw::Empty` usage, part 2)
 - rust-lang#138360 (Fix false-positive in `expr_or_init` and in the `invalid_from_utf8` lint)
 - rust-lang#138372 (Refactor `pick2_mut` & `pick3_mut` to use `get_disjoint_mut`)
 - rust-lang#138376 (Item-related cleanups)
 - rust-lang#138377 (Remove unnecessary lifetime from `PatInfo`.)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 12, 2025
@bors
Auto merge of rust-lang#138388 - matthiaskrgr:rollup-kbax8sz, r=matth…
57a4736 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#138161 (Add PeekMut::refresh)
 - rust-lang#138174 (Elaborate trait assumption in `receiver_is_dispatchable`)
 - rust-lang#138313 (Update books)
 - rust-lang#138347 (Reduce `kw::Empty` usage, part 2)
 - rust-lang#138360 (Fix false-positive in `expr_or_init` and in the `invalid_from_utf8` lint)
 - rust-lang#138372 (Refactor `pick2_mut` & `pick3_mut` to use `get_disjoint_mut`)
 - rust-lang#138376 (Item-related cleanups)
 - rust-lang#138377 (Remove unnecessary lifetime from `PatInfo`.)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 143eb4f into rust-lang:master Mar 12, 2025
6 checks passed
@rustbot rustbot added this to the 1.87.0 milestone Mar 12, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 12, 2025
@rust-timer
Unrolled build for rust-lang#138174
dea6cb0 
Rollup merge of rust-lang#138174 - compiler-errors:elaborate-unsize-self-pred, r=BoxyUwU

Elaborate trait assumption in `receiver_is_dispatchable`

Fixes rust-lang#138172. See comment on the linked test.

Probably not a fix for the general problem, bc I think this may still be incomplete for other weird `where` clauses on the receiver. But 🤷, supertraits seems like an obvious one to fix.
@ojeda ojeda mentioned this pull request Mar 12, 2025
Open
95 tasks
@compiler-errors compiler-errors mentioned this pull request Mar 25, 2025
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@BoxyUwU BoxyUwU BoxyUwU left review comments

@lcnr lcnr lcnr approved these changes

Assignees

@BoxyUwU BoxyUwU

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.87.0
Development

Successfully merging this pull request may close these issues.

CoercePointee doesn't support trait bounds on the smart pointer
6 participants
@compiler-errors @rustbot @BoxyUwU @bors @lcnr @cjgillot