Allow specifying glob patterns for try jobs #138307

Kobzol · 2025-03-10T12:41:44Z

This PR modifies the try-job lookup logic to allow glob patterns. So you can e.g. request all MSVC-related jobs with try-job: *msvc*.

Best reviewed commit by commit.

r? @marcoieni

try-job: *msvc*

Just to avoid surprises, the amount of used keys is not large.

rustbot · 2025-03-10T12:41:50Z

The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes.

cc @BoxyUwU, @jieyouxu, @Kobzol

Kobzol · 2025-03-10T12:47:00Z

@bors try

Allow specifying glob patterns for try jobs This PR modifies the `try-job` lookup logic to allow glob patterns. So you can e.g. request all MSVC-related jobs with `try-job: *msvc*`. Best reviewed commit by commit. r? `@marcoieni` try-job: *msvc*

bors · 2025-03-10T12:48:12Z

⌛ Trying commit d32fddf with merge d308586...

bors · 2025-03-10T12:59:47Z

💔 Test failed - checks-actions

Kobzol · 2025-03-10T13:05:43Z

@bors try

bors · 2025-03-10T13:06:54Z

⌛ Trying commit 2e48b80 with merge 6bde3b6...

Allow specifying glob patterns for try jobs This PR modifies the `try-job` lookup logic to allow glob patterns. So you can e.g. request all MSVC-related jobs with `try-job: *msvc*`. Best reviewed commit by commit. r? `@marcoieni` try-job: `*msvc*`

Kobzol · 2025-03-10T13:09:05Z

@bors try

Allow specifying glob patterns for try jobs This PR modifies the `try-job` lookup logic to allow glob patterns. So you can e.g. request all MSVC-related jobs with `try-job: *msvc*`. Best reviewed commit by commit. r? `@marcoieni` try-job: `*msvc*`

bors · 2025-03-10T13:10:18Z

⌛ Trying commit 16c08f6 with merge 1074151...

bors · 2025-03-10T13:12:29Z

💔 Test failed - checks-actions

Kobzol · 2025-03-10T13:33:10Z

(I cancelled the try build to avoid wasting resources, the failure is not relevant).

matthiaskrgr · 2025-03-10T13:51:15Z

try-job: .* will this work? 😅

Kobzol · 2025-03-10T13:53:18Z

To clarify, it's a glob pattern, not a regex, so you probably meant * :) Yes, you can do that, but then the max. 20 jobs limit will kick in and the try build will thus fail.

marcoieni · 2025-03-10T15:58:30Z

@bors r+

bors · 2025-03-10T15:58:32Z

📌 Commit 16c08f6 has been approved by marcoieni

It is now in the queue for this repository.

Allow specifying glob patterns for try jobs This PR modifies the `try-job` lookup logic to allow glob patterns. So you can e.g. request all MSVC-related jobs with `try-job: *msvc*`. Best reviewed commit by commit. r? `@marcoieni` try-job: `*msvc*`

Allow specifying glob patterns for try jobs This PR modifies the `try-job` lookup logic to allow glob patterns. So you can e.g. request all MSVC-related jobs with `try-job: *msvc*`. Best reviewed commit by commit. r? ``@marcoieni`` try-job: `*msvc*`

Allow specifying glob patterns for try jobs This PR modifies the `try-job` lookup logic to allow glob patterns. So you can e.g. request all MSVC-related jobs with `try-job: *msvc*`. Best reviewed commit by commit. r? ```@marcoieni``` try-job: `*msvc*`

Rollup of 16 pull requests Successful merges: - rust-lang#126856 (remove deprecated tool `rls`) - rust-lang#136932 (Reduce formatting `width` and `precision` to 16 bits) - rust-lang#137314 (change definitely unproductive cycles to error) - rust-lang#137612 (Update bootstrap to edition 2024) - rust-lang#138002 (Disable CFI for weakly linked syscalls) - rust-lang#138052 (strip `-Wlinker-messages` wrappers from `rust-lld` rmake test) - rust-lang#138063 (Improve `-Zunpretty=hir` for parsed attrs) - rust-lang#138109 (make precise capturing args in rustdoc Json typed) - rust-lang#138147 (Add maintainers for powerpc64le-unknown-linux-gnu) - rust-lang#138245 (stabilize `ci_rustc_if_unchanged_logic` test for local environments) - rust-lang#138296 (Remove `AdtFlags::IS_ANONYMOUS` and `Copy`/`Clone` condition for anonymous ADT) - rust-lang#138300 (add tracking issue for unqualified_local_imports) - rust-lang#138307 (Allow specifying glob patterns for try jobs) - rust-lang#138313 (Update books) - rust-lang#138315 (use next_back() instead of last() on DoubleEndedIterator) - rust-lang#138318 (Rustdoc: remove a bunch of `@ts-expect-error` from main.js) r? `@ghost` `@rustbot` modify labels: rollup

Allow specifying glob patterns for try jobs This PR modifies the `try-job` lookup logic to allow glob patterns. So you can e.g. request all MSVC-related jobs with `try-job: *msvc*`. Best reviewed commit by commit. r? ````@marcoieni```` try-job: `*msvc*`

Rollup of 18 pull requests Successful merges: - rust-lang#126856 (remove deprecated tool `rls`) - rust-lang#137314 (change definitely unproductive cycles to error) - rust-lang#137504 (Move methods from Map to TyCtxt, part 4.) - rust-lang#137701 (Convert `ShardedHashMap` to use `hashbrown::HashTable`) - rust-lang#137967 ([AIX] Fix hangs during testing) - rust-lang#138002 (Disable CFI for weakly linked syscalls) - rust-lang#138052 (strip `-Wlinker-messages` wrappers from `rust-lld` rmake test) - rust-lang#138063 (Improve `-Zunpretty=hir` for parsed attrs) - rust-lang#138109 (make precise capturing args in rustdoc Json typed) - rust-lang#138147 (Add maintainers for powerpc64le-unknown-linux-gnu) - rust-lang#138245 (stabilize `ci_rustc_if_unchanged_logic` test for local environments) - rust-lang#138296 (Remove `AdtFlags::IS_ANONYMOUS` and `Copy`/`Clone` condition for anonymous ADT) - rust-lang#138300 (add tracking issue for unqualified_local_imports) - rust-lang#138307 (Allow specifying glob patterns for try jobs) - rust-lang#138313 (Update books) - rust-lang#138315 (use next_back() instead of last() on DoubleEndedIterator) - rust-lang#138318 (Rustdoc: remove a bunch of `@ts-expect-error` from main.js) - rust-lang#138330 (Remove unnecessary `[lints.rust]` sections.) Failed merges: - rust-lang#137147 (Add exclude to config.toml) r? `@ghost` `@rustbot` modify labels: rollup

Allow specifying glob patterns for try jobs This PR modifies the `try-job` lookup logic to allow glob patterns. So you can e.g. request all MSVC-related jobs with `try-job: *msvc*`. Best reviewed commit by commit. r? `````@marcoieni````` try-job: `*msvc*`

Rollup of 11 pull requests Successful merges: - rust-lang#135987 (Clarify iterator by_ref docs) - rust-lang#137967 ([AIX] Fix hangs during testing) - rust-lang#138063 (Improve `-Zunpretty=hir` for parsed attrs) - rust-lang#138147 (Add maintainers for powerpc64le-unknown-linux-gnu) - rust-lang#138288 (Document -Z crate-attr) - rust-lang#138300 (add tracking issue for unqualified_local_imports) - rust-lang#138307 (Allow specifying glob patterns for try jobs) - rust-lang#138315 (use next_back() instead of last() on DoubleEndedIterator) - rust-lang#138330 (Remove unnecessary `[lints.rust]` sections.) - rust-lang#138335 (Fix post-merge workflow) - rust-lang#138343 (Enable `f16` tests for `powf`) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 10 pull requests Successful merges: - rust-lang#135987 (Clarify iterator by_ref docs) - rust-lang#137967 ([AIX] Fix hangs during testing) - rust-lang#138063 (Improve `-Zunpretty=hir` for parsed attrs) - rust-lang#138147 (Add maintainers for powerpc64le-unknown-linux-gnu) - rust-lang#138288 (Document -Z crate-attr) - rust-lang#138300 (add tracking issue for unqualified_local_imports) - rust-lang#138307 (Allow specifying glob patterns for try jobs) - rust-lang#138315 (use next_back() instead of last() on DoubleEndedIterator) - rust-lang#138330 (Remove unnecessary `[lints.rust]` sections.) - rust-lang#138335 (Fix post-merge workflow) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#138307 - Kobzol:citool-alias, r=marcoieni Allow specifying glob patterns for try jobs This PR modifies the `try-job` lookup logic to allow glob patterns. So you can e.g. request all MSVC-related jobs with `try-job: *msvc*`. Best reviewed commit by commit. r? ``````@marcoieni`````` try-job: `*msvc*`

Make all keys explicit in citool

7ca7675

Just to avoid surprises, the amount of used keys is not large.

rustbot assigned marcoieni Mar 10, 2025

Move job handling to a separate module

0412507

Kobzol force-pushed the citool-alias branch from bd8bfce to d32fddf Compare March 10, 2025 12:45

This comment has been minimized.

# to view

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 10, 2025

Kobzol force-pushed the citool-alias branch from 503e22b to 2e48b80 Compare March 10, 2025 13:05

This comment has been minimized.

# to view

Kobzol added 4 commits March 10, 2025 14:07

Allow using glob aliases for custom try jobs

3326a9f

Modify try-job documentation

06d86cd

Handle backticks in try job patterns

dfef1a7

Ignore job duplicates

16c08f6

Kobzol force-pushed the citool-alias branch from 2e48b80 to 16c08f6 Compare March 10, 2025 13:07

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 10, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 10, 2025

jieyouxu mentioned this pull request Mar 10, 2025

Rollup of 25 pull requests #138324

Closed

jieyouxu mentioned this pull request Mar 10, 2025

Rollup of 17 pull requests #138325

Closed

jieyouxu mentioned this pull request Mar 11, 2025

Rollup of 16 pull requests #138326

Closed

jieyouxu mentioned this pull request Mar 11, 2025

Rollup of 18 pull requests #138337

Closed

Kobzol mentioned this pull request Mar 11, 2025

This Month in Our Test Infra (Jan/Feb 2025 combined issue) rust-lang/blog.rust-lang.org#1521

Merged

Kobzol mentioned this pull request Mar 11, 2025

Rollup of 11 pull requests #138348

Closed

Kobzol mentioned this pull request Mar 11, 2025

Rollup of 10 pull requests #138350

Merged

bors merged commit 3e67637 into rust-lang:master Mar 11, 2025
6 of 7 checks passed

rustbot added this to the 1.87.0 milestone Mar 11, 2025

Kobzol deleted the citool-alias branch March 11, 2025 19:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow specifying glob patterns for try jobs #138307

Allow specifying glob patterns for try jobs #138307

Kobzol commented Mar 10, 2025 •

edited

Loading

rustbot commented Mar 10, 2025

Kobzol commented Mar 10, 2025

bors commented Mar 10, 2025

This comment has been minimized.

This comment has been minimized.

bors commented Mar 10, 2025

Kobzol commented Mar 10, 2025

bors commented Mar 10, 2025

This comment has been minimized.

Kobzol commented Mar 10, 2025

bors commented Mar 10, 2025

bors commented Mar 10, 2025

Kobzol commented Mar 10, 2025

matthiaskrgr commented Mar 10, 2025

Kobzol commented Mar 10, 2025

marcoieni commented Mar 10, 2025

bors commented Mar 10, 2025

Allow specifying glob patterns for try jobs #138307

Allow specifying glob patterns for try jobs #138307

Conversation

Kobzol commented Mar 10, 2025 • edited Loading

rustbot commented Mar 10, 2025

Kobzol commented Mar 10, 2025

bors commented Mar 10, 2025

This comment has been minimized.

This comment has been minimized.

bors commented Mar 10, 2025

Kobzol commented Mar 10, 2025

bors commented Mar 10, 2025

This comment has been minimized.

Kobzol commented Mar 10, 2025

bors commented Mar 10, 2025

bors commented Mar 10, 2025

Kobzol commented Mar 10, 2025

matthiaskrgr commented Mar 10, 2025

Kobzol commented Mar 10, 2025

marcoieni commented Mar 10, 2025

bors commented Mar 10, 2025

Kobzol commented Mar 10, 2025 •

edited

Loading