-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Pass struct field HirId when check_expr_struct_fields #138460
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
There's a number of other |
I modified it. I'd love to fix the other parts, should I open a separate issue for this? Because this PR is for fixing #138319. @rustbot label -S-waiting-on-author +S-waiting-on-review |
Signed-off-by: xizheyin <xizheyin@smail.nju.edu.cn>
I have fixed the three
It report error
|
Thanks!
It's ok to leave this case without a test, if attributes are later supported in that position, they will have a correct node id. |
Pass struct field HirId when check_expr_struct_fields Fixes rust-lang#138319 r? compiler cc `@Mark-Simulacrum`
Rollup of 8 pull requests Successful merges: - rust-lang#138056 (rustc_target: Add target features for LoongArch v1.1) - rust-lang#138349 (Emit function declarations for functions with `#[linkage="extern_weak"]`) - rust-lang#138451 (Build GCC on CI with GCC, not Clang) - rust-lang#138454 (Improve post-merge workflow) - rust-lang#138460 (Pass struct field HirId when check_expr_struct_fields) - rust-lang#138482 (Fix HIR printing of parameters) - rust-lang#138507 (Mirror NetBSD sources) - rust-lang#138511 (Make `Parser::parse_expr_cond` public) r? `@ghost` `@rustbot` modify labels: rollup
Rollup of 9 pull requests Successful merges: - rust-lang#138056 (rustc_target: Add target features for LoongArch v1.1) - rust-lang#138451 (Build GCC on CI with GCC, not Clang) - rust-lang#138454 (Improve post-merge workflow) - rust-lang#138460 (Pass struct field HirId when check_expr_struct_fields) - rust-lang#138474 (Refactor is_snake_case.) - rust-lang#138482 (Fix HIR printing of parameters) - rust-lang#138507 (Mirror NetBSD sources) - rust-lang#138511 (Make `Parser::parse_expr_cond` public) - rust-lang#138518 (Fix typo in hir lowering lint diag) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#138460 - xizheyin:issue-138319, r=petrochenkov Pass struct field HirId when check_expr_struct_fields Fixes rust-lang#138319 r? compiler cc ``@Mark-Simulacrum``
Fixes #138319
r? compiler
cc @Mark-Simulacrum