Rollup of 16 pull requests #138548
Merged
Rollup of 16 pull requests #138548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These gates are unnecessary now that unit tests for `core` are in a separate package, `coretests`, instead of in the same files as the source code. They previously prevented the two `core` versions from conflicting with each other.
* Clarify relationship to `dyn` after rust-lang#133003. * Add an example of using it with `dyn` as rust-lang#133003 enabled. * Add an example of implementing it. * Add links to Rust Reference for the mentioned concepts. * Mention that its method should rarely be called. * Replace parameter name `dst` with `dest` to avoids confusion between “DeSTination” and “Dynamically-Sized Type”. * Various small corrections.
It also now demonstrates how to avoid memory leaks.
* Give example of how to get the offset of an unsized tail field (prompted by discussion <rust-lang#133055 (comment)>). * Specify the return type. * Add section headings. * Reduce “Visibility is respected…”, to a single sentence.
Co-authored-by: Thom Chiovoloni <thom@shift.click>
Co-authored-by: Thom Chiovoloni <thom@shift.click>
Co-authored-by: Thom Chiovoloni <thom@shift.click>
Signed-off-by: xizheyin <xizheyin@smail.nju.edu.cn>
rustbot
added
T-rustdoc-frontend
|
@bors r+ rollup=never p=5 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
This is an experimental post-merge analysis report. You can ignore it. Post-merge reportComparing 9f274ba (base) -> 66678e6 (this PR) Test differences
Additionally, 1357 doctest diffs were found. These are ignored, as they are noisy. Job group index
|
|
📌 Perf builds for each rolled up PR:
previous master: 9f274ba399 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Mar 16, 2025
Merged
|
Finished benchmarking commit (66678e6): comparison URL. Overall result: ❌ regressions - please read the text belowOur benchmarks found a performance regression caused by this PR. Next Steps:
@rustbot label: +perf-regression Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (primary -3.1%, secondary -1.7%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (secondary 1.0%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeResults (primary 0.1%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Bootstrap: 772.91s -> 775.015s (0.27%) |
|
@rust-timer build 50a7499 |
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (50a7499): comparison URL. Overall result: no relevant changes - no action neededInstruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (secondary 2.6%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (secondary 0.8%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 772.91s -> 772.7s (-0.03%) |
|
It's not clear to me which PR could be the culprit. Instead of wasting a bunch of perf time trying to find out, I think it's fine if we cut our losses. @rustbot label: +perf-regression-triaged |
rustbot
added
the
perf-regression-triaged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
CloneToUninitdocumentation. #133055 (ExpandCloneToUninitdocumentation.)Rvalue::WrapUnsafeBinderduring GVN #137864 (Don't dropRvalue::WrapUnsafeBinderduring GVN)#[cfg(not(test))]gates incore#138082 (Remove#[cfg(not(test))]gates incore)is_s390x_feature_detected!fromstd::arch#138275 (exposeis_s390x_feature_detected!fromstd::arch)offset_of!documentation. #138323 (Expand and organizeoffset_of!documentation.)collect#138329 (debug-assert that the size_hint is well-formed incollect)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup