-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Clean UI tests 2 of n #138639
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Clean UI tests 2 of n #138639
Conversation
Could not assign reviewer from: |
rustbot has assigned @compiler-errors. Use |
Note on modification of This test diverged a lot from it's original intention as updates to Rust were Quoted issue: #9382 Excerpt of what the struct definitions looked like originally. struct Thing1<'self> {
baz: &'self [~int],
bar: ~u64,
}
struct Thing2<'self> {
baz: &'self [~int],
bar: u64,
} |
At the end is best, otherwise there's a bunch of unnecessary number changes that is super prone to merge conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I left some feedback.
Can you make sure this is squashed into one commit at the end? There's no reason that this needs 8 commits to change 8 test files. |
Addressed the feedback @rustbot ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment nit, then please squash the commits into one
tests/ui/coercion/struct-literal-field-type-coercion-to-expected-type.rs
Outdated
Show resolved
Hide resolved
3f5a8aa
to
5e6b459
Compare
Squashed the commits and applied minor change to wording of @rustbot ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@bors r+ rollup |
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#138609 (Add stack overflow handler for cygwin) - rust-lang#138639 (Clean UI tests 2 of n) - rust-lang#138773 (catch_unwind intrinsic: document return value) - rust-lang#138782 (test(ui): add tuple-struct-where-clause-suggestion ui test for rust-lang#91520) - rust-lang#138794 (expand: Do not report `cfg_attr` traces on macros as unused attributes) - rust-lang#138801 (triagebot: add autolabel rules for D-* and L-*) - rust-lang#138804 (Allow inlining for `Atomic*::from_ptr`) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#138639 - spencer3035:clean-ui-tests-2-of-n, r=jieyouxu Clean UI tests 2 of n Modified 4 tests in tests/ui. Cleaned 3 and deleted one. I have a final commit changing the values in `src/tools/tidy/src/ui_tests.rs`. I wasn't sure if it was best practice to change this value as you go along or once at the end. I can rebase to something that incrementally changes the value in the "cleaned" commits if that is preferred. Related Issues: rust-lang#73494 rust-lang#133895 r? jieyouxu
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#138609 (Add stack overflow handler for cygwin) - rust-lang#138639 (Clean UI tests 2 of n) - rust-lang#138773 (catch_unwind intrinsic: document return value) - rust-lang#138782 (test(ui): add tuple-struct-where-clause-suggestion ui test for rust-lang#91520) - rust-lang#138794 (expand: Do not report `cfg_attr` traces on macros as unused attributes) - rust-lang#138801 (triagebot: add autolabel rules for D-* and L-*) - rust-lang#138804 (Allow inlining for `Atomic*::from_ptr`) r? `@ghost` `@rustbot` modify labels: rollup
Modified 4 tests in tests/ui. Cleaned 3 and deleted one.
I have a final commit changing the values in
src/tools/tidy/src/ui_tests.rs
.I wasn't sure if it was best practice to change this value as you go along or
once at the end. I can rebase to something that incrementally changes the value
in the "cleaned" commits if that is preferred.
Related Issues:
#73494
#133895
r? jieyouxu