Reintroduce remote-test support in run-make tests #138652

pietroalbini · 2025-03-18T09:08:36Z

The old Makefile-based infrastructure included support for executing binaries with remote-test-client if configured, but that didn't get ported to run_make_support as part of the rmake migration.

This PR re-introduces back that support, with the same implementation (and limitations) of the original Makefile-based support.

Old Makefile-based implementation of this

try-job: armhf-gnu

rustbot · 2025-03-18T09:08:41Z

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2025-03-18T09:08:43Z

The run-make-support library was changed

cc @jieyouxu

The old Makefile-based infrastructure included support for executing binaries with remote-test-client if configured, but that didn't get ported to run_make_support as part of the rmake migration. This PR re-introduces back that support, with the same implementation (and limitations) of the original Makefile-based support.

jieyouxu

Thanks, I was never sure about the remote-test-client scheme, and will have to look into it. But for this specifically, it at least preserves the current behaviour for non-remote-test-client runs, so 🤷

jieyouxu · 2025-03-18T09:12:36Z

r=me unless you have any other changes

jieyouxu · 2025-03-18T09:23:55Z

@bors r+ rollup

bors · 2025-03-18T09:23:58Z

📌 Commit 5fe1e47 has been approved by jieyouxu

It is now in the queue for this repository.

…jieyouxu Reintroduce remote-test support in run-make tests The old Makefile-based infrastructure included support for executing binaries with remote-test-client if configured, but that didn't get ported to run_make_support as part of the rmake migration. This PR re-introduces back that support, with the same implementation (and limitations) of the original Makefile-based support. [Old Makefile-based implementation of this](https://github.com/rust-lang/rust/blob/9b8accbeb6336fa24d02b2a8bcaecaf44fe2bb65/tests/run-make/tools.mk#L65-L74)

Rollup of 15 pull requests Successful merges: - rust-lang#138321 ([bootstrap] Distribute split debuginfo if present) - rust-lang#138364 (ports the compiler test cases to new rust_intrinsic format) - rust-lang#138410 (Couple mir building cleanups) - rust-lang#138435 (Add support for postfix yield expressions) - rust-lang#138536 (stable_mir: Add `MutMirVisitor`) - rust-lang#138623 ([bootstrap] Use llvm_runtimes for compiler-rt) - rust-lang#138650 (Optimize `io::Write::write_fmt` for constant strings) - rust-lang#138652 (Reintroduce remote-test support in run-make tests) - rust-lang#138685 (Use `Option<Ident>` for lowered param names.) - rust-lang#138694 (Fix: add ohos target notes) - rust-lang#138700 (Suggest `-Whelp` when pass `--print lints` to rustc) - rust-lang#138709 (Update GCC submodule) - rust-lang#138724 (Check attrs: Don't try to retrieve the name of list stems) - rust-lang#138731 (coverage: Add LLVM plumbing for expansion regions) - rust-lang#138732 (Use `def_path_str` for def id arg in `UnsupportedOpInfo`) r? `@ghost` `@rustbot` modify labels: rollup

jieyouxu · 2025-03-20T14:34:09Z

Checking if the rollup failure was spurious.
@bors r-

jieyouxu · 2025-03-20T14:34:17Z

@bors try

bors · 2025-03-20T14:35:29Z

⌛ Trying commit 5fe1e47 with merge 57b3445...

Reintroduce remote-test support in run-make tests The old Makefile-based infrastructure included support for executing binaries with remote-test-client if configured, but that didn't get ported to run_make_support as part of the rmake migration. This PR re-introduces back that support, with the same implementation (and limitations) of the original Makefile-based support. [Old Makefile-based implementation of this](https://github.com/rust-lang/rust/blob/9b8accbeb6336fa24d02b2a8bcaecaf44fe2bb65/tests/run-make/tools.mk#L65-L74) try-job: armhf-gnu

bors · 2025-03-20T15:59:45Z

💔 Test failed - checks-actions

jieyouxu · 2025-03-20T16:06:11Z

Oh, I think these two tests are missing target() flags and are trying to run a host binary? This would probably be improved by #138066.

rustbot · 2025-03-21T09:36:52Z

This PR modifies run-make tests.

cc @jieyouxu

pietroalbini · 2025-03-21T09:37:00Z

@bors try

jieyouxu · 2025-03-24T04:04:51Z

@rustbot author

pietroalbini · 2025-03-24T10:34:24Z

@bors try

pietroalbini · 2025-03-24T10:36:34Z

Not sure how I managed to close the PR.

@bors try

Reintroduce remote-test support in run-make tests The old Makefile-based infrastructure included support for executing binaries with remote-test-client if configured, but that didn't get ported to run_make_support as part of the rmake migration. This PR re-introduces back that support, with the same implementation (and limitations) of the original Makefile-based support. [Old Makefile-based implementation of this](https://github.com/rust-lang/rust/blob/9b8accbeb6336fa24d02b2a8bcaecaf44fe2bb65/tests/run-make/tools.mk#L65-L74) try-job: armhf-gnu

bors · 2025-03-24T10:37:47Z

⌛ Trying commit f5659f2 with merge 19f913c...

bors · 2025-03-24T12:00:40Z

☀️ Try build successful - checks-actions
Build commit: 19f913c (19f913c569a063fc792ea018eae7d5e57d561132)

jieyouxu · 2025-03-24T12:03:20Z

r=me unless u want to make any other changes

pietroalbini · 2025-03-24T17:52:08Z

@bors r=jieyouxu

bors · 2025-03-24T17:52:11Z

📌 Commit f5659f2 has been approved by jieyouxu

It is now in the queue for this repository.

…jieyouxu Reintroduce remote-test support in run-make tests The old Makefile-based infrastructure included support for executing binaries with remote-test-client if configured, but that didn't get ported to run_make_support as part of the rmake migration. This PR re-introduces back that support, with the same implementation (and limitations) of the original Makefile-based support. [Old Makefile-based implementation of this](https://github.com/rust-lang/rust/blob/9b8accbeb6336fa24d02b2a8bcaecaf44fe2bb65/tests/run-make/tools.mk#L65-L74) try-job: armhf-gnu

Rollup of 10 pull requests Successful merges: - rust-lang#138385 (Keyword tweaks) - rust-lang#138580 (resolve: Avoid some unstable iteration 2) - rust-lang#138652 (Reintroduce remote-test support in run-make tests) - rust-lang#138701 (Make default_codegen_backend serializable) - rust-lang#138755 ([rustdoc] Remove duplicated loop when computing doc cfgs) - rust-lang#138829 (Slightly reword triagebot ping message for `relnotes-interest-group`) - rust-lang#138837 (resolve: Avoid remaining unstable iteration) - rust-lang#138838 (Fix/tweak some tests in new solver) - rust-lang#138877 (Ignore doctests only in specified targets) - rust-lang#138895 (Add a helper for building an owner id in ast lowering) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 9 pull requests Successful merges: - rust-lang#138385 (Keyword tweaks) - rust-lang#138580 (resolve: Avoid some unstable iteration 2) - rust-lang#138652 (Reintroduce remote-test support in run-make tests) - rust-lang#138701 (Make default_codegen_backend serializable) - rust-lang#138755 ([rustdoc] Remove duplicated loop when computing doc cfgs) - rust-lang#138829 (Slightly reword triagebot ping message for `relnotes-interest-group`) - rust-lang#138837 (resolve: Avoid remaining unstable iteration) - rust-lang#138838 (Fix/tweak some tests in new solver) - rust-lang#138895 (Add a helper for building an owner id in ast lowering) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#138652 - ferrocene:pa-remote-test-rmake, r=jieyouxu Reintroduce remote-test support in run-make tests The old Makefile-based infrastructure included support for executing binaries with remote-test-client if configured, but that didn't get ported to run_make_support as part of the rmake migration. This PR re-introduces back that support, with the same implementation (and limitations) of the original Makefile-based support. [Old Makefile-based implementation of this](https://github.com/rust-lang/rust/blob/9b8accbeb6336fa24d02b2a8bcaecaf44fe2bb65/tests/run-make/tools.mk#L65-L74) try-job: armhf-gnu

rustbot assigned Mark-Simulacrum Mar 18, 2025

rustbot added A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 18, 2025

pietroalbini force-pushed the pa-remote-test-rmake branch from 9c75640 to 5fe1e47 Compare March 18, 2025 09:11

jieyouxu approved these changes Mar 18, 2025

View reviewed changes

jieyouxu assigned jieyouxu and unassigned Mark-Simulacrum Mar 18, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 18, 2025

jieyouxu mentioned this pull request Mar 20, 2025

Rollup of 15 pull requests #138733

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 20, 2025

This comment has been minimized.

# to view

rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 21, 2025

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 24, 2025

ignore tests broken while cross compiling

f5659f2

pietroalbini force-pushed the pa-remote-test-rmake branch from 6dc5705 to f5659f2 Compare March 24, 2025 10:34

pietroalbini closed this Mar 24, 2025

pietroalbini reopened this Mar 24, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 24, 2025

TaKO8Ki mentioned this pull request Mar 24, 2025

Rollup of 11 pull requests #138909

Closed

TaKO8Ki mentioned this pull request Mar 24, 2025

Rollup of 10 pull requests #138912

Closed

TaKO8Ki mentioned this pull request Mar 25, 2025

Rollup of 9 pull requests #138923

Merged

bors merged commit 3101bfb into rust-lang:master Mar 25, 2025
7 of 10 checks passed

rustbot added this to the 1.87.0 milestone Mar 25, 2025

tshepang deleted the pa-remote-test-rmake branch March 25, 2025 16:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reintroduce remote-test support in run-make tests #138652

Reintroduce remote-test support in run-make tests #138652

pietroalbini commented Mar 18, 2025 •

edited by jieyouxu

Loading

rustbot commented Mar 18, 2025

rustbot commented Mar 18, 2025

jieyouxu left a comment

jieyouxu commented Mar 18, 2025

jieyouxu commented Mar 18, 2025

bors commented Mar 18, 2025

jieyouxu commented Mar 20, 2025

jieyouxu commented Mar 20, 2025

bors commented Mar 20, 2025

This comment has been minimized.

bors commented Mar 20, 2025

jieyouxu commented Mar 20, 2025 •

edited

Loading

rustbot commented Mar 21, 2025

pietroalbini commented Mar 21, 2025

jieyouxu commented Mar 24, 2025

pietroalbini commented Mar 24, 2025

pietroalbini commented Mar 24, 2025

bors commented Mar 24, 2025

bors commented Mar 24, 2025

jieyouxu commented Mar 24, 2025

pietroalbini commented Mar 24, 2025

bors commented Mar 24, 2025

Reintroduce remote-test support in run-make tests #138652

Reintroduce remote-test support in run-make tests #138652

Conversation

pietroalbini commented Mar 18, 2025 • edited by jieyouxu Loading

rustbot commented Mar 18, 2025

rustbot commented Mar 18, 2025

jieyouxu left a comment

Choose a reason for hiding this comment

jieyouxu commented Mar 18, 2025

jieyouxu commented Mar 18, 2025

bors commented Mar 18, 2025

jieyouxu commented Mar 20, 2025

jieyouxu commented Mar 20, 2025

bors commented Mar 20, 2025

This comment has been minimized.

bors commented Mar 20, 2025

jieyouxu commented Mar 20, 2025 • edited Loading

rustbot commented Mar 21, 2025

pietroalbini commented Mar 21, 2025

jieyouxu commented Mar 24, 2025

pietroalbini commented Mar 24, 2025

pietroalbini commented Mar 24, 2025

bors commented Mar 24, 2025

bors commented Mar 24, 2025

jieyouxu commented Mar 24, 2025

pietroalbini commented Mar 24, 2025

bors commented Mar 24, 2025

pietroalbini commented Mar 18, 2025 •

edited by jieyouxu

Loading

jieyouxu commented Mar 20, 2025 •

edited

Loading