Skip to content

Add do_not_recommend typo help #138868

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Mar 24, 2025
Merged

Conversation

mejrs
Copy link
Contributor

@mejrs mejrs commented Mar 23, 2025

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Mar 23, 2025

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 23, 2025
@rust-log-analyzer

This comment has been minimized.

@mejrs mejrs force-pushed the d_not_recommend_typo branch from 32d7db5 to eb18b0e Compare March 23, 2025 23:58
@rustbot
Copy link
Collaborator

rustbot commented Mar 23, 2025

Some changes occurred in src/tools/cargo

cc @ehuss

@mejrs mejrs force-pushed the d_not_recommend_typo branch from eb18b0e to f390dd7 Compare March 24, 2025 00:02
@mejrs
Copy link
Contributor Author

mejrs commented Mar 24, 2025

Some changes occurred in src/tools/cargo

Sorry, I accidentally the git submodule 🤭 . Should be fixed now.

@davidtwco
Copy link
Member

Thanks!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Mar 24, 2025

📌 Commit f390dd7 has been approved by davidtwco

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 24, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 24, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 24, 2025
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#138601 (add FCW to warn about wasm ABI transition)
 - rust-lang#138662 (Implement some basics in UEFI fs)
 - rust-lang#138800 (remove remnants of const_box feature)
 - rust-lang#138821 (match lowering cleanup: remove unused unsizing logic from `non_scalar_compare`)
 - rust-lang#138864 (Rework `--print` options documentation)
 - rust-lang#138868 (Add do_not_recommend typo help)
 - rust-lang#138882 (`with_scope` is only ever used for ast modules)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 24, 2025
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#138662 (Implement some basics in UEFI fs)
 - rust-lang#138800 (remove remnants of const_box feature)
 - rust-lang#138821 (match lowering cleanup: remove unused unsizing logic from `non_scalar_compare`)
 - rust-lang#138864 (Rework `--print` options documentation)
 - rust-lang#138868 (Add do_not_recommend typo help)
 - rust-lang#138882 (`with_scope` is only ever used for ast modules)
 - rust-lang#138894 (Update books)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a678d20 into rust-lang:master Mar 24, 2025
6 checks passed
@rustbot rustbot added this to the 1.87.0 milestone Mar 24, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 24, 2025
Rollup merge of rust-lang#138868 - mejrs:d_not_recommend_typo, r=davidtwco

Add do_not_recommend typo help
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants