Skip to content

Ensure define_opaque attrs are accounted for in HIR hash #138954

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Mar 26, 2025

Conversation

compiler-errors
Copy link
Member

Fixes #138948

r? oli-obk

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 26, 2025
@oli-obk
Copy link
Contributor

oli-obk commented Mar 26, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Mar 26, 2025

📌 Commit 4b22ac5 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 26, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 26, 2025
Rollup of 7 pull requests

Successful merges:

 - rust-lang#138483 (Target modifiers fix for bool flags without value)
 - rust-lang#138818 (Don't produce debug information for compiler-introduced-vars when desugaring assignments.)
 - rust-lang#138898 (Mostly parser: Eliminate code that's been dead / semi-dead since the removal of type ascription syntax)
 - rust-lang#138930 (Add bootstrap step diff to CI job analysis)
 - rust-lang#138954 (Ensure `define_opaque` attrs are accounted for in HIR hash)
 - rust-lang#138959 (Revert "Make MatchPairTree::place non-optional")
 - rust-lang#138967 (Fix typo in error message)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 19a53b7 into rust-lang:master Mar 26, 2025
6 checks passed
@rustbot rustbot added this to the 1.87.0 milestone Mar 26, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 26, 2025
Rollup merge of rust-lang#138954 - compiler-errors:hash-opaques, r=oli-obk

Ensure `define_opaque` attrs are accounted for in HIR hash

Fixes rust-lang#138948

r? oli-obk
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICE: TAIT and incremental compilation
4 participants