Skip to content

Remove unused variables generated in merged doctests #139255

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Apr 4, 2025

Conversation

GuillaumeGomez
Copy link
Member

The variable is unused so no need to keep it around.

cc @notriddle
r? @camelid

@GuillaumeGomez GuillaumeGomez marked this pull request as ready for review April 2, 2025 13:47
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Apr 2, 2025
@fmease
Copy link
Member

fmease commented Apr 3, 2025

Thanks! @bors r+ rollup

@bors
Copy link
Collaborator

bors commented Apr 3, 2025

📌 Commit 1d6ddd6 has been approved by fmease

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 3, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 3, 2025
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#138017 (Tighten up assignment operator representations.)
 - rust-lang#138462 (Dedup `&mut *` reborrow suggestion in loops)
 - rust-lang#138610 (impl !PartialOrd for HirId)
 - rust-lang#138767 (Allow boolean literals in `check-cfg`)
 - rust-lang#139068 (io: Avoid marking some bytes as uninit)
 - rust-lang#139255 (Remove unused variables generated in merged doctests)
 - rust-lang#139270 (Add a mailmap entry for myself)
 - rust-lang#139303 (Put Noratrieb on vacation)
 - rust-lang#139312 (add Marco Ieni to mailmap)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ed6efe6 into rust-lang:master Apr 4, 2025
6 checks passed
@rustbot rustbot added this to the 1.88.0 milestone Apr 4, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 4, 2025
Rollup merge of rust-lang#139255 - GuillaumeGomez:unused-var-merged-doctest, r=fmease

Remove unused variables generated in merged doctests

The variable is unused so no need to keep it around.

cc `@notriddle`
r? `@camelid`
@GuillaumeGomez GuillaumeGomez deleted the unused-var-merged-doctest branch April 4, 2025 10:09
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants