Only build rust_test_helpers for {incremental,ui} test suites
#139347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-testsuite
|
@bors try |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 4, 2025
[WIP] Only build `rust_test_helpers` for `ui` test suite r? `@ghost` try-job: armhf-gnu try-job: test-various try-job: x86_64-apple-1 try-job: aarch64-apple try-job: x86_64-msvc-1 try-job: i686-msvc-1 try-job: x86_64-mingw-1 try-job: i686-mingw-1
|
... The page jumped when I was trying to adjust labels, sorry Saethlin, this doesn't need a review. |
jieyouxu
added
S-waiting-on-author
jieyouxu
force-pushed
the
rust_test_helpers
branch
from
4961bc8 to
731a5a6
Compare
This comment has been minimized.
This comment has been minimized.
jieyouxu
force-pushed
the
rust_test_helpers
branch
from
731a5a6 to
c25207d
Compare
jieyouxu
changed the title
rust_test_helpers for ui test suiterust_test_helpers for {incremental,ui} test suite
jieyouxu
changed the title
rust_test_helpers for {incremental,ui} test suiterust_test_helpers for {incremental,ui} test suites
|
@bors try |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 4, 2025
[WIP] Only build `rust_test_helpers` for `{incremental,ui}` test suites
Trying to see what test suites actually need `rust_test_helpers`, because this was blocking `./x test tests/run-make --target=wasm32-unknown-unknown` when `run-make` tests don't need `rust_test_helpers` at all.
r? `@ghost`
try-job: armhf-gnu
try-job: test-various
try-job: x86_64-apple-1
try-job: aarch64-apple
try-job: x86_64-msvc-1
try-job: i686-msvc-1
try-job: x86_64-mingw-1
try-job: i686-mingw-1
|
☀️ Try build successful - checks-actions |
jieyouxu
changed the title
rust_test_helpers for {incremental,ui} test suitesrust_test_helpers for {incremental,ui} test suites
|
r? bootstrap |
rustbot
added
S-waiting-on-review
|
I think Albert is busy? |
onur-ozkan
approved these changes
Apr 6, 2025
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 6, 2025
Rollup of 3 pull requests Successful merges: - rust-lang#139123 (tidy: Fix paths to `coretests` and `alloctests`) - rust-lang#139347 (Only build `rust_test_helpers` for `{incremental,ui}` test suites) - rust-lang#139438 (Prevent a test from seeing forbidden numbers in the rustc version) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 6, 2025
Rollup merge of rust-lang#139347 - jieyouxu:rust_test_helpers, r=onur-ozkan Only build `rust_test_helpers` for `{incremental,ui}` test suites Only build `rust_test_helpers` for `{incremental,ui}` test suites. Context: Trying to see what test suites actually need `rust_test_helpers`, because this was causing unnecessary local failures when trying to run `./x test tests/run-make --target=wasm32-unknown-unknown` when `run-make` tests don't need `rust_test_helpers` at all. r? `@ghost` try-job: armhf-gnu try-job: test-various try-job: x86_64-apple-1 try-job: aarch64-apple try-job: x86_64-msvc-1 try-job: i686-msvc-1 try-job: x86_64-mingw-1 try-job: i686-mingw-1
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only build
rust_test_helpersfor{incremental,ui}test suites.Context: Trying to see what test suites actually need
rust_test_helpers, because this was causing unnecessary local failures when trying to run./x test tests/run-make --target=wasm32-unknown-unknownwhenrun-maketests don't needrust_test_helpersat all.r? @ghost
try-job: armhf-gnu
try-job: test-various
try-job: x86_64-apple-1
try-job: aarch64-apple
try-job: x86_64-msvc-1
try-job: i686-msvc-1
try-job: x86_64-mingw-1
try-job: i686-mingw-1