Skip to content

Small smir cleanup #139404

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 5, 2025
Merged

Small smir cleanup #139404

merged 2 commits into from
Apr 5, 2025

Conversation

yotamofek
Copy link
Contributor

First commit might have small positive perf effect, second one is just to make code a bit shorter

@rustbot
Copy link
Collaborator

rustbot commented Apr 5, 2025

r? @oli-obk

rustbot has assigned @oli-obk.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 5, 2025
@compiler-errors
Copy link
Member

r? compiler-errors @bors r+ rollup

@bors
Copy link
Collaborator

bors commented Apr 5, 2025

📌 Commit 33d62dd has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 5, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Apr 5, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 5, 2025
@bors
Auto merge of rust-lang#139417 - matthiaskrgr:rollup-ktf1d6s, r=matth…
5e17a2a 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#136877 (Fix missing const for inherent pointer `replace` methods)
 - rust-lang#138797 (Fix `ProvenVia` for global where clauses)
 - rust-lang#139121 (Rename internal module from `statik` to `no_threads`)
 - rust-lang#139319 (StableMIR: Prepare for refactoring)
 - rust-lang#139404 (Small smir cleanup)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 91377bd into rust-lang:master Apr 5, 2025
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 5, 2025
@rust-timer
Unrolled build for rust-lang#139404
278e523 
Rollup merge of rust-lang#139404 - yotamofek:pr/smir/cleanup, r=compiler-errors

Small smir cleanup

First commit might have small positive perf effect, second one is just to make code a bit shorter
@rustbot rustbot added this to the 1.88.0 milestone Apr 5, 2025
@yotamofek yotamofek deleted the pr/smir/cleanup branch April 6, 2025 08:19
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@compiler-errors compiler-errors

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.88.0
Development

Successfully merging this pull request may close these issues.
5 participants
@yotamofek @rustbot @compiler-errors @bors @oli-obk