Skip to content

[WIP] middle/check_const: CheckItemRecursion should only recurse into NodeItems #13950

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 0 commits into from
May 17, 2014
Merged

[WIP] middle/check_const: CheckItemRecursion should only recurse into NodeItems #13950

merged 0 commits into from
May 17, 2014

Conversation

bgamari
Copy link
Contributor

@bgamari bgamari commented May 5, 2014

This fixes a bug in libsyntax which would crash on ASTs containing references to foreign externs. Previously the included test would fail with,

rustc' failed at 'expected item, found foreign item test_extern::test_extern (id=13)', /opt/exp/rust/src/libsyntax/ast_map.rs:264

@bgamari bgamari changed the title middle/check_const: CheckItemRecursion should only recurse into NodeItems [WIP] middle/check_const: CheckItemRecursion should only recurse into NodeItems May 5, 2014
@bgamari bgamari closed this May 5, 2014
@alexcrichton
Copy link
Member

Did you mean to close this? If you force-push then everything will be auto-updated.

Also, is there an associated issue for this? If you put Closes #XXXX then it'll be automatically closed by github when this is merged to master.

@bgamari
Copy link
Contributor Author

bgamari commented May 5, 2014

There isn't an issue. I stumbled upon this while working and fixed it after speaking with eddyb.

I closed it as the patch doesn't fix the issue completely (the test fails which I attributed to a quirk in my local configuration, I opened this pull request to see if the failure was reproducible on the CI box)

@alexcrichton
Copy link
Member

Ah ok, I'm reopening so we can keep tabs on this, you can just force-push your branch to get github to update it.

@alexcrichton alexcrichton reopened this May 5, 2014
@bgamari
Copy link
Contributor Author

bgamari commented May 9, 2014

I'm now back from travel. I'll probably have a chance to look at this again over the weekend but if anyone has any ideas about my comment above, they can only help.

@bors bors merged commit 5e10686 into rust-lang:master May 17, 2014
@bgamari bgamari mentioned this pull request May 17, 2014
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 13, 2023
@bors
Auto merge of rust-lang#13950 - WaffleLapkin:iterate_over_arrays_dire…
8800ea6 
…ctly, r=Veykril

minor: Iterate over arrays dirrectly, instead of going through a slice

Minor code improvement.
bors pushed a commit to rust-lang-ci/rust that referenced this pull request Jan 28, 2025
@blyxyas
Suggest manual_div_ceil even when right operand is a constant (rust…
7e83ec5 
…-lang#13951)

changelog: [`manual_div_ceil`]: lint constants as well

Fix rust-lang#13950
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bgamari @alexcrichton @bors