Skip to content

rustdoc-search: add unbox flag to Result aliases #139688

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 13, 2025
Merged

rustdoc-search: add unbox flag to Result aliases #139688

merged 1 commit into from
Apr 13, 2025

Conversation

notriddle
Copy link
Contributor

Fixes #139665

@rustbot
Copy link
Collaborator

rustbot commented Apr 11, 2025

r? @GuillaumeGomez

rustbot has assigned @GuillaumeGomez.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) A-rustdoc-search Area: Rustdoc's search feature S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Apr 11, 2025
@rustbot
Copy link
Collaborator

rustbot commented Apr 11, 2025

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann

@GuillaumeGomez
Copy link
Member

Nice, thanks!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Apr 12, 2025

📌 Commit e013cf8 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 12, 2025
@ChrisDenton ChrisDenton mentioned this pull request Apr 12, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 13, 2025
@bors
Auto merge of rust-lang#139724 - ChrisDenton:rollup-zhcdtzh, r=ChrisD…
26aff84 
…enton

Rollup of 8 pull requests

Successful merges:

 - rust-lang#139163 (indirect-const-stabilize the `exact_div` intrinsic)
 - rust-lang#139276 (Revert "Disable `f16` on Aarch64 without `neon`")
 - rust-lang#139315 (Switch `time` to `jiff` for time formatting in ICE dumps)
 - rust-lang#139382 (Update windows-bindgen to 0.61.0)
 - rust-lang#139688 (rustdoc-search: add unbox flag to Result aliases)
 - rust-lang#139701 (docs: clarify uint exponent for `is_power_of_two`)
 - rust-lang#139705 (Removed outdated ui test suite README, give reasons for disabled tests)
 - rust-lang#139713 (Fix typo in documentation)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 13, 2025
@bors
Auto merge of rust-lang#139724 - ChrisDenton:rollup-zhcdtzh, r=ChrisD…
fda35a6 
…enton

Rollup of 8 pull requests

Successful merges:

 - rust-lang#139163 (indirect-const-stabilize the `exact_div` intrinsic)
 - rust-lang#139276 (Revert "Disable `f16` on Aarch64 without `neon`")
 - rust-lang#139315 (Switch `time` to `jiff` for time formatting in ICE dumps)
 - rust-lang#139382 (Update windows-bindgen to 0.61.0)
 - rust-lang#139688 (rustdoc-search: add unbox flag to Result aliases)
 - rust-lang#139701 (docs: clarify uint exponent for `is_power_of_two`)
 - rust-lang#139705 (Removed outdated ui test suite README, give reasons for disabled tests)
 - rust-lang#139713 (Fix typo in documentation)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit e0f92bb into master Apr 13, 2025
6 checks passed
@bors bors deleted the notriddle/io-result-unbox branch April 13, 2025 07:09
@rustbot rustbot added this to the 1.88.0 milestone Apr 13, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 13, 2025
@rust-timer
Unrolled build for rust-lang#139688
30f9dd5 
Rollup merge of rust-lang#139688 - rust-lang:notriddle/io-result-unbox, r=GuillaumeGomez

rustdoc-search: add unbox flag to Result aliases

Fixes rust-lang#139665
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Apr 19, 2025
@ChrisDenton
Rollup merge of rust-lang#139688 - rust-lang:notriddle/io-result-unbo…
2b92d8d 
…x, r=GuillaumeGomez

rustdoc-search: add unbox flag to Result aliases

Fixes rust-lang#139665
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@GuillaumeGomez GuillaumeGomez

Labels
A-attributes Area: Attributes (`#[…]`, `#![…]`) A-rustdoc-search Area: Rustdoc's search feature S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.
Projects
None yet
Milestone
1.88.0
Development

Successfully merging this pull request may close these issues.

Allow search to find methods involving a type even when wrapped in another type
4 participants
@notriddle @rustbot @GuillaumeGomez @bors