Fix env::ArgsOs for zkVM

[thaliaarchi]

The zkVM implementation of env::ArgsOs incorrectly reports the full length even after having iterated. Instead, use a range approach which works out to be simpler. Also, implement more iterator methods like the other platforms in #139847.

cc @flaub @jbruestle @SchmErik

[rustbot]

r? @ibraheemdev

rustbot has assigned @ibraheemdev.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[thaliaarchi]

This PR fixes the iterator, but leaves the arg retrieval and copying the same. There are some interesting alternatives to be considered there.

rust/library/std/src/sys/args/zkvm.rs

Lines 21 to 38 in 2da29db

	fn argv(i: usize) -> OsString {
	let arg_len = unsafe { abi::sys_argv(crate::ptr::null_mut(), 0, i) };
	let arg_len_words = (arg_len + WORD_SIZE - 1) / WORD_SIZE;
	let words = unsafe { abi::sys_alloc_words(arg_len_words) };
	let arg_len2 = unsafe { abi::sys_argv(words, arg_len_words, i) };
	debug_assert_eq!(arg_len, arg_len2);
	// Convert to OsString.
	//
	// FIXME: We can probably get rid of the extra copy here if we
	// reimplement "os_str" instead of just using the generic unix
	// "os_str".
	let arg_bytes: &[u8] =
	unsafe { crate::slice::from_raw_parts(words.cast() as *const u8, arg_len) };
	OsString::from_inner(os_str::Buf { inner: arg_bytes.to_vec() })
	}

It looks like the memory allocated by sys_alloc_words is never freed. If that's intentional and it's 'static, then we could retrieve all the args upon construction of the first Args and store them in a OnceLock<Vec<&'static OsStr>>, then copy them to OsString on demand. However, sys_argv documents that the host controls what is returned. Is caching then inappropriate?

As for the comment about reimplementing OsString, I don't think that's a good idea. It uses one of two abstractions over Vec<u8> for the supported encodings. Although the encoding is platform-dependent, the abstractions are platform-independent. I don't like the idea of adding platform-specific logic there. It seems that the desire is to manage allocations differently with OsString. Can that currently be done with stock Vec<u8>? I'd think such logic should go there, then OsString would work.

[thaliaarchi]

I've now implemented the caching approach. The two commits are complete fixes with different approaches, so they should be considered separately until we decide.

[bors]

☔ The latest upstream changes (presumably #140581) made this pull request unmergeable. Please resolve the merge conflicts.

[flaub]

I think we'd like to test this out somehow before accepting this. It doesn't look like it will cause a problem, but I'm not entirely sure.