Skip to content

Document why CodeStats::type_sizes is public #140121

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2025
Merged

Document why CodeStats::type_sizes is public #140121

merged 1 commit into from
Apr 21, 2025

Conversation

blyxyas
Copy link
Member

@blyxyas blyxyas commented Apr 21, 2025

As indicated in this comment from #139876

Need some comment, otherwise this pub can be eventually removed as unused.

r? @nnethercote

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 21, 2025
jieyouxu
jieyouxu approved these changes Apr 21, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jieyouxu
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Apr 21, 2025

📌 Commit 619ed15 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 21, 2025
@ChrisDenton ChrisDenton mentioned this pull request Apr 21, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 21, 2025
@bors
Auto merge of rust-lang#140122 - ChrisDenton:rollup-qsj6xu0, r=ChrisD…
8f2819b 
…enton

Rollup of 8 pull requests

Successful merges:

 - rust-lang#139946 (fix missing word in comment)
 - rust-lang#139982 (SystemTime doc tweaks)
 - rust-lang#140009 (docs(LocalKey<T>): clarify that T's Drop shouldn't panic)
 - rust-lang#140021 (Don't ICE on pending obligations from deep normalization in a loop)
 - rust-lang#140029 (Relocate tests in `tests/ui`)
 - rust-lang#140030 (Fix autodiff debug builds)
 - rust-lang#140120 (Use `output_base_dir` for `mir_dump_dir`)
 - rust-lang#140121 (Document why CodeStats::type_sizes is public)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 77325f5 into rust-lang:master Apr 21, 2025
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 21, 2025
@rust-timer
Unrolled build for rust-lang#140121
c842d53 
Rollup merge of rust-lang#140121 - blyxyas:code_stats_pub_docs, r=jieyouxu

Document why CodeStats::type_sizes is public

As indicated in [this comment](rust-lang#139876 (comment)) from rust-lang#139876
> Need some comment, otherwise this pub can be eventually removed as unused.

r? `@nnethercote`
@rustbot rustbot added this to the 1.88.0 milestone Apr 21, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@nnethercote nnethercote

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.88.0
Development

Successfully merging this pull request may close these issues.
5 participants
@blyxyas @jieyouxu @bors @nnethercote @rustbot