Skip to content

rustdoc: remove unportable markdown lint and old parser #140709

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2025
Merged

rustdoc: remove unportable markdown lint and old parser #140709

merged 1 commit into from
May 7, 2025

Conversation

notriddle
Copy link
Contributor

Follow up #127127

@rustbot
Copy link
Collaborator

rustbot commented May 6, 2025

r? @GuillaumeGomez

rustbot has assigned @GuillaumeGomez.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels May 6, 2025
@rustbot
Copy link
Collaborator

rustbot commented May 6, 2025

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

GuillaumeGomez
GuillaumeGomez reviewed May 6, 2025
View reviewed changes
src/librustdoc/Cargo.toml
@@ -14,7 +14,6 @@ base64 = "0.21.7"
itertools = "0.12"
indexmap = "2"
minifier = { version = "0.3.5", default-features = false }
pulldown-cmark-old = { version = "0.9.6", package = "pulldown-cmark", default-features = false }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally! \o/

@GuillaumeGomez
Copy link
Member

Thanks for this! Looks all good to me, r=me once CI pass.

@notriddle
Copy link
Contributor Author

@bors r=GuillaumeGomez

@bors
Copy link
Collaborator

bors commented May 6, 2025

📌 Commit e648e5b has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 6, 2025
@jhpratt jhpratt mentioned this pull request May 7, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 7, 2025
@bors
Auto merge of rust-lang#140726 - jhpratt:rollup-b6oxopx, r=jhpratt
891b852 
Rollup of 9 pull requests

Successful merges:

 - rust-lang#134273 (de-stabilize bench attribute)
 - rust-lang#139534 (Added support for `apxf` target feature)
 - rust-lang#140419 (Move `in_external_macro` to `SyntaxContext`)
 - rust-lang#140483 (Comment on `Rc` abort-guard strategy without naming unrelated fn)
 - rust-lang#140607 (support duplicate entries in the opaque_type_storage)
 - rust-lang#140656 (collect all Fuchsia bindings into the `fuchsia` module)
 - rust-lang#140668 (Implement `VecDeque::truncate_front()`)
 - rust-lang#140709 (rustdoc: remove unportable markdown lint and old parser)
 - rust-lang#140713 (Structurally resolve in `check_ref_cast` in new solver)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 8984d65 into rust-lang:master May 7, 2025
6 checks passed
@rustbot rustbot added this to the 1.88.0 milestone May 7, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 7, 2025
@rust-timer
Unrolled build for rust-lang#140709
acfb7d3 
Rollup merge of rust-lang#140709 - notriddle:rm-unportable-markdown, r=GuillaumeGomez

rustdoc: remove unportable markdown lint and old parser

Follow up rust-lang#127127
crepererum added a commit to crepererum/arrow-rs that referenced this pull request May 8, 2025
@crepererum
fix: rustdoc::unportable_markdown was removed
bec649f 
Nightly CI fails with:

```text
  Documenting arrow-flight v55.0.0 (/__w/arrow-rs/arrow-rs/arrow-flight)
error: lint `rustdoc::unportable_markdown` has been removed: old parser removed
  --> arrow-flight/src/sql/mod.rs:48:14
   |
48 |     #![allow(rustdoc::unportable_markdown)]
   |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: `-D renamed-and-removed-lints` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(renamed_and_removed_lints)]`

error: could not document `arrow-flight`
```

due to rust-lang/rust#140709 .
@crepererum crepererum mentioned this pull request May 8, 2025
Merged
alamb pushed a commit to apache/arrow-rs that referenced this pull request May 8, 2025
@crepererum
fix: rustdoc::unportable_markdown was removed (#7483)
0785d3f 
Nightly CI fails with:

```text
  Documenting arrow-flight v55.0.0 (/__w/arrow-rs/arrow-rs/arrow-flight)
error: lint `rustdoc::unportable_markdown` has been removed: old parser removed
  --> arrow-flight/src/sql/mod.rs:48:14
   |
48 |     #![allow(rustdoc::unportable_markdown)]
   |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: `-D renamed-and-removed-lints` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(renamed_and_removed_lints)]`

error: could not document `arrow-flight`
```

due to rust-lang/rust#140709 .
github-actions bot pushed a commit to carolynzech/rust that referenced this pull request May 16, 2025
@bors
Auto merge of rust-lang#140726 - jhpratt:rollup-b6oxopx, r=jhpratt
922771e 
Rollup of 9 pull requests

Successful merges:

 - rust-lang#134273 (de-stabilize bench attribute)
 - rust-lang#139534 (Added support for `apxf` target feature)
 - rust-lang#140419 (Move `in_external_macro` to `SyntaxContext`)
 - rust-lang#140483 (Comment on `Rc` abort-guard strategy without naming unrelated fn)
 - rust-lang#140607 (support duplicate entries in the opaque_type_storage)
 - rust-lang#140656 (collect all Fuchsia bindings into the `fuchsia` module)
 - rust-lang#140668 (Implement `VecDeque::truncate_front()`)
 - rust-lang#140709 (rustdoc: remove unportable markdown lint and old parser)
 - rust-lang#140713 (Structurally resolve in `check_ref_cast` in new solver)

r? `@ghost`
`@rustbot` modify labels: rollup
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@GuillaumeGomez GuillaumeGomez

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.88.0
Development

Successfully merging this pull request may close these issues.
4 participants
@notriddle @rustbot @GuillaumeGomez @bors