Skip to content

Last minute relnotes fix #140864

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
May 10, 2025
Merged

Last minute relnotes fix #140864

merged 3 commits into from
May 10, 2025

Conversation

pietroalbini
Copy link
Member

This PR applies most of the suggestions in #140802 (comment) (except for as_flattened_mut, which is indeed a const stabilization this cycle), and replaces all links from nightly to stable.

r? @BoxyUwU

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-release Relevant to the release subteam, which will review and decide on the PR/issue. labels May 9, 2025
@pietroalbini pietroalbini changed the title Pa fix relnotes Last minute relnotes fix May 9, 2025
@pietroalbini
Copy link
Member Author

@bors r=BoxyUwU rollup

@bors
Copy link
Collaborator

bors commented May 9, 2025

📌 Commit 3c8efb5 has been approved by BoxyUwU

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 9, 2025
@pthariensflame
Copy link
Contributor

pthariensflame commented May 9, 2025

Thank you for this, and for catching my mistake with the as_flattened(_mut) methods!

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request May 9, 2025
…xyUwU

Last minute relnotes fix

This PR applies most of the suggestions in rust-lang#140802 (comment) (except for `as_flattened_mut`, which is indeed a const stabilization this cycle), and replaces all links from nightly to stable.

r? ``@BoxyUwU``
bors added a commit to rust-lang-ci/rust that referenced this pull request May 9, 2025
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#139863 (rustdoc: Replace unstable flag `--doctest-compilation-args` with a simpler one: `--doctest-build-arg`)
 - rust-lang#140815 (also export metrics from librustdoc)
 - rust-lang#140819 (Add regression test for 125877)
 - rust-lang#140843 (Fix `broken-pipe-no-ice` run-make test for rpath-less builds)
 - rust-lang#140848 (Improved error message for top-level or-patterns)
 - rust-lang#140852 (Update the edition guide for let chains)
 - rust-lang#140864 (Last minute relnotes fix)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 505e78a into rust-lang:master May 10, 2025
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 10, 2025
Rollup merge of rust-lang#140864 - pietroalbini:pa-fix-relnotes, r=BoxyUwU

Last minute relnotes fix

This PR applies most of the suggestions in rust-lang#140802 (comment) (except for `as_flattened_mut`, which is indeed a const stabilization this cycle), and replaces all links from nightly to stable.

r? `@BoxyUwU`
@rustbot rustbot added this to the 1.89.0 milestone May 10, 2025
@pietroalbini pietroalbini deleted the pa-fix-relnotes branch May 10, 2025 07:44
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants