Skip to content

Suggest mut when possbile for temporary value dropped while borrowed #141069

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2025
Merged

Suggest mut when possbile for temporary value dropped while borrowed #141069

merged 1 commit into from
Jun 13, 2025

Conversation

chenyukang
Copy link
Member

Fixes #137486

@rustbot
Copy link
Collaborator

rustbot commented May 16, 2025

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 16, 2025
davidtwco
davidtwco requested changes May 27, 2025
View reviewed changes
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 27, 2025
@chenyukang chenyukang force-pushed the yukang-fix-137486-suggest-mut branch from 3f6925d to e2728e7 Compare May 27, 2025 13:40
@rust-log-analyzer

This comment has been minimized.

# to view
@chenyukang chenyukang force-pushed the yukang-fix-137486-suggest-mut branch from e2728e7 to 7cb5484 Compare May 27, 2025 14:10
@rust-log-analyzer

This comment has been minimized.

# to view
@chenyukang chenyukang force-pushed the yukang-fix-137486-suggest-mut branch from 7cb5484 to d5d4cec Compare May 27, 2025 14:20
@chenyukang
Copy link
Member Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 2, 2025
@davidtwco
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 12, 2025

📌 Commit d5d4cec has been approved by davidtwco

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 12, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 12, 2025
@matthiaskrgr
Rollup merge of rust-lang#141069 - chenyukang:yukang-fix-137486-sugge…
355e7c2 
…st-mut, r=davidtwco

Suggest mut when possbile for temporary value dropped while borrowed

Fixes rust-lang#137486
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 12, 2025
Closed
bors added a commit that referenced this pull request Jun 12, 2025
@bors
Auto merge of #142422 - matthiaskrgr:rollup-0kpy7xm, r=matthiaskrgr
f874c54 
Rollup of 10 pull requests

Successful merges:

 - #134536 (Lint on fn pointers comparisons in external macros)
 - #138164 (Infrastructure for lints during attribute parsing, specifically duplicate usages of attributes)
 - #141069 (Suggest mut when possbile for temporary value dropped while borrowed)
 - #141934 (resolve: Tweak `private_macro_use` lint to be compatible with upcoming macro prelude changes)
 - #142034 (Detect method not being present that is present in other tuple types)
 - #142402 (chore(doctest): Remove redundant blank lines)
 - #142406 (Note when enum variants shadow an associated function)
 - #142407 (Remove bootstrap adhoc group)
 - #142408 (Add myself (WaffleLapkin) to review rotation)
 - #142418 (Remove lower_arg_ty as all callers were passing `None`)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 12, 2025
Merged
bors added a commit that referenced this pull request Jun 12, 2025
@bors
Auto merge of #142438 - matthiaskrgr:rollup-u1jdnhz, r=matthiaskrgr
bb3a3c5 
Rollup of 9 pull requests

Successful merges:

 - #134536 (Lint on fn pointers comparisons in external macros)
 - #141069 (Suggest mut when possbile for temporary value dropped while borrowed)
 - #141934 (resolve: Tweak `private_macro_use` lint to be compatible with upcoming macro prelude changes)
 - #142034 (Detect method not being present that is present in other tuple types)
 - #142402 (chore(doctest): Remove redundant blank lines)
 - #142406 (Note when enum variants shadow an associated function)
 - #142407 (Remove bootstrap adhoc group)
 - #142408 (Add myself (WaffleLapkin) to review rotation)
 - #142418 (Remove lower_arg_ty as all callers were passing `None`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit bfd8abd into rust-lang:master Jun 13, 2025
7 checks passed
@rustbot rustbot added this to the 1.89.0 milestone Jun 13, 2025
rust-timer added a commit that referenced this pull request Jun 13, 2025
@rust-timer
Unrolled build for #141069
cb80c76 
Rollup merge of #141069 - chenyukang:yukang-fix-137486-suggest-mut, r=davidtwco

Suggest mut when possbile for temporary value dropped while borrowed

Fixes #137486
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@davidtwco davidtwco davidtwco approved these changes

Assignees

@davidtwco davidtwco

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.89.0
Development

Successfully merging this pull request may close these issues.

fix suggestion for E0716 (temporary value dropped while borrowed)
5 participants
@chenyukang @rustbot @rust-log-analyzer @davidtwco @bors