Skip to content

Update cargo #141093

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
May 16, 2025
Merged

Update cargo #141093

merged 1 commit into from
May 16, 2025

Conversation

weihanglo
Copy link
Member

5 commits in 056f5f4f3c100cb36b5e9aed2d20b9ea70aae295..47c911e9e6f6461f90ce19142031fe16876a3b95
2025-05-09 14:54:18 +0000 to 2025-05-14 17:53:17 +0000

r? ghost

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 16, 2025
@rustbot
Copy link
Collaborator

rustbot commented May 16, 2025

Some changes occurred in src/tools/cargo

cc @ehuss

@rustbot
Copy link
Collaborator

rustbot commented May 16, 2025

⚠️ Warning ⚠️

  • Some commits in this PR modify submodules.

@weihanglo
Copy link
Member Author

@bors r+ rollup=never p=1

@bors
Copy link
Collaborator

bors commented May 16, 2025

📌 Commit 8604d45 has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 16, 2025
@bors
Copy link
Collaborator

bors commented May 16, 2025

⌛ Testing commit 8604d45 with merge 36ad75b...

@bors
Copy link
Collaborator

bors commented May 16, 2025

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing 36ad75b to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 16, 2025
@bors bors merged commit 36ad75b into rust-lang:master May 16, 2025
7 checks passed
@rustbot rustbot added this to the 1.89.0 milestone May 16, 2025
Copy link

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing fc6bfe0 (parent) -> 36ad75b (this PR)

Test differences

Show 33161 test diffs

Stage 1

  • errors::verify_const_eval_panic_non_str_7: pass -> [missing] (J0)
  • errors::verify_incremental_no_path_4: pass -> [missing] (J0)
  • errors::verify_parse_macro_rules_missing_bang_152: pass -> [missing] (J0)
  • errors::verify_passes_implied_feature_not_exist_160: pass -> [missing] (J0)
  • errors::verify_privacy_in_public_interface_2: pass -> [missing] (J0)
  • errors::verify_resolve_cannot_find_ident_in_this_scope_27: pass -> [missing] (J0)
  • html::length_limit::tests::exactly_limit: pass -> [missing] (J0)
  • lints::verify_lint_named_argument_used_positionally_139: pass -> [missing] (J0)
  • markdown::parse::tests::test_code_in_parens: pass -> [missing] (J0)
  • spec::tests::i686_pc_windows_gnullvm: pass -> [missing] (J0)
  • spec::tests::wasm32_unknown_emscripten: pass -> [missing] (J0)
  • spec::tests::wasm64_unknown_unknown: pass -> [missing] (J0)
  • transitive_relation::tests::mubs_scc_2: pass -> [missing] (J0)
  • char::test_decode_utf16_size_hint: pass -> [missing] (J1)
  • collections::vec_deque::tests::make_contiguous_big_head: pass -> [missing] (J1)
  • io::stdio::tests::stderrlock_unwind_safe: pass -> [missing] (J1)
  • mpsc::smoke_port_gone: pass -> [missing] (J1)
  • mpsc::test_recv_iter_break: pass -> [missing] (J1)
  • num::flt2dec::strategy::dragon::test_mul_pow10: pass -> [missing] (J1)
  • num::i8::test_saturating_neg: pass -> [missing] (J1)
  • num::test_try_u8usize: pass -> [missing] (J1)
  • num::u64::test_is_next_multiple_of: pass -> [missing] (J1)
  • once::wait: pass -> [missing] (J1)
  • rc::test_show: pass -> [missing] (J1)
  • slice::test_rchunks_nth: pass -> [missing] (J1)
  • slice::test_split_iterator_inclusive_reverse: pass -> [missing] (J1)
  • sort::tests::unstable::deterministic_string_random_z1: pass -> [missing] (J1)
  • str::slice_index::rangefrom_len::pass: pass -> [missing] (J1)
  • vec::test_splice_forget: pass -> [missing] (J1)
  • vec_deque::test_iter: pass -> [missing] (J1)
  • os::unix::net::tests::test_abstract_no_pathname_and_not_unnamed: pass -> [missing] (J2)
  • sort::tests::stable::correct_f128_saw_mixed: ignore -> [missing] (J3)
  • sort::tests::stable::correct_i32_random_z1_03: ignore -> [missing] (J3)
  • sort::tests::stable::correct_string_random_d20: ignore -> [missing] (J3)
  • sort::tests::stable::violate_ord_retain_orig_set_cell_i32_random_s95: ignore -> [missing] (J3)
  • sort::tests::unstable::panic_observable_is_less_random_d20: ignore -> [missing] (J3)
  • sort::tests::unstable::self_cmp_i32_ascending: ignore -> [missing] (J3)
  • ascii::is_ascii::unaligned_both_long::case00_libcore: pass -> [missing] (J4)
  • btree::map::clone_fat_val_100: pass -> [missing] (J4)
  • char::methods::bench_non_ascii_char_to_uppercase: pass -> [missing] (J4)
  • f16::test_max_nan: pass -> [missing] (J4)
  • sort::tests::stable::deterministic_i32_random_s95: pass -> [missing] (J4)
  • sort::tests::stable::stability_string_random_s95: pass -> [missing] (J4)
  • sort::tests::unstable::stability_cell_i32_descending: pass -> [missing] (J4)
  • sort::tests::unstable::stability_cell_i32_saw_mixed: pass -> [missing] (J4)
  • tests::test_should_panic_non_string_message_type: pass -> [missing] (J4)

Stage 2

  • clean::utils::tests::int_format_decimal: [missing] -> pass (J0)
  • errors::verify_codegen_ssa_rlib_incompatible_dependency_formats_43: [missing] -> pass (J0)
  • errors::verify_parse_at_in_struct_pattern_125: [missing] -> pass (J0)
  • errors::verify_passes_doc_alias_not_an_alias_25: [missing] -> pass (J0)
  • errors::verify_passes_no_mangle_72: [missing] -> pass (J0)
  • errors::verify_passes_unexportable_fn_abi_178: [missing] -> pass (J0)
  • errors::verify_session_sanitizer_cfi_requires_lto_12: [missing] -> pass (J0)
  • lints::verify_lint_builtin_const_no_mangle_27: [missing] -> pass (J0)
  • opaque::tests::test_enum: [missing] -> pass (J0)
  • parser::tests::look_ahead_non_outermost_stream: [missing] -> pass (J0)
  • session_diagnostics::verify_borrowck_lifetime_constraints_error_4: [missing] -> pass (J0)
  • spec::tests::i586_unknown_redox: [missing] -> pass (J0)
  • spec::tests::i686_pc_nto_qnx700: [missing] -> pass (J0)
  • collections::btree::set::tests::test_extract_if_drop_panic_leak: [missing] -> pass (J1)
  • collections::hash::map::tests::test_iterate: [missing] -> pass (J1)
  • f16::test_to_degrees: [missing] -> pass (J1)
  • f16::test_zero: [missing] -> pass (J1)
  • f32::test_exp2: [missing] -> pass (J1)
  • ffi::os_str::tests::test_os_string_default: [missing] -> pass (J1)
  • fmt::builders::debug_map::test_invalid_key_when_entry_is_incomplete: [missing] -> pass (J1)
  • iter::adapters::enumerate::test_iterator_enumerate_nth: [missing] -> pass (J1)
  • iter::adapters::take::test_take_advance_by: [missing] -> pass (J1)
  • iter::traits::iterator::test_min_by: [missing] -> pass (J1)
  • mem::uninit_write_iter: [missing] -> pass (J1)
  • mem::uninit_write_iter_partial: [missing] -> pass (J1)
  • misc_tests::test_show: [missing] -> pass (J1)
  • mpmc::oneshot_single_thread_close_chan_first: [missing] -> pass (J1)
  • mpsc_sync::oneshot_single_thread_peek_data: [missing] -> pass (J1)
  • mpsc_sync::stream_send_recv_stress: [missing] -> pass (J1)
  • num::int_sqrt::u128::isqrt: [missing] -> pass (J1)
  • num::u32::test_carrying_mul_add: [missing] -> pass (J1)
  • num::wrapping::test_wrapping_i16: [missing] -> pass (J1)
  • num::wrapping::test_wrapping_i64: [missing] -> pass (J1)
  • pin::pin_const: [missing] -> pass (J1)
  • rc::eq: [missing] -> pass (J1)
  • rwlock::test_get_mut_poison: [missing] -> pass (J1)
  • slice::test_array_chunks_mut_count: [missing] -> pass (J1)
  • slice::test_split_first_mut: [missing] -> pass (J1)
  • str::from_utf8_error: [missing] -> pass (J1)
  • string::test_str_truncate_invalid_len: [missing] -> pass (J1)
  • sync::mpmc::tests::waker_current_thread_id: [missing] -> pass (J1)
  • tests::self_referential: [missing] -> pass (J1)
  • time::millis: [missing] -> pass (J1)
  • vec::test_drain_empty_vec: [missing] -> pass (J1)
  • vec_deque::test_drop_panic: [missing] -> pass (J1)
  • sort::tests::stable::observable_is_less_saw_mixed: [missing] -> ignore (J3)
  • sort::tests::stable::violate_ord_retain_orig_set_string_random_d20: [missing] -> ignore (J3)
  • sort::tests::unstable::self_cmp_i32_random: [missing] -> ignore (J3)
  • btree::set::clone_100_and_clear: [missing] -> pass (J4)
  • num::bench_u16_from_str_radix_2: [missing] -> pass (J4)
  • sort::tests::stable::correct_1k_descending: [missing] -> pass (J4)
  • sort::tests::stable::correct_u64_random_d2: [missing] -> pass (J4)
  • sort::tests::unstable::deterministic_cell_i32_random_d2: [missing] -> pass (J4)
  • sort::tests::unstable::stability_i32_ascending: [missing] -> pass (J4)

(and 16515 additional test diffs)

Additionally, 16546 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 36ad75bcebece482b9980c72541469a4a8af9dbb --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-apple-2: 6973.2s -> 1421.5s (-79.6%)
  2. test-various: 4273.9s -> 2280.2s (-46.6%)
  3. x86_64-gnu-aux: 6023.1s -> 4195.3s (-30.3%)
  4. dist-arm-linux: 4586.5s -> 5634.7s (22.9%)
  5. aarch64-apple: 4312.9s -> 3644.5s (-15.5%)
  6. dist-apple-various: 8040.1s -> 7101.6s (-11.7%)
  7. dist-aarch64-apple: 5194.2s -> 4660.0s (-10.3%)
  8. dist-x86_64-illumos: 5650.8s -> 6148.6s (8.8%)
  9. dist-riscv64-linux: 5530.0s -> 5140.1s (-7.1%)
  10. x86_64-apple-1: 7011.9s -> 6603.9s (-5.8%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@weihanglo weihanglo deleted the update-cargo branch May 16, 2025 19:44
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (36ad75b): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary 6.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
6.8% [6.8%, 6.8%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 772.492s -> 771.179s (-0.17%)
Artifact size: 365.46 MiB -> 365.45 MiB (-0.00%)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants