Skip to content

skip compiler tools sanity checks on certain commands #141247

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
May 19, 2025

Conversation

onur-ozkan
Copy link
Member

Closes #141246

@rustbot
Copy link
Collaborator

rustbot commented May 19, 2025

r? @albertlarsan68

rustbot has assigned @albertlarsan68.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels May 19, 2025
@onur-ozkan onur-ozkan force-pushed the 141246 branch 2 times, most recently from 8b6f983 to 0da0ded Compare May 19, 2025 12:41
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@onur-ozkan onur-ozkan changed the title skip cc and ar sanity checks on certain commands skip compiler tools sanity checks on certain commands May 19, 2025
Copy link
Member

@albertlarsan68 albertlarsan68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@albertlarsan68
Copy link
Member

Thanks for the PR!
@bors r+

@bors
Copy link
Collaborator

bors commented May 19, 2025

📌 Commit 9da637a has been approved by albertlarsan68

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 19, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request May 19, 2025
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#131200 (Handle `rustc_query_system` cases of `rustc::potential_query_instability` lint)
 - rust-lang#141244 (windows: document that we rely on an undocumented property of GetUserProfileDirectoryW)
 - rust-lang#141247 (skip compiler tools sanity checks on certain commands)
 - rust-lang#141248 (fix data race in ReentrantLock fallback for targets without 64bit atomics)
 - rust-lang#141249 (introduce common macro for `MutVisitor` and `Visitor` to dedup code)
 - rust-lang#141253 (Warning added when dependency crate has async drop types, and the feature is disabled)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 334136f into rust-lang:master May 19, 2025
6 checks passed
@rustbot rustbot added this to the 1.89.0 milestone May 19, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 19, 2025
Rollup merge of rust-lang#141247 - onur-ozkan:141246, r=albertlarsan68

skip compiler tools sanity checks on certain commands

Closes rust-lang#141246
@onur-ozkan onur-ozkan deleted the 141246 branch May 19, 2025 19:38
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

x fmt panics with "no entry found for key" when I add an extra build target
4 participants