Skip to content

Rollup of 6 pull requests #141506

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 12 commits into from
May 24, 2025
Merged

Rollup of 6 pull requests #141506

merged 12 commits into from
May 24, 2025

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

joshlf and others added 12 commits February 20, 2025 08:23
- Implement TCP4 connect using EFI_TCP4_PROTOCOL.
- Tested on QEMU setup with connecting to TCP server on host.

Signed-off-by: Ayush Singh <ayush@beagleboard.org>
Signed-off-by: xizheyin <xizheyin@smail.nju.edu.cn>
Guarantee behavior of transmuting `Option::<T>::None` subject to NPO

In rust-lang#115333, we added a guarantee that transmuting from `[0u8; N]` to `Option<P>` is sound where `P` is a pointer type subject to the null pointer optimization (NPO). It would be useful to be able to guarantee the inverse - that a `None::<P>` value can be transmutes to an array and that will yield `[0u8; N]`.

Closes rust-lang#117591
std: sys: net: uefi: Implement TCP4 connect

- Implement TCP4 connect using EFI_TCP4_PROTOCOL.
- Tested on QEMU setup with connecting to TCP server on host.
…ler-errors

refactor `CanonicalVarKind`

it's unnecessary. I don't believe we'll ever need to store additional info shared by all `CanonicalVarKind`s.

r? `@compiler-errors`
document some -Z flags as living in the rustc-dev-guide

i was looking for these but didn't find them at first; add a breadcrumb so people know where to look
…Gomez

rustdoc book: add argument explanation for `html_playground_url`

Fixes rust-lang#141414

r? `@GuillaumeGomez`
…ions, r=Kobzol

Enable `[issue-links]` and `[no-mentions]` in triagebot

This PR enables the [`[issue-links]`](https://forge.rust-lang.org/triagebot/issue-links.html) and [`[no-mentions]`](https://forge.rust-lang.org/triagebot/no-mentions.html) handlers of triagebot.

Most of our subtrees have already adopted them:
 - rust-lang/rust-analyzer#19555
 - rust-lang/rust-clippy#14563 & rust-lang/rust-clippy#14576
 - rust-lang/rustc-dev-guide#2335
 - rust-lang/miri#4259
 - rust-lang/reference#1788

r? `@Kobzol`
@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself A-rustdoc-search Area: Rustdoc's search feature S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) rollup A PR which is a rollup labels May 24, 2025
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=5

@bors
Copy link
Collaborator

bors commented May 24, 2025

📌 Commit f84ffe2 has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 24, 2025
@bors
Copy link
Collaborator

bors commented May 24, 2025

⌛ Testing commit f84ffe2 with merge 038d599...

@bors
Copy link
Collaborator

bors commented May 24, 2025

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 038d599 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 24, 2025
@bors bors merged commit 038d599 into rust-lang:master May 24, 2025
7 checks passed
@rustbot rustbot added this to the 1.89.0 milestone May 24, 2025
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#137323 Guarantee behavior of transmuting Option::<T>::None subje… 346676243995e3507ba45e4865bec7d117e88878 (link)
#139254 std: sys: net: uefi: Implement TCP4 connect 0bd126c103c5975e4bb7db1026e2d616e7bd0e5f (link)
#141432 refactor CanonicalVarKind 8f663ed6582861ee3fb4c33db48f3ef01e7a2c25 (link)
#141480 document some -Z flags as living in the rustc-dev-guide c4a1744ed85ba29fdbfc04b886acfcc111f675c8 (link)
#141486 rustdoc book: add argument explanation for `html_playground… 491a560492428c08f18822c1ffec1d6e77c19cfb (link)
#141496 Enable [issue-links] and [no-mentions] in triagebot d42fcb7b0467cf7ff46ca5312bbd6819fe510749 (link)

previous master: 3de4f1ccf3

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 3de4f1c (parent) -> 038d599 (this PR)

Test differences

Show 296 test diffs

296 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 038d599eda4fe3e3d78103fba51ee663df86dadf --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-aarch64-linux: 7638.6s -> 5648.3s (-26.1%)
  2. x86_64-apple-1: 6425.1s -> 7930.2s (23.4%)
  3. dist-aarch64-apple: 6469.7s -> 5052.8s (-21.9%)
  4. dist-x86_64-apple: 9248.3s -> 7872.0s (-14.9%)
  5. aarch64-apple: 4140.3s -> 3682.4s (-11.1%)
  6. dist-x86_64-msvc-alt: 7289.4s -> 7995.3s (9.7%)
  7. dist-apple-various: 5987.6s -> 5448.8s (-9.0%)
  8. x86_64-apple-2: 4322.7s -> 4637.5s (7.3%)
  9. x86_64-gnu-llvm-20-1: 5121.6s -> 5429.3s (6.0%)
  10. x86_64-gnu-llvm-20-2: 5836.8s -> 6149.8s (5.4%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (038d599): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

  • If the regression was expected or you think it can be justified,
    please write a comment with sufficient written justification, and add
    @rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
  • If you think that you know of a way to resolve the regression, try to create
    a new PR with a fix for the regression.
  • If you do not understand the regression or you think that it is just noise,
    you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
    were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)
3.0% [3.0%, 3.0%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.2% [-0.2%, -0.2%] 1
All ❌✅ (primary) 3.0% [3.0%, 3.0%] 1

Max RSS (memory usage)

Results (primary -3.2%, secondary -3.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-3.2% [-3.2%, -3.2%] 1
Improvements ✅
(secondary)
-3.0% [-4.9%, -2.0%] 3
All ❌✅ (primary) -3.2% [-3.2%, -3.2%] 1

Cycles

Results (primary 2.8%, secondary 0.9%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
2.8% [2.8%, 2.8%] 1
Regressions ❌
(secondary)
0.9% [0.9%, 0.9%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 2.8% [2.8%, 2.8%] 1

Binary size

Results (primary 1.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.1% [1.1%, 1.1%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 1.1% [1.1%, 1.1%] 1

Bootstrap: 777.23s -> 775.41s (-0.23%)
Artifact size: 366.32 MiB -> 366.27 MiB (-0.01%)

@rustbot rustbot added the perf-regression Performance regression. label May 24, 2025
@rylev
Copy link
Member

rylev commented May 27, 2025

Noise in the clap benchmark

@rustbot label: +perf-regression-triaged

@rustbot rustbot added the perf-regression-triaged The performance regression has been triaged. label May 27, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself A-rustdoc-search Area: Rustdoc's search feature merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)
Projects
None yet
Development

Successfully merging this pull request may close these issues.