-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Rollup of 6 pull requests #141506
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Rollup of 6 pull requests #141506
Conversation
- Implement TCP4 connect using EFI_TCP4_PROTOCOL. - Tested on QEMU setup with connecting to TCP server on host. Signed-off-by: Ayush Singh <ayush@beagleboard.org>
Signed-off-by: xizheyin <xizheyin@smail.nju.edu.cn>
Guarantee behavior of transmuting `Option::<T>::None` subject to NPO In rust-lang#115333, we added a guarantee that transmuting from `[0u8; N]` to `Option<P>` is sound where `P` is a pointer type subject to the null pointer optimization (NPO). It would be useful to be able to guarantee the inverse - that a `None::<P>` value can be transmutes to an array and that will yield `[0u8; N]`. Closes rust-lang#117591
std: sys: net: uefi: Implement TCP4 connect - Implement TCP4 connect using EFI_TCP4_PROTOCOL. - Tested on QEMU setup with connecting to TCP server on host.
…ler-errors refactor `CanonicalVarKind` it's unnecessary. I don't believe we'll ever need to store additional info shared by all `CanonicalVarKind`s. r? `@compiler-errors`
document some -Z flags as living in the rustc-dev-guide i was looking for these but didn't find them at first; add a breadcrumb so people know where to look
…Gomez rustdoc book: add argument explanation for `html_playground_url` Fixes rust-lang#141414 r? `@GuillaumeGomez`
…ions, r=Kobzol Enable `[issue-links]` and `[no-mentions]` in triagebot This PR enables the [`[issue-links]`](https://forge.rust-lang.org/triagebot/issue-links.html) and [`[no-mentions]`](https://forge.rust-lang.org/triagebot/no-mentions.html) handlers of triagebot. Most of our subtrees have already adopted them: - rust-lang/rust-analyzer#19555 - rust-lang/rust-clippy#14563 & rust-lang/rust-clippy#14576 - rust-lang/rustc-dev-guide#2335 - rust-lang/miri#4259 - rust-lang/reference#1788 r? `@Kobzol`
@bors r+ rollup=never p=5 |
☀️ Test successful - checks-actions |
📌 Perf builds for each rolled up PR:
previous master: 3de4f1ccf3 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 3de4f1c (parent) -> 038d599 (this PR) Test differencesShow 296 test diffs296 doctest diffs were found. These are ignored, as they are noisy. Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 038d599eda4fe3e3d78103fba51ee663df86dadf --output-dir test-dashboard And then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Finished benchmarking commit (038d599): comparison URL. Overall result: ❌✅ regressions and improvements - please read the text belowOur benchmarks found a performance regression caused by this PR. Next Steps:
@rustbot label: +perf-regression Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (primary -3.2%, secondary -3.0%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (primary 2.8%, secondary 0.9%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeResults (primary 1.1%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Bootstrap: 777.23s -> 775.41s (-0.23%) |
Noise in the clap benchmark @rustbot label: +perf-regression-triaged |
Successful merges:
Option::<T>::None
subject to NPO #137323 (Guarantee behavior of transmutingOption::<T>::None
subject to NPO)CanonicalVarKind
#141432 (refactorCanonicalVarKind
)html_playground_url
#141486 (rustdoc book: add argument explanation forhtml_playground_url
)[issue-links]
and[no-mentions]
in triagebot #141496 (Enable[issue-links]
and[no-mentions]
in triagebot)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup