Fix unused_braces lint suggestion when encountering attributes
#141550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Urgau
force-pushed
the
unused_braces-attrs
branch
from
6c6a6fc to
4765fd6
Compare
|
@bors r=chenyukang |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
May 26, 2025
Rollup of 10 pull requests Successful merges: - #140898 (minor improvements on running miri) - #141392 (Avoid obligation construction dance with query region constraints) - #141431 (Emit dummy open drop for unsafe binder) - #141433 (Properly analyze captures from unsafe binders) - #141439 (Deduplicate dyn compatibility violations due to coercion) - #141449 (further deduplicate ast visitor code) - #141513 (interpret: add allocation parameters to `AllocBytes`) - #141516 (speed up charsearcher for ascii chars) - #141526 (add a dedicated section for compiler environment variables in the unstable book) - #141550 (Fix `unused_braces` lint suggestion when encountering attributes) r? `@ghost` `@rustbot` modify labels: rollup
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
May 27, 2025
Rollup of 10 pull requests Successful merges: - rust-lang/rust#140898 (minor improvements on running miri) - rust-lang/rust#141392 (Avoid obligation construction dance with query region constraints) - rust-lang/rust#141431 (Emit dummy open drop for unsafe binder) - rust-lang/rust#141433 (Properly analyze captures from unsafe binders) - rust-lang/rust#141439 (Deduplicate dyn compatibility violations due to coercion) - rust-lang/rust#141449 (further deduplicate ast visitor code) - rust-lang/rust#141513 (interpret: add allocation parameters to `AllocBytes`) - rust-lang/rust#141516 (speed up charsearcher for ascii chars) - rust-lang/rust#141526 (add a dedicated section for compiler environment variables in the unstable book) - rust-lang/rust#141550 (Fix `unused_braces` lint suggestion when encountering attributes) r? `@ghost` `@rustbot` modify labels: rollup
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the
unused_braceslint suggestion when encountering attributes by not removing them in the suggestion.Fixes #141549