Skip to content

ci: use arm to calculate job matrix #141768

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
May 31, 2025

Conversation

marcoieni
Copy link
Member

Using ARM should speed up this job

r? @Kobzol

@marcoieni
Copy link
Member Author

marcoieni commented May 30, 2025

in master with cache hit:
image

in this pr without cache hit:

image

@marcoieni marcoieni marked this pull request as ready for review May 30, 2025 13:21
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 30, 2025
@Kobzol
Copy link
Contributor

Kobzol commented May 30, 2025

Sure, why not! I think that we could speed up the build by being smarter about how we run cargo build and cargo test (because the tests actually also use cargo run 🤦‍♂️), since it's clear from the build log that a bunch of dependencies are being rebuilt repeatedly.

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 30, 2025

📌 Commit 5b68db1 has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 30, 2025
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request May 30, 2025
…Kobzol

ci: use arm to calculate job matrix
bors added a commit that referenced this pull request May 30, 2025
Rollup of 8 pull requests

Successful merges:

 - #140825 (Add Range parameter to `BTreeMap::extract_if` and `BTreeSet::extract_if`)
 - #141077 (Fix the issue of typo of comma in arm parsing)
 - #141237 (Implement ((un)checked_)exact_div methods for integers)
 - #141494 (mir-opt: Do not transform non-int type in match_branches)
 - #141609 (core: begin deduplicating pointer docs)
 - #141768 (ci: use arm to calculate job matrix)
 - #141771 (Increase timeout for new bors try builds)
 - #141781 (Fix spans for unsafe binders)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit acde85c into rust-lang:master May 31, 2025
9 checks passed
@rustbot rustbot added this to the 1.89.0 milestone May 31, 2025
rust-timer added a commit that referenced this pull request May 31, 2025
Rollup merge of #141768 - marcoieni:calculate-matrix-arm, r=Kobzol

ci: use arm to calculate job matrix
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request May 31, 2025
Rollup of 8 pull requests

Successful merges:

 - rust-lang/rust#140825 (Add Range parameter to `BTreeMap::extract_if` and `BTreeSet::extract_if`)
 - rust-lang/rust#141077 (Fix the issue of typo of comma in arm parsing)
 - rust-lang/rust#141237 (Implement ((un)checked_)exact_div methods for integers)
 - rust-lang/rust#141494 (mir-opt: Do not transform non-int type in match_branches)
 - rust-lang/rust#141609 (core: begin deduplicating pointer docs)
 - rust-lang/rust#141768 (ci: use arm to calculate job matrix)
 - rust-lang/rust#141771 (Increase timeout for new bors try builds)
 - rust-lang/rust#141781 (Fix spans for unsafe binders)

r? `@ghost`
`@rustbot` modify labels: rollup
@tshepang
Copy link
Member

tshepang commented Jun 4, 2025

Using ARM should speed up this job

is the machine more fast @marcoieni

@marcoieni
Copy link
Member Author

yes, on master took 1 minute and 14 seconds with cache hit
image

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants