Skip to content

Add link to correct documentation in htmldocck.py #141890

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2025
Merged

Add link to correct documentation in htmldocck.py #141890

merged 1 commit into from
Jun 5, 2025

Conversation

Derukugis
Copy link
Contributor

@Derukugis Derukugis commented Jun 2, 2025 •
edited by rustbot
Loading

Resolves #131974

@rustbot
Copy link
Collaborator

rustbot commented Jun 2, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jun 2, 2025
@fmease fmease assigned fmease and unassigned Mark-Simulacrum Jun 2, 2025
fmease
fmease requested changes Jun 2, 2025
View reviewed changes
Copy link
Member

@fmease fmease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 2, 2025
@fmease
Copy link
Member

fmease commented Jun 3, 2025 •
edited
Loading

Thanks! Could you please squash the 4 commits into one? Then I'll place it in the queue.

@Derukugis
Add link to correct documentation in htmldocck.py
d88c6db 
Fix typo in src/etc/htmldocck.py

Co-authored-by: León Orell Valerian Liehr <me@fmease.dev>

Change documentation link to the correct section in src/etc/htmldocck.py

Co-authored-by: León Orell Valerian Liehr <me@fmease.dev>

Remove all top-level docs from htmldocck.py
@fmease
Copy link
Member

fmease commented Jun 4, 2025

Thanks again! @bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 4, 2025

📌 Commit d88c6db has been approved by fmease

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 4, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 4, 2025
Merged
bors added a commit that referenced this pull request Jun 5, 2025
@bors
Auto merge of #142033 - matthiaskrgr:rollup-99lvg0j, r=matthiaskrgr
81a964c 
Rollup of 11 pull requests

Successful merges:

 - #141890 (Add link to correct documentation in htmldocck.py)
 - #141932 (Fix for async drop inside async gen fn)
 - #141960 (Use non-2015 edition paths in tests that do not test for their resolution)
 - #141968 (Run wfcheck in one big loop instead of per module)
 - #141969 (Triagebot: Remove `assign.users_on_vacation`)
 - #141985 (Ensure query keys are printed with reduced queries)
 - #141999 (Visit the ident in `PreciseCapturingNonLifetimeArg`.)
 - #142005 (Change `tag_field` to `FieldIdx` in `Variants::Multiple`)
 - #142017 (Fix incorrect use of "recommend" over "recommended")
 - #142024 (Don't refer to 'this tail expression' in expansion.)
 - #142025 (Don't refer to 'local binding' in extern macro.)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 4151d15 into rust-lang:master Jun 5, 2025
10 checks passed
@rustbot rustbot added this to the 1.89.0 milestone Jun 5, 2025
rust-timer added a commit that referenced this pull request Jun 5, 2025
@rust-timer
Unrolled build for #141890
e427332 
Rollup merge of #141890 - Derukugis:master, r=fmease

Add link to correct documentation in htmldocck.py
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@fmease fmease fmease approved these changes

Assignees

@fmease fmease

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.89.0
Development

Successfully merging this pull request may close these issues.

htmldocck.py: replace outdated doc comment with link to updated docs
5 participants
@Derukugis @rustbot @fmease @bors @Mark-Simulacrum