Skip to content

Stabilize feature(more_qualified_paths) #141922

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Stabilize feature(more_qualified_paths) #141922

wants to merge 5 commits into from

Conversation

WaffleLapkin
Copy link
Member

@WaffleLapkin WaffleLapkin commented Jun 2, 2025 •
edited by rustbot
Loading

Stabilization report pending.
Tracking issue: #86935

@WaffleLapkin
adjust a test
34fe1f0 
I think it's more easily readable this way
@rustbot
Copy link
Collaborator

rustbot commented Jun 2, 2025

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 2, 2025
@rust-log-analyzer

This comment has been minimized.

# to view
fee1-dead
fee1-dead approved these changes Jun 4, 2025
View reviewed changes
Copy link
Member

@fee1-dead fee1-dead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff looks fine

@fee1-dead fee1-dead added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 4, 2025
@fmease fmease mentioned this pull request Jun 4, 2025
Open
@traviscross traviscross added the T-lang Relevant to the language team label Jun 24, 2025
@bors
Copy link
Collaborator

bors commented Jul 2, 2025

☔ The latest upstream changes (presumably #143036) made this pull request unmergeable. Please resolve the merge conflicts.

@WaffleLapkin
Copy link
Member Author

@rustbot blocked

While trying to implement this feature in r-a I found a bunch of edge cases which I haven't considered before. This is blocked until we implement it in r-a (technically not required but IMO nice) and add more tests for all the edge cases (or verify there are existing ones).

@rustbot rustbot added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 4, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@fee1-dead fee1-dead fee1-dead approved these changes

Assignees

@fee1-dead fee1-dead

Labels
S-blocked Status: Blocked on something else such as an RFC or other implementation work. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-lang Relevant to the language team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@WaffleLapkin @rustbot @rust-log-analyzer @bors @fee1-dead @traviscross