Skip to content

tests/ui: A New Order [4/N] #141974

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2025
Merged

tests/ui: A New Order [4/N] #141974

merged 1 commit into from
Jun 5, 2025

Conversation

Kivooeo
Copy link
Contributor

@Kivooeo Kivooeo commented Jun 3, 2025 •
edited
Loading

Some tests/ui/ housekeeping, to trim down number of tests directly under tests/ui/. Part of #133895.

r? @jieyouxu

added stderr tag for commit which means it included generated stderr

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 3, 2025
@jieyouxu jieyouxu mentioned this pull request Jun 4, 2025
Open
jieyouxu
jieyouxu requested changes Jun 4, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I have some suggestions.

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 4, 2025
@Kivooeo
Copy link
Contributor Author

Kivooeo commented Jun 4, 2025 •
edited
Loading

@jieyouxu check one last commit, if it's fine im ready to squash

jieyouxu
jieyouxu approved these changes Jun 4, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, a few more nits for clarity, feel free to squash

@jieyouxu
Copy link
Member

jieyouxu commented Jun 4, 2025

Looks good, please squash

@rust-log-analyzer

This comment has been minimized.

# to view
@Kivooeo
Copy link
Contributor Author

Kivooeo commented Jun 4, 2025

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 4, 2025
@jieyouxu
Copy link
Member

jieyouxu commented Jun 5, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 5, 2025

📌 Commit 06ab34e has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 5, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 5, 2025
@matthiaskrgr
Rollup merge of rust-lang#141974 - Kivooeo:tf4, r=jieyouxu
5a4abf0 
`tests/ui`: A New Order [4/N]

> [!NOTE]
>
> Intermediate commits are intended to help review, but will be squashed prior to merge.

r? `@jieyouxu`

added stderr tag for commit which means it included generated stderr
This was referenced Jun 5, 2025
Closed
Merged
bors added a commit that referenced this pull request Jun 5, 2025
@bors
Auto merge of #142081 - matthiaskrgr:rollup-secpezz, r=matthiaskrgr
076ec59 
Rollup of 7 pull requests

Successful merges:

 - #141709 (jsondocck: Refactor directive handling)
 - #141974 (`tests/ui`: A New Order [4/N])
 - #141989 (rustdoc-json-type: Depend on `serde` and `serde_derive` seperately)
 - #142015 (Report the actual item that evaluation failed for)
 - #142026 (bootstrap: Fix file permissions when dereferencing symlinks)
 - #142032 (Fix parsing of frontmatters with inner hyphens)
 - #142036 (Update the `compiler-builtins` subtree)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 93e2919 into rust-lang:master Jun 5, 2025
10 checks passed
@rustbot rustbot added this to the 1.89.0 milestone Jun 5, 2025
rust-timer added a commit that referenced this pull request Jun 5, 2025
@rust-timer
Unrolled build for #141974
ac1f665 
Rollup merge of #141974 - Kivooeo:tf4, r=jieyouxu

`tests/ui`: A New Order [4/N]

> [!NOTE]
>
> Intermediate commits are intended to help review, but will be squashed prior to merge.

r? ``@jieyouxu``

added stderr tag for commit which means it included generated stderr
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Jun 6, 2025
@bors
Auto merge of #142081 - matthiaskrgr:rollup-secpezz, r=matthiaskrgr
0ba8f92 
Rollup of 7 pull requests

Successful merges:

 - rust-lang/rust#141709 (jsondocck: Refactor directive handling)
 - rust-lang/rust#141974 (`tests/ui`: A New Order [4/N])
 - rust-lang/rust#141989 (rustdoc-json-type: Depend on `serde` and `serde_derive` seperately)
 - rust-lang/rust#142015 (Report the actual item that evaluation failed for)
 - rust-lang/rust#142026 (bootstrap: Fix file permissions when dereferencing symlinks)
 - rust-lang/rust#142032 (Fix parsing of frontmatters with inner hyphens)
 - rust-lang/rust#142036 (Update the `compiler-builtins` subtree)

r? `@ghost`
`@rustbot` modify labels: rollup
github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Jun 9, 2025
@bors
Auto merge of #142081 - matthiaskrgr:rollup-secpezz, r=matthiaskrgr
2f3d5a3 
Rollup of 7 pull requests

Successful merges:

 - rust-lang/rust#141709 (jsondocck: Refactor directive handling)
 - rust-lang/rust#141974 (`tests/ui`: A New Order [4/N])
 - rust-lang/rust#141989 (rustdoc-json-type: Depend on `serde` and `serde_derive` seperately)
 - rust-lang/rust#142015 (Report the actual item that evaluation failed for)
 - rust-lang/rust#142026 (bootstrap: Fix file permissions when dereferencing symlinks)
 - rust-lang/rust#142032 (Fix parsing of frontmatters with inner hyphens)
 - rust-lang/rust#142036 (Update the `compiler-builtins` subtree)

r? `@ghost`
`@rustbot` modify labels: rollup
tgross35 pushed a commit to tgross35/compiler-builtins that referenced this pull request Jun 9, 2025
@bors
Auto merge of #142081 - matthiaskrgr:rollup-secpezz, r=matthiaskrgr
b13f70d 
Rollup of 7 pull requests

Successful merges:

 - rust-lang/rust#141709 (jsondocck: Refactor directive handling)
 - rust-lang/rust#141974 (`tests/ui`: A New Order [4/N])
 - rust-lang/rust#141989 (rustdoc-json-type: Depend on `serde` and `serde_derive` seperately)
 - rust-lang/rust#142015 (Report the actual item that evaluation failed for)
 - rust-lang/rust#142026 (bootstrap: Fix file permissions when dereferencing symlinks)
 - rust-lang/rust#142032 (Fix parsing of frontmatters with inner hyphens)
 - rust-lang/rust#142036 (Update the `compiler-builtins` subtree)

r? `@ghost`
`@rustbot` modify labels: rollup
tautschnig pushed a commit to model-checking/verify-rust-std that referenced this pull request Jun 17, 2025
@bors
Auto merge of rust-lang#142081 - matthiaskrgr:rollup-secpezz, r=matth…
33a82d6 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#141709 (jsondocck: Refactor directive handling)
 - rust-lang#141974 (`tests/ui`: A New Order [4/N])
 - rust-lang#141989 (rustdoc-json-type: Depend on `serde` and `serde_derive` seperately)
 - rust-lang#142015 (Report the actual item that evaluation failed for)
 - rust-lang#142026 (bootstrap: Fix file permissions when dereferencing symlinks)
 - rust-lang#142032 (Fix parsing of frontmatters with inner hyphens)
 - rust-lang#142036 (Update the `compiler-builtins` subtree)

r? `@ghost`
`@rustbot` modify labels: rollup
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.89.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Kivooeo @jieyouxu @rust-log-analyzer @bors @rustbot