Also emit suggestions for usages in the `non_upper_case_globals` lint #142645

Urgau · 2025-06-17T21:28:50Z

This PR adds suggestions for all the usages of the renamed item in the warning of the non_upper_case_globals lint.

rustbot · 2025-06-17T21:28:55Z

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

tests/ui/lint/lint-non-uppercase-usages.stderr

compiler/rustc_lint/src/lints.rs

fmease · 2025-06-20T17:51:05Z

This PR currently collects use sites eagerly, i.e., before the indirect call to lint_level which ultimately decides if the lint should be emitted or not. I wonder if this is noticeable perf-wise.

If this ends up perf heavy, it should be possible to turn this into a LintDiagnostic that computes these tool-only suggs lazily.

@bors2 try @rust-timer queue

rust-bors · 2025-06-20T17:51:09Z

⌛ Trying commit 09d0a73 with merge 4bb20cc…

To cancel the try build, run the command @bors2 try cancel.

Also emit suggestions for usages in the `non_upper_case_globals` lint This PR adds suggestions for all the usages of the renamed item in the warning of the `non_upper_case_globals` lint. Fixes #124061

rust-bors · 2025-06-20T20:20:14Z

☀️ Try build successful (CI)
Build commit: 4bb20cc (4bb20cc8be9c984fb2d6235080e1f44f349e6b9f, parent: 9c4ff566babe632af5e30281a822d1ae9972873b)

rust-timer · 2025-06-20T22:07:48Z

Finished benchmarking commit (4bb20cc): comparison URL.

Overall result: ❌ regressions - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	41.4%	[33.7%, 55.9%]	9
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	41.4%	[33.7%, 55.9%]	9

Max RSS (memory usage)

Results (primary 1.2%, secondary -4.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	3.1%	[3.1%, 3.1%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.7%	[-0.7%, -0.7%]	1
Improvements ✅ (secondary)	-4.2%	[-6.0%, -2.3%]	2
All ❌✅ (primary)	1.2%	[-0.7%, 3.1%]	2

Cycles

Results (primary 30.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	34.0%	[23.9%, 47.1%]	9
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.6%	[-2.6%, -2.6%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	30.3%	[-2.6%, 47.1%]	10

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 692.606s -> 715.256s (3.27%)
Artifact size: 372.01 MiB -> 372.00 MiB (-0.00%)

compiler/rustc_lint/src/nonstandard_style.rs

Urgau · 2025-06-21T09:50:27Z

@bors2 try @rust-timer queue

compiler-errors · 2025-06-22T14:09:59Z

r? fmease

rustbot · 2025-06-22T14:10:03Z

Requested reviewer is already assigned to this pull request.

Please choose another assignee.

fmease · 2025-06-22T14:18:30Z

r=me with or without final comment addressed @bors rollup

Urgau · 2025-06-22T14:47:04Z

@bors2 try @rust-timer queue

rust-bors · 2025-06-22T14:47:08Z

⌛ Trying commit 6ffd0e6 with merge 63dd59d…

To cancel the try build, run the command @bors2 try cancel.

Also emit suggestions for usages in the `non_upper_case_globals` lint This PR adds suggestions for all the usages of the renamed item in the warning of the `non_upper_case_globals` lint. Fixes #124061

rust-bors · 2025-06-22T17:16:30Z

☀️ Try build successful (CI)
Build commit: 63dd59d (63dd59d2a442bb31240549f7ed8ed7b5f038a7f3, parent: a30f1783fe136d92545423dd30b12eb619973cdb)

rust-timer · 2025-06-22T18:56:12Z

Finished benchmarking commit (63dd59d): comparison URL.

Overall result: ❌ regressions - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	2.9%	[2.9%, 2.9%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.9%	[2.9%, 2.9%]	1

Max RSS (memory usage)

Results (secondary -5.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-5.9%	[-5.9%, -5.9%]	1
All ❌✅ (primary)	-	-	0

Cycles

Results (primary 2.8%, secondary 6.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.8%	[2.8%, 2.8%]	1
Regressions ❌ (secondary)	6.9%	[6.1%, 7.8%]	4
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.8%	[2.8%, 2.8%]	1

Binary size

Results (primary 1.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.1%	[1.1%, 1.1%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.1%	[1.1%, 1.1%]	1

Bootstrap: 689.082s -> 689.565s (0.07%)
Artifact size: 371.89 MiB -> 371.87 MiB (-0.00%)

fmease · 2025-06-22T19:06:49Z

compiler/rustc_lint/src/nonstandard_style.rs

+            let can_change_usages = if let Some(did) = did {
+                !cx.tcx.effective_visibilities(()).is_exported(did)
+            } else {
+                false
+            };
+
            // We cannot provide meaningful suggestions
            // if the characters are in the category of "Lowercase Letter".
            let sub = if *name != uc {


Could you move let can_change_usages and let sub into the callback of emit_span_lint_lazy? Should fix perf

I could but I don't actually think there is any regression here, the only regressed crate is clap_derive-4.5.3/opt/full, no other benchmark, including any of the others clap_derive, or the previously regressed libc crate seems to affected and looking at the details the regression is in the backend, not the frontend. I think it's a spurious regression. What do you think?

fmease · 2025-06-24T12:09:53Z

Looks spurious indeed. @bors rollup- r+

bors · 2025-06-24T12:09:56Z

📌 Commit 6ffd0e6 has been approved by fmease

It is now in the queue for this repository.

…, r=fmease Also emit suggestions for usages in the `non_upper_case_globals` lint This PR adds suggestions for all the usages of the renamed item in the warning of the `non_upper_case_globals` lint. Fixes rust-lang#124061

Rollup of 9 pull requests Successful merges: - #142645 (Also emit suggestions for usages in the `non_upper_case_globals` lint) - #142657 (mbe: Clean up code with non-optional `NonterminalKind`) - #142799 (rustc_session: Add a structure for keeping both explicit and default sysroots) - #142805 (Emit a single error when importing a path with `_`) - #142882 (Lazy init diagnostics-only local_names in borrowck) - #142883 (Add impl_trait_in_bindings tests from #61773) - #142943 (Don't include current rustc version string in feature removed help) - #142965 ([RTE-497] Ignore `c-link-to-rust-va-list-fn` test on SGX platform) - #142972 (Add a missing mailmap entry) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #142645 - Urgau:usage-non_upper_case_globals, r=fmease Also emit suggestions for usages in the `non_upper_case_globals` lint This PR adds suggestions for all the usages of the renamed item in the warning of the `non_upper_case_globals` lint. Fixes #124061

rustbot assigned fee1-dead Jun 17, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 17, 2025

compiler-errors requested changes Jun 17, 2025

View reviewed changes

tests/ui/lint/lint-non-uppercase-usages.stderr Outdated Show resolved Hide resolved

compiler-errors assigned compiler-errors and unassigned fee1-dead Jun 17, 2025

Also emit suggestions for usages in the non_upper_case_globals lint

42bb66a

Urgau force-pushed the usage-non_upper_case_globals branch from 2589fe0 to 17f95ca Compare June 17, 2025 22:07

fmease reviewed Jun 17, 2025

View reviewed changes

compiler/rustc_lint/src/lints.rs Show resolved Hide resolved

Emit the usages suggestions as tool-only suggestions

4df9f2f

Urgau force-pushed the usage-non_upper_case_globals branch from 17f95ca to 4df9f2f Compare June 20, 2025 16:16

fmease self-assigned this Jun 20, 2025

fmease reviewed Jun 20, 2025

View reviewed changes

compiler/rustc_lint/src/lints.rs Outdated Show resolved Hide resolved

Switch non_upper_case_globals suggestions to being machine-applicable

09d0a73