Skip to content

Enable textrel-on-minimal-lib for Windows #142845

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2025
Merged

Enable textrel-on-minimal-lib for Windows #142845

merged 1 commit into from
Jun 22, 2025

Conversation

dpaoliello
Copy link
Contributor

bin_name needs to be used when building a runnable executable.

Addresses item in #128602

try-job: x86_64-mingw-*
try-job: x86_64-msvc-*
try-job: i686-msvc-*

@rustbot
Copy link
Collaborator

rustbot commented Jun 21, 2025

jieyouxu is not on the review rotation at the moment.
They may take a while to respond.

@rustbot
Copy link
Collaborator

rustbot commented Jun 21, 2025

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 21, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jun 21, 2025

This PR modifies run-make tests.

cc @jieyouxu

@jieyouxu
Copy link
Member

@bors2 delegate=try
@bors2 try

@rust-bors
Copy link

rust-bors bot commented Jun 22, 2025

@dpaoliello can now perform try builds on this pull request

@rust-bors
Copy link

rust-bors bot commented Jun 22, 2025

⌛ Trying commit 0d50f91 with merge 48e52c9…

To cancel the try build, run the command @bors2 try cancel.

rust-bors bot added a commit that referenced this pull request Jun 22, 2025
@rust-bors
Auto merge of #142845 - dpaoliello:textrel-on-minimal-lib, r=<try>
48e52c9 
Enable textrel-on-minimal-lib for Windows

`bin_name` needs to be used when building a runnable executable.

Addresses item in #128602

---

try-job: x86_64-mingw-*
try-job: x86_64-msvc-*
try-job: i686-msvc-*
@rust-bors
Copy link

rust-bors bot commented Jun 22, 2025

☀️ Try build successful (CI)
Build commit: 48e52c9 (48e52c9a9ab7b5e85e47151ffc98e5bf7b0480ff, parent: d4e1159b8c97478778b09a4cc1c7adce5653b8bf)

jieyouxu
jieyouxu approved these changes Jun 22, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks

@jieyouxu
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 22, 2025

📌 Commit 0d50f91 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 22, 2025
@jhpratt jhpratt mentioned this pull request Jun 22, 2025
Merged
bors added a commit that referenced this pull request Jun 22, 2025
@bors
Auto merge of #142864 - jhpratt:rollup-mf0yq8o, r=jhpratt
a30f178 
Rollup of 10 pull requests

Successful merges:

 - #140254 (Pass -Cpanic=abort for the panic_abort crate)
 - #142600 (Port `#[rustc_pub_transparent]` to the new attribute system)
 - #142617 (improve search graph docs, reset `encountered_overflow` between reruns)
 - #142747 (rustdoc_json: conversion cleanups)
 - #142776 (All HIR attributes are outer)
 - #142800 (integer docs: remove extraneous text)
 - #142841 (Enable fmt-write-bloat for Windows)
 - #142845 (Enable textrel-on-minimal-lib for Windows)
 - #142850 (remove asm_goto feature annotation, for it is now stabilized)
 - #142860 (Notify me on tidy changes)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b64292a into rust-lang:master Jun 22, 2025
10 checks passed
@rustbot rustbot added this to the 1.89.0 milestone Jun 22, 2025
rust-timer added a commit that referenced this pull request Jun 22, 2025
@rust-timer
Unrolled build for #142845
1a8abf5 
Rollup merge of #142845 - dpaoliello:textrel-on-minimal-lib, r=jieyouxu

Enable textrel-on-minimal-lib for Windows

`bin_name` needs to be used when building a runnable executable.

Addresses item in #128602

---

try-job: x86_64-mingw-*
try-job: x86_64-msvc-*
try-job: i686-msvc-*
@dpaoliello dpaoliello deleted the textrel-on-minimal-lib branch June 23, 2025 16:58
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels
A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.89.0
Development

Successfully merging this pull request may close these issues.
4 participants
@dpaoliello @rustbot @jieyouxu @bors